[jira] [Updated] (KAFKA-1382) Update zkVersion on partition state update failures

[ https://issues.apache.org/jira/browse/KAFKA-1382?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sriharsha Chintalapani updated KAFKA-1382: -- Attachment: KAFKA-1382_2014-06-09_18:23:42.patch > Update zkVersion on partitio

[jira] [Commented] (KAFKA-1382) Update zkVersion on partition state update failures

[ https://issues.apache.org/jira/browse/KAFKA-1382?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14026007#comment-14026007 ] Sriharsha Chintalapani commented on KAFKA-1382: --- Updated reviewboard https:/

Re: Review Request 21899: Patch for KAFKA-1382

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21899/ --- (Updated June 10, 2014, 1:23 a.m.) Review request for kafka. Bugs: KAFKA-1382

[jira] [Commented] (KAFKA-1298) Controlled shutdown tool doesn't seem to work out of the box

[ https://issues.apache.org/jira/browse/KAFKA-1298?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14025968#comment-14025968 ] Sriharsha Chintalapani commented on KAFKA-1298: --- @Jun Rao can you please che

[jira] [Updated] (KAFKA-1298) Controlled shutdown tool doesn't seem to work out of the box

[ https://issues.apache.org/jira/browse/KAFKA-1298?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sriharsha Chintalapani updated KAFKA-1298: -- Attachment: KAFKA-1298_2014-06-09_17:20:44.patch > Controlled shutdown tool doe

[jira] [Commented] (KAFKA-1298) Controlled shutdown tool doesn't seem to work out of the box

[ https://issues.apache.org/jira/browse/KAFKA-1298?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14025967#comment-14025967 ] Sriharsha Chintalapani commented on KAFKA-1298: --- Updated reviewboard https:/

Re: Review Request 22309: Patch for KAFKA-1298

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/22309/ --- (Updated June 10, 2014, 12:20 a.m.) Review request for kafka. Bugs: KAFKA-129

Re: Review Request 21899: Patch for KAFKA-1382

> On June 9, 2014, 9:33 p.m., Jun Rao wrote: > > core/src/main/scala/kafka/utils/ZkUtils.scala, lines 384-385 > > > > > > Let's add a comment on what optionalChecker is intended for. Also, > > should this parameter be

Re: Review Request 21899: Patch for KAFKA-1382

> On June 9, 2014, 9:33 p.m., Jun Rao wrote: > > core/src/main/scala/kafka/controller/KafkaController.scala, lines 1336-1346 > > > > > > Do we need to override equals()? I thought case class will do the right > > thi

Re: Review Request 21899: Patch for KAFKA-1382

> On June 9, 2014, 9:33 p.m., Jun Rao wrote: > > core/src/main/scala/kafka/utils/ReplicationUtils.scala, lines 41-64 > > > > > > The logic in the check is not quite right. We should only accept the > > written value if

Re: Review Request 21899: Patch for KAFKA-1382

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21899/#review45127 --- core/src/main/scala/kafka/controller/KafkaController.scala

[jira] [Commented] (KAFKA-1316) Refactor Sender

[ https://issues.apache.org/jira/browse/KAFKA-1316?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14025757#comment-14025757 ] Jay Kreps commented on KAFKA-1316: -- 2. Sure. I guess I don't feel this is necessarily bad

[jira] [Commented] (KAFKA-1316) Refactor Sender

[ https://issues.apache.org/jira/browse/KAFKA-1316?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14025741#comment-14025741 ] Neha Narkhede commented on KAFKA-1316: -- 2. hmm.. let me explain. So, both use metadat

[jira] [Commented] (KAFKA-1316) Refactor Sender

[ https://issues.apache.org/jira/browse/KAFKA-1316?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14025718#comment-14025718 ] Jay Kreps commented on KAFKA-1316: -- Thanks for the feedback Neha: 1. Makes sense, we can

Re: Review Request 21937: Patch for KAFKA-1316

> On June 6, 2014, 4:06 p.m., Jun Rao wrote: > > clients/src/main/java/org/apache/kafka/common/protocol/types/Schema.java, > > lines 1-16 > > > > > > Let's use the same license header in the HEADER file. The header com

Re: Review Request 21899: Patch for KAFKA-1382

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21899/#review45132 --- Ship it! Ship It! - Neha Narkhede On June 7, 2014, 4 p.m., Sriha

Re: Review Request 21937: Patch for KAFKA-1316

> On June 6, 2014, 3:18 a.m., Neha Narkhede wrote: > > clients/src/main/java/org/apache/kafka/common/requests/ProduceResponse.java, > > line 69 > > > > > > This API seems unused as well > > Jay Kreps wrote: > Thos

[jira] [Commented] (KAFKA-1316) Refactor Sender

[ https://issues.apache.org/jira/browse/KAFKA-1316?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14025663#comment-14025663 ] Neha Narkhede commented on KAFKA-1316: -- bq. So let's really put some thought into see

[jira] Subscription: outstanding kafka patches

Issue Subscription Filter: outstanding kafka patches (94 issues) The list of outstanding kafka patches Subscriber: kafka-mailing-list Key Summary KAFKA-1481 Stop using dashes AND underscores as separators in MBean names https://issues.apache.org/jira/browse/KAFKA-1481 KAFKA-14

[jira] [Commented] (KAFKA-1298) Controlled shutdown tool doesn't seem to work out of the box

[ https://issues.apache.org/jira/browse/KAFKA-1298?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14025457#comment-14025457 ] Jun Rao commented on KAFKA-1298: Sriharsha, That makes sense. Perhaps we could do the fol

Jenkins build is back to normal : Kafka-trunk #201

See

[jira] [Created] (KAFKA-1485) Upgrade to Zookeeper 3.4.x

Machiel Groeneveld created KAFKA-1485: - Summary: Upgrade to Zookeeper 3.4.x Key: KAFKA-1485 URL: https://issues.apache.org/jira/browse/KAFKA-1485 Project: Kafka Issue Type: Wish Affec

[jira] [Commented] (KAFKA-1298) Controlled shutdown tool doesn't seem to work out of the box

[ https://issues.apache.org/jira/browse/KAFKA-1298?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14025331#comment-14025331 ] Sriharsha Chintalapani commented on KAFKA-1298: --- [~junrao] [~nehanarkhede] I

[jira] [Commented] (KAFKA-1443) Add delete topic to topic commands and update DeleteTopicCommand

[ https://issues.apache.org/jira/browse/KAFKA-1443?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14025276#comment-14025276 ] Jun Rao commented on KAFKA-1443: Thanks for the patch. Could you add deleteOpt to allTopic

[jira] [Commented] (KAFKA-1438) Migrate kafka client tools

[ https://issues.apache.org/jira/browse/KAFKA-1438?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14025273#comment-14025273 ] Jun Rao commented on KAFKA-1438: Thanks for the followup patch. Committed to trunk. > Mig