[jira] [Commented] (KAFKA-1359) Add topic/broker metrics once new topic/broker is discovered

[ https://issues.apache.org/jira/browse/KAFKA-1359?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13972279#comment-13972279 ] Guozhang Wang commented on KAFKA-1359: -- After reading around on the web it seems to m

Re: Review Request 20440: Patch for KAFKA-1337

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20440/#review40629 --- Ship it! Ship It! - Guozhang Wang On April 17, 2014, 12:41 a.m.,

[jira] [Commented] (KAFKA-1337) Rationalize new producer configs

[ https://issues.apache.org/jira/browse/KAFKA-1337?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13972146#comment-13972146 ] Jay Kreps commented on KAFKA-1337: -- Created reviewboard https://reviews.apache.org/r/2044

[jira] [Commented] (KAFKA-1337) Rationalize new producer configs

[ https://issues.apache.org/jira/browse/KAFKA-1337?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13972148#comment-13972148 ] Jay Kreps commented on KAFKA-1337: -- This should be a pretty trivial patch that fixes a bu

[jira] [Updated] (KAFKA-1337) Rationalize new producer configs

[ https://issues.apache.org/jira/browse/KAFKA-1337?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jay Kreps updated KAFKA-1337: - Attachment: KAFKA-1337.patch > Rationalize new producer configs > > >

Review Request 20440: Patch for KAFKA-1337

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20440/ --- Review request for kafka. Bugs: KAFKA-1337 https://issues.apache.org/jira/b

[jira] [Reopened] (KAFKA-1337) Rationalize new producer configs

[ https://issues.apache.org/jira/browse/KAFKA-1337?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jay Kreps reopened KAFKA-1337: -- Assignee: Jay Kreps Looks like I missed a few hardcoded configs (or else they came in parallel to th

[jira] [Commented] (KAFKA-1359) Add topic/broker metrics once new topic/broker is discovered

[ https://issues.apache.org/jira/browse/KAFKA-1359?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13972139#comment-13972139 ] Jay Kreps commented on KAFKA-1359: -- My motivation was that I was under the impression tha

[jira] [Commented] (KAFKA-1359) Add topic/broker metrics once new topic/broker is discovered

[ https://issues.apache.org/jira/browse/KAFKA-1359?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13972127#comment-13972127 ] Guozhang Wang commented on KAFKA-1359: -- One follow-up observation is that we used Sys

Re: Review Request 20252: Patch for KAFKA-1356

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20252/#review40615 --- core/src/main/scala/kafka/server/KafkaApis.scala

Re: Review Request 20272: Patch for KAFKA-1356

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20272/#review40614 --- core/src/main/scala/kafka/server/KafkaApis.scala

[jira] [Commented] (KAFKA-1049) Encoder implementations are required to provide an undocumented constructor.

[ https://issues.apache.org/jira/browse/KAFKA-1049?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13972094#comment-13972094 ] Jay Kreps commented on KAFKA-1049: -- No definitely not. > Encoder implementations are req

[jira] [Commented] (KAFKA-1049) Encoder implementations are required to provide an undocumented constructor.

[ https://issues.apache.org/jira/browse/KAFKA-1049?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13972080#comment-13972080 ] Sharmarke Aden commented on KAFKA-1049: --- Very very Nice! Is it too late to chime in

[jira] [Commented] (KAFKA-1049) Encoder implementations are required to provide an undocumented constructor.

[ https://issues.apache.org/jira/browse/KAFKA-1049?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13972059#comment-13972059 ] Jay Kreps commented on KAFKA-1049: -- Yeah, the plan was just to accept byte[] for key and

[jira] [Assigned] (KAFKA-1398) Topic config changes can be lost and cause fatal exceptions on broker restarts

[ https://issues.apache.org/jira/browse/KAFKA-1398?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Joel Koshy reassigned KAFKA-1398: - Assignee: Jay Kreps > Topic config changes can be lost and cause fatal exceptions on broker resta

[jira] [Commented] (KAFKA-1397) delete topic is not working

[ https://issues.apache.org/jira/browse/KAFKA-1397?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13972033#comment-13972033 ] Jun Rao commented on KAFKA-1397: The original implementation never fully worked. > delete

[jira] [Commented] (KAFKA-1049) Encoder implementations are required to provide an undocumented constructor.

[ https://issues.apache.org/jira/browse/KAFKA-1049?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13971991#comment-13971991 ] Sharmarke Aden commented on KAFKA-1049: --- Is it safe to assume that going forward the

[jira] [Commented] (KAFKA-1397) delete topic is not working

[ https://issues.apache.org/jira/browse/KAFKA-1397?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13971988#comment-13971988 ] Jim Plush commented on KAFKA-1397: -- what was the regression that caused topic deletion to

Re: Review Request 20393: Fix KAFKA-1323: rebase on 0.8.1

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20393/#review40600 --- Ship it! Ship It! - Joel Koshy On April 16, 2014, 7:05 p.m., Guo

[jira] [Resolved] (KAFKA-1323) log.dirs server property no longer supports relative directories

[ https://issues.apache.org/jira/browse/KAFKA-1323?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Joel Koshy resolved KAFKA-1323. --- Resolution: Fixed Thanks for the patch. Committed to trunk and 0.8.1. > log.dirs server property no

[jira] [Resolved] (KAFKA-1315) log.dirs property in KafkaServer intolerant of trailing slash

[ https://issues.apache.org/jira/browse/KAFKA-1315?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Joel Koshy resolved KAFKA-1315. --- Resolution: Fixed > log.dirs property in KafkaServer intolerant of trailing slash > -

[jira] [Commented] (KAFKA-1049) Encoder implementations are required to provide an undocumented constructor.

[ https://issues.apache.org/jira/browse/KAFKA-1049?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13971890#comment-13971890 ] Jay Kreps commented on KAFKA-1049: -- The purpose is to allow configuration of the serializ

Jenkins build is back to normal : Kafka-trunk #166

See

Re: Review Request 20393: Fix KAFKA-1323: rebase on 0.8.1

> On April 16, 2014, 6:57 p.m., Joel Koshy wrote: > > Ship It! > > Joel Koshy wrote: > Actually, I ran into this: > > ReplicaManagerTest.scala:51: value tempRelativeDir is not a member of > object kafka.utils.TestUtils > props.put("log.dir", > TestUtils.tempRelativeDir("da

[jira] [Comment Edited] (KAFKA-1049) Encoder implementations are required to provide an undocumented constructor.

[ https://issues.apache.org/jira/browse/KAFKA-1049?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13971821#comment-13971821 ] Sharmarke Aden edited comment on KAFKA-1049 at 4/16/14 7:20 PM:

[jira] [Commented] (KAFKA-1049) Encoder implementations are required to provide an undocumented constructor.

[ https://issues.apache.org/jira/browse/KAFKA-1049?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13971821#comment-13971821 ] Sharmarke Aden commented on KAFKA-1049: --- What exactly is the value of VerifiableProp

[jira] [Updated] (KAFKA-1323) log.dirs server property no longer supports relative directories

[ https://issues.apache.org/jira/browse/KAFKA-1323?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Guozhang Wang updated KAFKA-1323: - Attachment: KAFKA-1323_2014-04-16_12:05:40.patch > log.dirs server property no longer supports re

[jira] [Commented] (KAFKA-1323) log.dirs server property no longer supports relative directories

[ https://issues.apache.org/jira/browse/KAFKA-1323?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13971815#comment-13971815 ] Guozhang Wang commented on KAFKA-1323: -- Updated reviewboard https://reviews.apache.or

Re: Review Request 20393: Fix KAFKA-1323: rebase on 0.8.1

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20393/ --- (Updated April 16, 2014, 7:05 p.m.) Review request for kafka. Bugs: KAFKA-132

Re: Review Request 20393: Fix KAFKA-1323: rebase on 0.8.1

> On April 16, 2014, 6:57 p.m., Joel Koshy wrote: > > Ship It! Actually, I ran into this: ReplicaManagerTest.scala:51: value tempRelativeDir is not a member of object kafka.utils.TestUtils props.put("log.dir", TestUtils.tempRelativeDir("data").getAbsolutePath) - Joel --

Re: Review Request 20393: Fix KAFKA-1323: rebase on 0.8.1

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20393/#review40590 --- Ship it! Ship It! - Joel Koshy On April 16, 2014, 6:53 p.m., Guo

[jira] [Updated] (KAFKA-1323) log.dirs server property no longer supports relative directories

[ https://issues.apache.org/jira/browse/KAFKA-1323?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Guozhang Wang updated KAFKA-1323: - Attachment: KAFKA-1323_2014-04-16_11:53:39.patch > log.dirs server property no longer supports re

[jira] [Commented] (KAFKA-1323) log.dirs server property no longer supports relative directories

[ https://issues.apache.org/jira/browse/KAFKA-1323?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13971804#comment-13971804 ] Guozhang Wang commented on KAFKA-1323: -- Updated reviewboard https://reviews.apache.or

Re: Review Request 20393: Fix KAFKA-1323: rebase on 0.8.1

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20393/ --- (Updated April 16, 2014, 6:53 p.m.) Review request for kafka. Bugs: KAFKA-132

Re: [DISCUSS] 0.8.1.1 vs 0.8.2

The 0.8.1 tag came back because some committers had the tag locally and did a push before updating their local checkouts. The tag + branch combination is confusing. E.g., if you have a local 0.8.1 branch, git log 0.8.1 will show changes on the tag, not the local branch. Committers will need to del

[jira] [Commented] (KAFKA-1365) Second Manual preferred replica leader election command always fails

[ https://issues.apache.org/jira/browse/KAFKA-1365?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13971773#comment-13971773 ] Guozhang Wang commented on KAFKA-1365: -- Has double checked that this issue has been f

[jira] [Commented] (KAFKA-1365) Second Manual preferred replica leader election command always fails

[ https://issues.apache.org/jira/browse/KAFKA-1365?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13971771#comment-13971771 ] Guozhang Wang commented on KAFKA-1365: -- Created reviewboard https://reviews.apache.or

[jira] [Updated] (KAFKA-1365) Second Manual preferred replica leader election command always fails

[ https://issues.apache.org/jira/browse/KAFKA-1365?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Guozhang Wang updated KAFKA-1365: - Attachment: KAFKA-1365.patch > Second Manual preferred replica leader election command always fai

Review Request 20424: Fix KAFKA-1365 on 0.8.1

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20424/ --- Review request for kafka. Bugs: KAFKA-1365 https://issues.apache.org/jira/b

[jira] [Updated] (KAFKA-1365) Second Manual preferred replica leader election command always fails

[ https://issues.apache.org/jira/browse/KAFKA-1365?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Joel Koshy updated KAFKA-1365: -- Fix Version/s: (was: 0.8.2) 0.8.1.1 Adding back 0.8.1.1 > Second Manual preferr

[jira] [Commented] (KAFKA-1396) fix transient unit test ProducerFailureHandlingTest.testBrokerFailure

[ https://issues.apache.org/jira/browse/KAFKA-1396?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13971720#comment-13971720 ] Guozhang Wang commented on KAFKA-1396: -- I did the same on a mac laptop and on a deskt

Re: Review Request 20272: Patch for KAFKA-1356

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20272/#review40575 --- Jun, can you move this RB to a new jira for trunk? KAFKA-1356 has be

[jira] [Resolved] (KAFKA-1359) Add topic/broker metrics once new topic/broker is discovered

[ https://issues.apache.org/jira/browse/KAFKA-1359?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jay Kreps resolved KAFKA-1359. -- Resolution: Fixed Applied. > Add topic/broker metrics once new topic/broker is discovered > --

[jira] [Commented] (KAFKA-1362) Publish sources and javadoc jars

[ https://issues.apache.org/jira/browse/KAFKA-1362?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13971668#comment-13971668 ] Joel Koshy commented on KAFKA-1362: --- [~joestein] I think I ran across a similar bug repo

[jira] [Commented] (KAFKA-1362) Publish sources and javadoc jars

[ https://issues.apache.org/jira/browse/KAFKA-1362?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13971669#comment-13971669 ] Joel Koshy commented on KAFKA-1362: --- We could just get rid of 2_8_2. We would still have

[jira] [Updated] (KAFKA-1395) fix unit tests in AutoOffsetResetTest

[ https://issues.apache.org/jira/browse/KAFKA-1395?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Guozhang Wang updated KAFKA-1395: - Attachment: KAFKA-1395_2014-04-16_10:11:30.patch > fix unit tests in AutoOffsetResetTest > --

[jira] [Commented] (KAFKA-1395) fix unit tests in AutoOffsetResetTest

[ https://issues.apache.org/jira/browse/KAFKA-1395?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13971663#comment-13971663 ] Guozhang Wang commented on KAFKA-1395: -- Updated reviewboard https://reviews.apache.or

Re: Review Request 20380: Fix KAFKA-1395: incorporate Jun's comment

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20380/ --- (Updated April 16, 2014, 5:11 p.m.) Review request for kafka. Summary (update

[jira] [Commented] (KAFKA-1359) Add topic/broker metrics once new topic/broker is discovered

[ https://issues.apache.org/jira/browse/KAFKA-1359?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13971643#comment-13971643 ] Guozhang Wang commented on KAFKA-1359: -- Updated reviewboard https://reviews.apache.or

[jira] [Updated] (KAFKA-1359) Add topic/broker metrics once new topic/broker is discovered

[ https://issues.apache.org/jira/browse/KAFKA-1359?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Guozhang Wang updated KAFKA-1359: - Attachment: KAFKA-1359_2014-04-16_09:53:55.patch > Add topic/broker metrics once new topic/broker

Re: Review Request 20050: Fix KAFKA-1359: revert to 1st patch, plus some minor changes; unit test passed

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20050/ --- (Updated April 16, 2014, 4:54 p.m.) Review request for kafka. Summary (update

[jira] [Commented] (KAFKA-1400) transient unit test failure in SocketServerTest

[ https://issues.apache.org/jira/browse/KAFKA-1400?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13971594#comment-13971594 ] Jun Rao commented on KAFKA-1400: Perhaps we should expect IOException instead of SocketExc

[jira] [Created] (KAFKA-1400) transient unit test failure in SocketServerTest

Jun Rao created KAFKA-1400: -- Summary: transient unit test failure in SocketServerTest Key: KAFKA-1400 URL: https://issues.apache.org/jira/browse/KAFKA-1400 Project: Kafka Issue Type: Bug C

[jira] [Commented] (KAFKA-1389) transient unit test failure in ProducerFailureHandlingTest

[ https://issues.apache.org/jira/browse/KAFKA-1389?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13971591#comment-13971591 ] Jun Rao commented on KAFKA-1389: We can use this opportunity to standardize the timeout in

[jira] [Updated] (KAFKA-1396) fix transient unit test ProducerFailureHandlingTest.testBrokerFailure

[ https://issues.apache.org/jira/browse/KAFKA-1396?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jun Rao updated KAFKA-1396: --- Summary: fix transient unit test ProducerFailureHandlingTest.testBrokerFailure (was: fix unit test Producer

[jira] [Resolved] (KAFKA-1391) transient unit test failure in DeleteTopicTest.testPreferredReplicaElectionDuringDeleteTopic

[ https://issues.apache.org/jira/browse/KAFKA-1391?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jun Rao resolved KAFKA-1391. Resolution: Fixed Fix Version/s: 0.8.2 The relevant unit tests are commented out for now in KAFKA-13

Re: Review Request 20380: Fix KAFKA-1395

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20380/#review40551 --- core/src/test/scala/unit/kafka/integration/AutoOffsetResetTest.scal

[jira] [Commented] (KAFKA-1362) Publish sources and javadoc jars

[ https://issues.apache.org/jira/browse/KAFKA-1362?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13970541#comment-13970541 ] Stevo Slavic commented on KAFKA-1362: - Consider dropping Scala 2.8.x support. I've jus

[jira] [Updated] (KAFKA-1399) Drop Scala 2.8.x support

[ https://issues.apache.org/jira/browse/KAFKA-1399?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Stevo Slavic updated KAFKA-1399: Summary: Drop Scala 2.8.x support (was: Drop scala 2.8.x support) > Drop Scala 2.8.x support > ---

[jira] [Created] (KAFKA-1399) Drop scala 2.8.x support

Stevo Slavic created KAFKA-1399: --- Summary: Drop scala 2.8.x support Key: KAFKA-1399 URL: https://issues.apache.org/jira/browse/KAFKA-1399 Project: Kafka Issue Type: Task Components: p