Re: Review Request 20290: Patch for KAFKA-1389

2014-04-13 Thread Guozhang Wang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20290/#review40247 --- core/src/test/scala/unit/kafka/utils/TestUtils.scala

Re: Review Request 20290: Patch for KAFKA-1389

2014-04-13 Thread Neha Narkhede
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20290/#review40231 --- core/src/test/scala/unit/kafka/utils/TestUtils.scala

[jira] [Commented] (KAFKA-1392) all TestUtiles.waitUntilTrue() should throw an exception if the return value is false

2014-04-13 Thread Jun Rao (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1392?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13967965#comment-13967965 ] Jun Rao commented on KAFKA-1392: Made a simple change to throw an exception in TestUtiles.

[jira] [Created] (KAFKA-1392) all TestUtiles.waitUntilTrue() should throw an exception if the return value is false

2014-04-13 Thread Jun Rao (JIRA)
Jun Rao created KAFKA-1392: -- Summary: all TestUtiles.waitUntilTrue() should throw an exception if the return value is false Key: KAFKA-1392 URL: https://issues.apache.org/jira/browse/KAFKA-1392 Project: Kafk

[jira] [Commented] (KAFKA-1391) transient unit test failure in DeleteTopicTest.testPreferredReplicaElectionDuringDeleteTopic

2014-04-13 Thread Jun Rao (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1391?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13967960#comment-13967960 ] Jun Rao commented on KAFKA-1391: At this moment, I am not if it's worth keeping patching t

[jira] [Commented] (KAFKA-1391) transient unit test failure in DeleteTopicTest.testPreferredReplicaElectionDuringDeleteTopic

2014-04-13 Thread Jun Rao (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1391?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13967958#comment-13967958 ] Jun Rao commented on KAFKA-1391: KAFKA-1363 doesn't quite fix the hanging issue when shutt

[jira] [Created] (KAFKA-1391) transient unit test failure in DeleteTopicTest.testPreferredReplicaElectionDuringDeleteTopic

2014-04-13 Thread Jun Rao (JIRA)
Jun Rao created KAFKA-1391: -- Summary: transient unit test failure in DeleteTopicTest.testPreferredReplicaElectionDuringDeleteTopic Key: KAFKA-1391 URL: https://issues.apache.org/jira/browse/KAFKA-1391 Projec

[jira] [Commented] (KAFKA-1389) transient unit test failure in ProducerFailureHandlingTest

2014-04-13 Thread Jun Rao (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1389?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13967938#comment-13967938 ] Jun Rao commented on KAFKA-1389: Created reviewboard https://reviews.apache.org/r/20290/

[jira] [Updated] (KAFKA-1389) transient unit test failure in ProducerFailureHandlingTest

2014-04-13 Thread Jun Rao (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1389?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jun Rao updated KAFKA-1389: --- Attachment: KAFKA-1389.patch > transient unit test failure in ProducerFailureHandlingTest > -

Review Request 20290: Patch for KAFKA-1389

2014-04-13 Thread Jun Rao
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20290/ --- Review request for kafka. Bugs: KAFKA-1389 https://issues.apache.org/jira/b

[jira] [Commented] (KAFKA-1390) TestUtils.waitUntilLeaderIsElectedOrChanged may wait longer than it needs

2014-04-13 Thread Jun Rao (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1390?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13967934#comment-13967934 ] Jun Rao commented on KAFKA-1390: A simpler, but probably more practical way is to just kee

[jira] [Created] (KAFKA-1390) TestUtils.waitUntilLeaderIsElectedOrChanged may wait longer than it needs

2014-04-13 Thread Jun Rao (JIRA)
Jun Rao created KAFKA-1390: -- Summary: TestUtils.waitUntilLeaderIsElectedOrChanged may wait longer than it needs Key: KAFKA-1390 URL: https://issues.apache.org/jira/browse/KAFKA-1390 Project: Kafka

[jira] [Created] (KAFKA-1389) transient unit test failure in ProducerFailureHandlingTest

2014-04-13 Thread Jun Rao (JIRA)
Jun Rao created KAFKA-1389: -- Summary: transient unit test failure in ProducerFailureHandlingTest Key: KAFKA-1389 URL: https://issues.apache.org/jira/browse/KAFKA-1389 Project: Kafka Issue Type: Bug

[jira] [Commented] (KAFKA-1387) Kafka getting stuck creating ephemeral node it has already created when two zookeeper sessions are established in a very short period of time

2014-04-13 Thread Guozhang Wang (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1387?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13967928#comment-13967928 ] Guozhang Wang commented on KAFKA-1387: -- I think the main issue here is when there is

Build failed in Jenkins: Kafka-trunk #164

2014-04-13 Thread Apache Jenkins Server
See Changes: [junrao] kafka-1210; Windows Bat files are not working properly; patched by Stevo Slavic; reviewed by Jun Rao -- [...truncated 377 lines...] kafka.admin.AdminTest > testManualReplicaAssi

[jira] [Updated] (KAFKA-1210) Windows Bat files are not working properly

2014-04-13 Thread Jun Rao (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1210?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jun Rao updated KAFKA-1210: --- Resolution: Fixed Assignee: Stevo Slavic Status: Resolved (was: Patch Available) Thanks for th

[jira] [Commented] (KAFKA-1387) Kafka getting stuck creating ephemeral node it has already created when two zookeeper sessions are established in a very short period of time

2014-04-13 Thread Fedor Korotkiy (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1387?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13967841#comment-13967841 ] Fedor Korotkiy commented on KAFKA-1387: --- I think it's a different issue. > Kafka ge