Re: [DISCUSS] 0.8.1.1 vs 0.8.2

Hi, You could have also done: git checkout -b 0.8.1 origin/0.8.1 Chi On Thu, Mar 20, 2014 at 5:39 PM, Neha Narkhede wrote: > The tag was the problem. I renamed the tag to 0.8.1.0 and kept the branch > as 0.8.1. That allowed me to push to the 0.8.1 branch. > > Thanks, > Neha > > > On Thu, Mar 2

Re: Review Request 19511: Patch for KAFKA-1319

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19511/#review38049 --- Ship it! Ship It! - Neha Narkhede On March 21, 2014, 1:04 a.m.,

[jira] [Commented] (KAFKA-891) Replica fetcher thread should identify its host,port in the client id

[ https://issues.apache.org/jira/browse/KAFKA-891?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13942633#comment-13942633 ] Neha Narkhede commented on KAFKA-891: - Right, the idea of client id is to identify the

Re: Review Request 19511: Patch for KAFKA-1319

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19511/#review38029 --- Ship it! Ship It! - Guozhang Wang On March 21, 2014, 1:04 a.m.,

Re: Review Request 19510: Patch for KAFKA-1318

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19510/#review38028 --- Ship it! system_test/utils/kafka_system_test_utils.py

[jira] [Commented] (KAFKA-1319) kafka jar doesn't depend on metrics-annotation any more

[ https://issues.apache.org/jira/browse/KAFKA-1319?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13942620#comment-13942620 ] Jun Rao commented on KAFKA-1319: If we do want to release 0.8.1.1, we probably should incl

[jira] [Updated] (KAFKA-1319) kafka jar doesn't depend on metrics-annotation any more

[ https://issues.apache.org/jira/browse/KAFKA-1319?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jun Rao updated KAFKA-1319: --- Attachment: KAFKA-1319.patch > kafka jar doesn't depend on metrics-annotation any more >

[jira] [Commented] (KAFKA-1319) kafka jar doesn't depend on metrics-annotation any more

[ https://issues.apache.org/jira/browse/KAFKA-1319?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13942618#comment-13942618 ] Jun Rao commented on KAFKA-1319: Created reviewboard https://reviews.apache.org/r/19511/

[jira] [Created] (KAFKA-1319) kafka jar doesn't depend on metrics-annotation any more

Jun Rao created KAFKA-1319: -- Summary: kafka jar doesn't depend on metrics-annotation any more Key: KAFKA-1319 URL: https://issues.apache.org/jira/browse/KAFKA-1319 Project: Kafka Issue Type: Bug

Review Request 19511: Patch for KAFKA-1319

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19511/ --- Review request for kafka. Bugs: KAFKA-1319 https://issues.apache.org/jira/b

[jira] [Updated] (KAFKA-1318) waiting for producer to stop is not reliable in system tests

[ https://issues.apache.org/jira/browse/KAFKA-1318?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jun Rao updated KAFKA-1318: --- Attachment: KAFKA-1318.patch > waiting for producer to stop is not reliable in system tests > ---

[jira] [Commented] (KAFKA-1318) waiting for producer to stop is not reliable in system tests

[ https://issues.apache.org/jira/browse/KAFKA-1318?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13942616#comment-13942616 ] Jun Rao commented on KAFKA-1318: Created reviewboard https://reviews.apache.org/r/19510/

Review Request 19510: Patch for KAFKA-1318

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19510/ --- Review request for kafka. Bugs: KAFKA-1318 https://issues.apache.org/jira/b

[jira] [Created] (KAFKA-1318) waiting for producer to stop is not reliable in system tests

Jun Rao created KAFKA-1318: -- Summary: waiting for producer to stop is not reliable in system tests Key: KAFKA-1318 URL: https://issues.apache.org/jira/browse/KAFKA-1318 Project: Kafka Issue Type: B

Re: [DISCUSS] 0.8.1.1 vs 0.8.2

The tag was the problem. I renamed the tag to 0.8.1.0 and kept the branch as 0.8.1. That allowed me to push to the 0.8.1 branch. Thanks, Neha On Thu, Mar 20, 2014 at 4:02 PM, Joe Stein wrote: > Right, wasn't thinking... Rushing to board. So remove 0.8.1 tag and retag > the branch as 0.8.1.0 (

[jira] [Resolved] (KAFKA-1315) log.dirs property in KafkaServer intolerant of trailing slash

[ https://issues.apache.org/jira/browse/KAFKA-1315?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Neha Narkhede resolved KAFKA-1315. -- Resolution: Fixed Thanks for the patch! Committed to 0.8.1 and trunk. > log.dirs property in K

Re: Review Request 19388: Patch for KAFKA-1251

> On March 20, 2014, 10:08 p.m., Guozhang Wang wrote: > > clients/src/main/java/org/apache/kafka/clients/producer/internals/RecordBatch.java, > > line 65 > > > > > > sizeInBytes does not work for compression, we could

Re: Review Request 19388: Patch for KAFKA-1251

> On March 20, 2014, 10:08 p.m., Guozhang Wang wrote: > > clients/src/main/java/org/apache/kafka/clients/producer/internals/RecordBatch.java, > > line 65 > > > > > > sizeInBytes does not work for compression, we could

[jira] [Commented] (KAFKA-1251) Add metrics to the producer

[ https://issues.apache.org/jira/browse/KAFKA-1251?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13942477#comment-13942477 ] Guozhang Wang commented on KAFKA-1251: -- Cool, looks good for me now. > Add metrics t

Re: [DISCUSS] 0.8.1.1 vs 0.8.2

Right, wasn't thinking... Rushing to board. So remove 0.8.1 tag and retag the branch as 0.8.1.0 ( I should have done that in the first place )? /*** Joe Stein Founder, Principal Consultant Big Data Open Source Security LLC http://www.stealth.ly Twitt

Re: [DISCUSS] 0.8.1.1 vs 0.8.2

git checkout -b 0.8.1 Didn't work. This just checks out trunk on a local branch called 0.8.1. I'd like to checkout the branch origin/0.8.1 and push the patch to the branch. For some reason, that doesn't work for me. Joel also tried and didn't work for him. I wonder if I'm missing something obvious

Re: Review Request 18299: Fix KAFKA-1253

> On March 19, 2014, 3:17 a.m., Jay Kreps wrote: > > clients/src/main/java/org/apache/kafka/common/record/CompressionFactory.java, > > line 46 > > > > > > I don't think this is needed. Inside an if statement you shoul

[jira] [Commented] (KAFKA-1251) Add metrics to the producer

[ https://issues.apache.org/jira/browse/KAFKA-1251?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13942454#comment-13942454 ] Jay Kreps commented on KAFKA-1251: -- Guozhong, 1. No idea. I did a comparison between a C

Re: [DISCUSS] 0.8.1.1 vs 0.8.2

0.8.1 is a branch (also) after a clean git clone you should be able to-do git checkout -b 0.8.1 git checkout 0.8.1 would put you on the tag agreed though we need a better name for tags moving forward or even now, about to board a plane but how about if you change/retag the last commit as 0.8.1.

Re: Review Request 17263: New producer for Kafka.

> On March 20, 2014, 8:20 p.m., Guozhang Wang wrote: > > clients/src/main/java/kafka/common/metrics/stats/SampledStat.java, lines > > 29-40 > > > > > > This is not clear to me how the logic works for resetting old samp

[jira] [Commented] (KAFKA-1155) Kafka server can miss zookeeper watches during long zkclient callbacks

[ https://issues.apache.org/jira/browse/KAFKA-1155?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13942403#comment-13942403 ] Neha Narkhede commented on KAFKA-1155: -- [~jkreps] Yes, that is how zookeeper works bu

[jira] [Updated] (KAFKA-1311) Add a flag to turn off delete topic until it is stable

[ https://issues.apache.org/jira/browse/KAFKA-1311?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Neha Narkhede updated KAFKA-1311: - Priority: Blocker (was: Major) > Add a flag to turn off delete topic until it is stable > --

Re: [DISCUSS] 0.8.1.1 vs 0.8.2

Joe, I'm unable to take patcheson 0.8.1 and the reason is probably that 0.8.1 is tag, not a branch. Should we create a branch and rename the tag to somethi

[jira] [Updated] (KAFKA-1311) Add a flag to turn off delete topic until it is stable

[ https://issues.apache.org/jira/browse/KAFKA-1311?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Neha Narkhede updated KAFKA-1311: - Fix Version/s: 0.8.1.1 > Add a flag to turn off delete topic until it is stable > ---

[jira] [Resolved] (KAFKA-190) Parallelize time-based flushes

[ https://issues.apache.org/jira/browse/KAFKA-190?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jay Kreps resolved KAFKA-190. - Resolution: Won't Fix I think this is less relevant with the new fsync management and replication code.

[jira] [Updated] (KAFKA-1057) Trim whitespaces from user specified configs

[ https://issues.apache.org/jira/browse/KAFKA-1057?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jay Kreps updated KAFKA-1057: - Labels: newbie (was: ) > Trim whitespaces from user specified configs >

[jira] [Commented] (KAFKA-1251) Add metrics to the producer

[ https://issues.apache.org/jira/browse/KAFKA-1251?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13942389#comment-13942389 ] Guozhang Wang commented on KAFKA-1251: -- Review comments in the RB (some comments on m

Re: Review Request 19388: Patch for KAFKA-1251

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19388/#review37979 --- clients/src/main/java/org/apache/kafka/clients/producer/internals/R

[jira] [Resolved] (KAFKA-1114) Add documentation for 0.8.1

[ https://issues.apache.org/jira/browse/KAFKA-1114?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jay Kreps resolved KAFKA-1114. -- Resolution: Fixed Done. > Add documentation for 0.8.1 > --- > >

[jira] [Resolved] (KAFKA-855) Ant+Ivy build for Kafka

[ https://issues.apache.org/jira/browse/KAFKA-855?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jay Kreps resolved KAFKA-855. - Resolution: Fixed We ended up doing gradle. > Ant+Ivy build for Kafka > --- > >

[jira] [Updated] (KAFKA-924) Specify console consumer properties via a single --property command line parameter

[ https://issues.apache.org/jira/browse/KAFKA-924?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jay Kreps updated KAFKA-924: Labels: newbie (was: ) > Specify console consumer properties via a single --property command line > parame

[jira] [Resolved] (KAFKA-970) ./sbt +package rebuilds the Hadoop consumer jar N times with the same output file

[ https://issues.apache.org/jira/browse/KAFKA-970?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jay Kreps resolved KAFKA-970. - Resolution: Fixed > ./sbt +package rebuilds the Hadoop consumer jar N times with the same output > file >

[jira] [Commented] (KAFKA-979) Add jitter for time based rolling

[ https://issues.apache.org/jira/browse/KAFKA-979?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13942375#comment-13942375 ] Jay Kreps commented on KAFKA-979: - KAFKA-615 isn't quite suffient. We still do fsync on log

[jira] [Updated] (KAFKA-979) Add jitter for time based rolling

[ https://issues.apache.org/jira/browse/KAFKA-979?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jay Kreps updated KAFKA-979: Labels: newbie (was: ) > Add jitter for time based rolling > - > >

[jira] [Resolved] (KAFKA-1023) Allow Injectable LogManager

[ https://issues.apache.org/jira/browse/KAFKA-1023?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jay Kreps resolved KAFKA-1023. -- Resolution: Won't Fix > Allow Injectable LogManager > --- > > K

[jira] [Commented] (KAFKA-1155) Kafka server can miss zookeeper watches during long zkclient callbacks

[ https://issues.apache.org/jira/browse/KAFKA-1155?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13942365#comment-13942365 ] Jay Kreps commented on KAFKA-1155: -- [~nehanarkhede] Is this still open? I think this is b

[jira] [Resolved] (KAFKA-1241) Cryptic serde error messages in new producer

[ https://issues.apache.org/jira/browse/KAFKA-1241?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jay Kreps resolved KAFKA-1241. -- Resolution: Fixed I believe this is fixed. > Cryptic serde error messages in new producer > --

[jira] [Resolved] (KAFKA-327) Monitoring and tooling for Kafka replication

[ https://issues.apache.org/jira/browse/KAFKA-327?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jay Kreps resolved KAFKA-327. - Resolution: Fixed Seems done. > Monitoring and tooling for Kafka replication > --

[jira] [Resolved] (KAFKA-683) Fix correlation ids in all requests sent to kafka

[ https://issues.apache.org/jira/browse/KAFKA-683?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jay Kreps resolved KAFKA-683. - Resolution: Fixed Closing since everyone ignored my code quality pleas :-) > Fix correlation ids in all r

[jira] [Resolved] (KAFKA-891) Replica fetcher thread should identify its host,port in the client id

[ https://issues.apache.org/jira/browse/KAFKA-891?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jay Kreps resolved KAFKA-891. - Resolution: Fixed The idea of the client id is really to identify an application. The host/port should be

[jira] [Resolved] (KAFKA-910) Randomize the backoff in the clients to avoid all clients from sending metadata requests at the same time

[ https://issues.apache.org/jira/browse/KAFKA-910?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jay Kreps resolved KAFKA-910. - Resolution: Duplicate > Randomize the backoff in the clients to avoid all clients from sending > metadata

[jira] [Resolved] (KAFKA-308) Corrupted message stored in log segment on disk

[ https://issues.apache.org/jira/browse/KAFKA-308?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Neha Narkhede resolved KAFKA-308. - Resolution: Cannot Reproduce > Corrupted message stored in log segment on disk > -

[jira] [Commented] (KAFKA-308) Corrupted message stored in log segment on disk

[ https://issues.apache.org/jira/browse/KAFKA-308?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13942351#comment-13942351 ] Neha Narkhede commented on KAFKA-308: - Yes, agree. > Corrupted message stored in log s

[jira] [Resolved] (KAFKA-834) Update Kafka 0.8 website documentation

[ https://issues.apache.org/jira/browse/KAFKA-834?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jay Kreps resolved KAFKA-834. - Resolution: Fixed > Update Kafka 0.8 website documentation > -- > >

[jira] [Resolved] (KAFKA-833) Kafka 0.8 beta release

[ https://issues.apache.org/jira/browse/KAFKA-833?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jay Kreps resolved KAFKA-833. - Resolution: Fixed > Kafka 0.8 beta release > -- > > Key: KAFKA-833 >

[jira] [Commented] (KAFKA-308) Corrupted message stored in log segment on disk

[ https://issues.apache.org/jira/browse/KAFKA-308?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13942349#comment-13942349 ] Jay Kreps commented on KAFKA-308: - [~nehanarkhede] If no updates perhaps we should close th

[jira] [Resolved] (KAFKA-1171) Gradle build for Kafka

[ https://issues.apache.org/jira/browse/KAFKA-1171?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jay Kreps resolved KAFKA-1171. -- Resolution: Fixed > Gradle build for Kafka > -- > > Key: KAFKA-1171

[jira] [Resolved] (KAFKA-1095) Kafka does not compile with sbt

[ https://issues.apache.org/jira/browse/KAFKA-1095?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jay Kreps resolved KAFKA-1095. -- Resolution: Fixed We moved off sbt so presumably this is no longer valid. > Kafka does not compile wit

[jira] [Resolved] (KAFKA-535) Significant difference in time taken to produce messages between 1, -1 for request-num-acks

[ https://issues.apache.org/jira/browse/KAFKA-535?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jay Kreps resolved KAFKA-535. - Resolution: Fixed I don't think this is a bug and is in any way fixed in the new producer. > Significant

[jira] [Updated] (KAFKA-649) Cleanup log4j logging

[ https://issues.apache.org/jira/browse/KAFKA-649?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jay Kreps updated KAFKA-649: Resolution: Fixed Status: Resolved (was: Patch Available) Closing as it looks like this was checked

[jira] [Updated] (KAFKA-885) sbt package builds two kafka jars

[ https://issues.apache.org/jira/browse/KAFKA-885?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jay Kreps updated KAFKA-885: Resolution: Invalid Status: Resolved (was: Patch Available) We are on gradle now. > sbt package bu

[jira] [Commented] (KAFKA-821) specifying a non-existent partition to ./bin/kafka-reassign-partitions.sh breaks all reassignment ops

[ https://issues.apache.org/jira/browse/KAFKA-821?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13942338#comment-13942338 ] Jay Kreps commented on KAFKA-821: - [~nehanarkhede] Does this bug still exist? > specifying

[jira] [Commented] (KAFKA-1317) KafkaServer 0.8.1 not responding to .shutdown() cleanly, possibly related to TopicDeletionManager or MetricsMeter state

[ https://issues.apache.org/jira/browse/KAFKA-1317?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13942322#comment-13942322 ] Jay Kreps commented on KAFKA-1317: -- Gotcha. > KafkaServer 0.8.1 not responding to .shutd

[jira] [Updated] (KAFKA-1) The log4j appender still uses the SyncProducer API

[ https://issues.apache.org/jira/browse/KAFKA-1?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Timothy Chen updated KAFKA-1: - Attachment: (was: KAFKA-1_2014-03-19_13:38:39.patch) > The log4j appender still uses the SyncProducer AP

[jira] [Issue Comment Deleted] (KAFKA-1) The log4j appender still uses the SyncProducer API

[ https://issues.apache.org/jira/browse/KAFKA-1?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Timothy Chen updated KAFKA-1: - Comment: was deleted (was: Updated reviewboard against branch origin/trunk) > The log4j appender still use

[jira] [Commented] (KAFKA-1317) KafkaServer 0.8.1 not responding to .shutdown() cleanly, possibly related to TopicDeletionManager or MetricsMeter state

[ https://issues.apache.org/jira/browse/KAFKA-1317?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13942299#comment-13942299 ] Jay Kreps commented on KAFKA-1317: -- Actually non-daemon is not wrong. There are two cases

[jira] [Commented] (KAFKA-1317) KafkaServer 0.8.1 not responding to .shutdown() cleanly, possibly related to TopicDeletionManager or MetricsMeter state

[ https://issues.apache.org/jira/browse/KAFKA-1317?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13942315#comment-13942315 ] Neha Narkhede commented on KAFKA-1317: -- Yes, that is what I thought the convention wa

[jira] [Commented] (KAFKA-1317) KafkaServer 0.8.1 not responding to .shutdown() cleanly, possibly related to TopicDeletionManager or MetricsMeter state

[ https://issues.apache.org/jira/browse/KAFKA-1317?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13942287#comment-13942287 ] Brent Bradbury commented on KAFKA-1317: --- Simplest way is to create a KafkaServer obj

[jira] [Updated] (KAFKA-1317) KafkaServer 0.8.1 not responding to .shutdown() cleanly, possibly related to TopicDeletionManager or MetricsMeter state

[ https://issues.apache.org/jira/browse/KAFKA-1317?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Neha Narkhede updated KAFKA-1317: - Assignee: Timothy Chen > KafkaServer 0.8.1 not responding to .shutdown() cleanly, possibly relate

[jira] [Commented] (KAFKA-1317) KafkaServer 0.8.1 not responding to .shutdown() cleanly, possibly related to TopicDeletionManager or MetricsMeter state

[ https://issues.apache.org/jira/browse/KAFKA-1317?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13942270#comment-13942270 ] Neha Narkhede commented on KAFKA-1317: -- This is a bug, a lot of our threads for some

[jira] [Updated] (KAFKA-1317) KafkaServer 0.8.1 not responding to .shutdown() cleanly, possibly related to TopicDeletionManager or MetricsMeter state

[ https://issues.apache.org/jira/browse/KAFKA-1317?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Neha Narkhede updated KAFKA-1317: - Labels: newbie (was: ) > KafkaServer 0.8.1 not responding to .shutdown() cleanly, possibly relat

Re: Review Request 19490: Patch for KAFKA-1315

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19490/ --- (Updated March 20, 2014, 9:03 p.m.) Review request for kafka. Bugs: KAFKA-131

[jira] [Commented] (KAFKA-1315) log.dirs property in KafkaServer intolerant of trailing slash

[ https://issues.apache.org/jira/browse/KAFKA-1315?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13942273#comment-13942273 ] Timothy Chen commented on KAFKA-1315: - Updated reviewboard https://reviews.apache.org/

[jira] [Updated] (KAFKA-1315) log.dirs property in KafkaServer intolerant of trailing slash

[ https://issues.apache.org/jira/browse/KAFKA-1315?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Timothy Chen updated KAFKA-1315: Attachment: KAFKA-1315_2014-03-20_14:03:34.patch > log.dirs property in KafkaServer intolerant of t

Re: Review Request 19490: Patch for KAFKA-1315

> On March 20, 2014, 8:41 p.m., Guozhang Wang wrote: > > core/src/main/scala/kafka/cluster/Partition.scala, line 93 > > > > > > Don't you still need to change this place? Don't need to change this as getAbsolutePath ma

[jira] [Commented] (KAFKA-1317) KafkaServer 0.8.1 not responding to .shutdown() cleanly, possibly related to TopicDeletionManager or MetricsMeter state

[ https://issues.apache.org/jira/browse/KAFKA-1317?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13942263#comment-13942263 ] Brent Bradbury commented on KAFKA-1317: --- I should add- I call awaitShutdown() as wel

[jira] [Comment Edited] (KAFKA-1317) KafkaServer 0.8.1 not responding to .shutdown() cleanly, possibly related to TopicDeletionManager or MetricsMeter state

[ https://issues.apache.org/jira/browse/KAFKA-1317?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13942247#comment-13942247 ] Brent Bradbury edited comment on KAFKA-1317 at 3/20/14 8:43 PM:

[jira] [Commented] (KAFKA-1317) KafkaServer 0.8.1 not responding to .shutdown() cleanly, possibly related to TopicDeletionManager or MetricsMeter state

[ https://issues.apache.org/jira/browse/KAFKA-1317?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13942247#comment-13942247 ] Brent Bradbury commented on KAFKA-1317: --- Ah, sorry not to make that clear Neha. I be

Re: Review Request 19490: Patch for KAFKA-1315

> On March 20, 2014, 8:41 p.m., Guozhang Wang wrote: > > Actually, I think all we need is FileSystem.getFileSystem().normalize(pathname). - Guozhang --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.

Re: Review Request 19490: Patch for KAFKA-1315

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19490/#review37967 --- core/src/main/scala/kafka/cluster/Partition.scala

[jira] [Updated] (KAFKA-1315) log.dirs property in KafkaServer intolerant of trailing slash

[ https://issues.apache.org/jira/browse/KAFKA-1315?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Neha Narkhede updated KAFKA-1315: - Assignee: Timothy Chen > log.dirs property in KafkaServer intolerant of trailing slash >

[jira] [Comment Edited] (KAFKA-1317) KafkaServer 0.8.1 not responding to .shutdown() cleanly, possibly related to TopicDeletionManager or MetricsMeter state

[ https://issues.apache.org/jira/browse/KAFKA-1317?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13942233#comment-13942233 ] Neha Narkhede edited comment on KAFKA-1317 at 3/20/14 8:37 PM: -

Re: Review Request 19490: Patch for KAFKA-1315

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19490/#review37964 --- Almost ready for checkin. 2 minor comments after which we can check

[jira] [Commented] (KAFKA-1315) log.dirs property in KafkaServer intolerant of trailing slash

[ https://issues.apache.org/jira/browse/KAFKA-1315?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13942236#comment-13942236 ] Timothy Chen commented on KAFKA-1315: - Updated reviewboard https://reviews.apache.org/

[jira] [Updated] (KAFKA-1315) log.dirs property in KafkaServer intolerant of trailing slash

[ https://issues.apache.org/jira/browse/KAFKA-1315?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Timothy Chen updated KAFKA-1315: Attachment: KAFKA-1315_2014-03-20_13:28:06.patch > log.dirs property in KafkaServer intolerant of t

[jira] [Updated] (KAFKA-1317) KafkaServer 0.8.1 not responding to .shutdown() cleanly, possibly related to TopicDeletionManager or MetricsMeter state

[ https://issues.apache.org/jira/browse/KAFKA-1317?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Neha Narkhede updated KAFKA-1317: - Fix Version/s: 0.8.1.1 > KafkaServer 0.8.1 not responding to .shutdown() cleanly, possibly relate

[jira] [Commented] (KAFKA-1317) KafkaServer 0.8.1 not responding to .shutdown() cleanly, possibly related to TopicDeletionManager or MetricsMeter state

[ https://issues.apache.org/jira/browse/KAFKA-1317?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13942233#comment-13942233 ] Neha Narkhede commented on KAFKA-1317: -- Thanks for filing the bug. I wonder why I don

[jira] [Updated] (KAFKA-1317) KafkaServer 0.8.1 not responding to .shutdown() cleanly, possibly related to TopicDeletionManager or MetricsMeter state

[ https://issues.apache.org/jira/browse/KAFKA-1317?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Neha Narkhede updated KAFKA-1317: - Priority: Blocker (was: Major) > KafkaServer 0.8.1 not responding to .shutdown() cleanly, possib

Re: Review Request 19490: Patch for KAFKA-1315

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19490/ --- (Updated March 20, 2014, 8:28 p.m.) Review request for kafka. Bugs: KAFKA-131

Re: Review Request 19490: Patch for KAFKA-1315

> On March 20, 2014, 8:20 p.m., Neha Narkhede wrote: > > core/src/main/scala/kafka/cluster/Partition.scala, line 93 > > > > > > This creates new File objects on every single getOrCreateReplica. > > During leader change

Re: Review Request 17263: New producer for Kafka.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17263/#review37833 --- One general comment: can we refactor the structure of metrics/senso

Re: Review Request 19490: Patch for KAFKA-1315

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19490/#review37961 --- Thanks for the quick patch, Tim! core/src/main/scala/kafka/cluster

[jira] [Updated] (KAFKA-1315) log.dirs property in KafkaServer intolerant of trailing slash

[ https://issues.apache.org/jira/browse/KAFKA-1315?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Neha Narkhede updated KAFKA-1315: - Labels: newbie (was: ) > log.dirs property in KafkaServer intolerant of trailing slash > ---

[jira] [Updated] (KAFKA-1315) log.dirs property in KafkaServer intolerant of trailing slash

[ https://issues.apache.org/jira/browse/KAFKA-1315?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Neha Narkhede updated KAFKA-1315: - Fix Version/s: 0.8.1.1 > log.dirs property in KafkaServer intolerant of trailing slash >

[jira] [Updated] (KAFKA-1315) log.dirs property in KafkaServer intolerant of trailing slash

[ https://issues.apache.org/jira/browse/KAFKA-1315?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Neha Narkhede updated KAFKA-1315: - Priority: Blocker (was: Major) > log.dirs property in KafkaServer intolerant of trailing slash >

[jira] [Updated] (KAFKA-1315) log.dirs property in KafkaServer intolerant of trailing slash

[ https://issues.apache.org/jira/browse/KAFKA-1315?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Timothy Chen updated KAFKA-1315: Attachment: KAFKA-1315.patch > log.dirs property in KafkaServer intolerant of trailing slash >

[jira] [Commented] (KAFKA-1315) log.dirs property in KafkaServer intolerant of trailing slash

[ https://issues.apache.org/jira/browse/KAFKA-1315?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13942196#comment-13942196 ] Timothy Chen commented on KAFKA-1315: - Created reviewboard https://reviews.apache.org/

[jira] [Commented] (KAFKA-1317) KafkaServer 0.8.1 not responding to .shutdown() cleanly, possibly related to TopicDeletionManager or MetricsMeter state

[ https://issues.apache.org/jira/browse/KAFKA-1317?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13942194#comment-13942194 ] Brent Bradbury commented on KAFKA-1317: --- Maybe related to KAFKA-1298 ? > KafkaServe

Review Request 19490: Patch for KAFKA-1315

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19490/ --- Review request for kafka. Bugs: KAFKA-1315 https://issues.apache.org/jira/b

[jira] [Updated] (KAFKA-1317) KafkaServer 0.8.1 not responding to .shutdown() cleanly, possibly related to TopicDeletionManager or MetricsMeter state

[ https://issues.apache.org/jira/browse/KAFKA-1317?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Brent Bradbury updated KAFKA-1317: -- Attachment: threaddump.txt Thread dump of hung process > KafkaServer 0.8.1 not responding to .

[jira] [Created] (KAFKA-1317) KafkaServer 0.8.1 not responding to .shutdown() cleanly, possibly related to TopicDeletionManager or MetricsMeter state

Brent Bradbury created KAFKA-1317: - Summary: KafkaServer 0.8.1 not responding to .shutdown() cleanly, possibly related to TopicDeletionManager or MetricsMeter state Key: KAFKA-1317 URL: https://issues.apache.org/j

[jira] Subscription: outstanding kafka patches

Issue Subscription Filter: outstanding kafka patches (86 issues) The list of outstanding kafka patches Subscriber: kafka-mailing-list Key Summary KAFKA-1300 Added WaitForReplaction admin tool. https://issues.apache.org/jira/browse/KAFKA-1300 KAFKA-1264 Make ConsoleProducer co

Re: Review Request 19388: Patch for KAFKA-1251

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19388/#review37926 --- clients/src/main/java/org/apache/kafka/clients/producer/internals/R

[jira] [Updated] (KAFKA-1312) Update gitignore to ignore IDE generated files

[ https://issues.apache.org/jira/browse/KAFKA-1312?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Timothy Chen updated KAFKA-1312: Attachment: KAFKA-1312_2014-03-20_11:00:17.patch > Update gitignore to ignore IDE generated files >

[jira] [Closed] (KAFKA-1312) Update gitignore to ignore IDE generated files

[ https://issues.apache.org/jira/browse/KAFKA-1312?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Timothy Chen closed KAFKA-1312. --- > Update gitignore to ignore IDE generated files > -- > >

  1   2   >