[GitHub] kafka pull request: Update LogManager.scala

2014-03-10 Thread glorage
GitHub user glorage opened a pull request: https://github.com/apache/kafka/pull/19 Update LogManager.scala Make sure newer segments would not be deleted You can merge this pull request into a Git repository by running: $ git pull https://github.com/glorage/kafka 0.8.1 Alternat

Re: [VOTE SUCCESS] Apache Kafka Release 0.8.1 - Candidate 2

2014-03-10 Thread Jun Rao
Joe, Thanks for driving the release. Jun On Mon, Mar 10, 2014 at 2:37 PM, Joe Stein wrote: > With 4 x +1 binding, 2 x +1 non-binding, 0 x 0 and 0 x -1 The Apache Kafka > Release 0.8.1 - Candidate 2 vote passes. > > I will push the artifacts to maven central now. Once that shows up > (hopeful

Re: Review Request 18299: Fix KAFKA-1253

2014-03-10 Thread Jay Kreps
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18299/#review36732 --- clients/src/main/java/org/apache/kafka/clients/producer/internals/R

[jira] [Commented] (KAFKA-1253) Implement compression in new producer

2014-03-10 Thread Guozhang Wang (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1253?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13926348#comment-13926348 ] Guozhang Wang commented on KAFKA-1253: -- Updated reviewboard https://reviews.apache.or

[jira] [Updated] (KAFKA-1253) Implement compression in new producer

2014-03-10 Thread Guozhang Wang (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1253?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Guozhang Wang updated KAFKA-1253: - Attachment: KAFKA-1253_2014-03-10_15:27:47.patch > Implement compression in new producer > --

Re: Review Request 18299: Fix KAFKA-1253

2014-03-10 Thread Guozhang Wang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18299/ --- (Updated March 10, 2014, 10:28 p.m.) Review request for kafka. Bugs: KAFKA-12

Re: Review Request 18299: Fix KAFKA-1253

2014-03-10 Thread Guozhang Wang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18299/ --- (Updated March 10, 2014, 10:28 p.m.) Review request for kafka. Bugs: KAFKA-12

[jira] [Comment Edited] (KAFKA-1253) Implement compression in new producer

2014-03-10 Thread Guozhang Wang (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1253?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13926296#comment-13926296 ] Guozhang Wang edited comment on KAFKA-1253 at 3/10/14 10:01 PM:

[jira] [Commented] (KAFKA-1253) Implement compression in new producer

2014-03-10 Thread Guozhang Wang (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1253?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13926296#comment-13926296 ] Guozhang Wang commented on KAFKA-1253: -- Some interesting performance numbers (1000 me

Re: Review Request 18299: Fix KAFKA-1253

2014-03-10 Thread Guozhang Wang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18299/ --- (Updated March 10, 2014, 9:40 p.m.) Review request for kafka. Bugs: KAFKA-125

[jira] [Commented] (KAFKA-1253) Implement compression in new producer

2014-03-10 Thread Guozhang Wang (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1253?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13926267#comment-13926267 ] Guozhang Wang commented on KAFKA-1253: -- Updated reviewboard https://reviews.apache.or

[jira] [Updated] (KAFKA-1253) Implement compression in new producer

2014-03-10 Thread Guozhang Wang (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1253?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Guozhang Wang updated KAFKA-1253: - Attachment: KAFKA-1253_2014-03-10_14:39:58.patch > Implement compression in new producer > --

Re: Review Request 18299: Fix KAFKA-1253

2014-03-10 Thread Guozhang Wang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18299/ --- (Updated March 10, 2014, 9:40 p.m.) Review request for kafka. Bugs: KAFKA-125

[VOTE SUCCESS] Apache Kafka Release 0.8.1 - Candidate 2

2014-03-10 Thread Joe Stein
With 4 x +1 binding, 2 x +1 non-binding, 0 x 0 and 0 x -1 The Apache Kafka Release 0.8.1 - Candidate 2 vote passes. I will push the artifacts to maven central now. Once that shows up (hopefully later this evening/tomorrow) I will push the new artifacts to repo and update the download page. We co

Re: Review Request 18299: Fix KAFKA-1253

2014-03-10 Thread Guozhang Wang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18299/ --- (Updated March 10, 2014, 9:37 p.m.) Review request for kafka. Bugs: KAFKA-125

[jira] [Commented] (KAFKA-1253) Implement compression in new producer

2014-03-10 Thread Guozhang Wang (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1253?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13926257#comment-13926257 ] Guozhang Wang commented on KAFKA-1253: -- Updated reviewboard https://reviews.apache.or

[jira] [Updated] (KAFKA-1253) Implement compression in new producer

2014-03-10 Thread Guozhang Wang (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1253?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Guozhang Wang updated KAFKA-1253: - Attachment: KAFKA-1253_2014-03-10_14:35:56.patch > Implement compression in new producer > --

Re: Review Request 18299: Fix KAFKA-1253

2014-03-10 Thread Guozhang Wang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18299/ --- (Updated March 10, 2014, 9:36 p.m.) Review request for kafka. Bugs: KAFKA-125

Re: Review Request 18299: Fix KAFKA-1253

2014-03-10 Thread Guozhang Wang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18299/ --- (Updated March 10, 2014, 9:36 p.m.) Review request for kafka. Bugs: KAFKA-125

Re: Review Request 18299: Fix KAFKA-1253

2014-03-10 Thread Guozhang Wang
> On March 10, 2014, 5:23 p.m., Jun Rao wrote: > > clients/src/main/java/org/apache/kafka/common/record/Compressor.java, lines > > 100-101 > > > > > > Would it be better to write the code as: > > > > catch (

[jira] Subscription: outstanding kafka patches

2014-03-10 Thread jira
Issue Subscription Filter: outstanding kafka patches (84 issues) The list of outstanding kafka patches Subscriber: kafka-mailing-list Key Summary KAFKA-1300 Added WaitForReplaction admin tool. https://issues.apache.org/jira/browse/KAFKA-1300 KAFKA-1264 Make ConsoleProducer co

Re: [VOTE] Apache Kafka Release 0.8.1 - Candidate 2

2014-03-10 Thread Joe Stein
The 2.8.0-.8.1.tgz.md5 (zero missing) is from a bad sign operation (and will not get copied to publish). There is a 2.8.0-.0.8.1.tgz.md5 that goes with the tgz so that is what should be used. On Mon, Mar 10, 2014 at 2:12 PM, Joel Koshy wrote: > +1 > > There is the zero-length md5 for 2.8.0-.8.

Re: [VOTE] Apache Kafka Release 0.8.1 - Candidate 2

2014-03-10 Thread Sriram Subramanian
+1 Verified unit test and quick start. On 3/10/14 11:12 AM, "Joel Koshy" wrote: >+1 > >There is the zero-length md5 for 2.8.0-.8.1.tgz.md5 (zero missing). >Not sure if that is a blocker though since most people are off 2.8.0 > >Joel > >On Mon, Mar 10, 2014 at 10:51:35AM -0700, Neha Narkhede wro

Re: [VOTE] Apache Kafka Release 0.8.1 - Candidate 2

2014-03-10 Thread Joel Koshy
+1 There is the zero-length md5 for 2.8.0-.8.1.tgz.md5 (zero missing). Not sure if that is a blocker though since most people are off 2.8.0 Joel On Mon, Mar 10, 2014 at 10:51:35AM -0700, Neha Narkhede wrote: > +1, verified unit tests and quickstart. > > Thanks > Neha > > > On Mon, Mar 10, 201

Re: [VOTE] Apache Kafka Release 0.8.1 - Candidate 2

2014-03-10 Thread Neha Narkhede
+1, verified unit tests and quickstart. Thanks Neha On Mon, Mar 10, 2014 at 10:47 AM, Jay Kreps wrote: > +1 > > There are a few rough edges: slf4j error and the spurious error from the > console consumer but I'm okay if we fix these in 0.8.2. > > -Jay > > > On Tue, Mar 4, 2014 at 10:59 PM, Joe

Re: [VOTE] Apache Kafka Release 0.8.1 - Candidate 2

2014-03-10 Thread Jay Kreps
+1 There are a few rough edges: slf4j error and the spurious error from the console consumer but I'm okay if we fix these in 0.8.2. -Jay On Tue, Mar 4, 2014 at 10:59 PM, Joe Stein wrote: > This is the second candidate for release of Apache Kafka 0.8.1. > > This release candidate fixes the fol

[jira] [Updated] (KAFKA-1301) system testcase_0206 fails using the new producer

2014-03-10 Thread Jun Rao (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1301?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jun Rao updated KAFKA-1301: --- Description: The problem is that the producer doesn't drain the unsent data properly on close. The problem i

[jira] [Created] (KAFKA-1301) system testcase_0206 fails using the new producer

2014-03-10 Thread Jun Rao (JIRA)
Jun Rao created KAFKA-1301: -- Summary: system testcase_0206 fails using the new producer Key: KAFKA-1301 URL: https://issues.apache.org/jira/browse/KAFKA-1301 Project: Kafka Issue Type: Bug Affec

Re: Review Request 18299: Fix KAFKA-1253

2014-03-10 Thread Jun Rao
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18299/#review36658 --- Could we add the new compression property to existing tools like co

Re: command line tools

2014-03-10 Thread Martin Kleppmann
+1 for using exit status in the command-line tools. The other day I wanted to modify a shell script to create a Kafka topic, using bin/kafka-topics.sh --create --topic ... The tool's behaviour is not very conducive to automation: - If the topic creation was successful, it prints out a message a

Re: command line tools

2014-03-10 Thread Michael G. Noll
Oh, and one more comment: I haven't checked all the CLI tools of Kafka in that regard, but preferably each tool would properly return zero exit codes on success and non-zero on failure (and possibly distinct error exit codes). That would simplify integration with tools like Puppet, Chef, Ansibl