[jira] [Created] (KAFKA-1283) Log4jAppender is unable to send the message.

2014-02-26 Thread Dongkyoung Kim (JIRA)
Dongkyoung Kim created KAFKA-1283: - Summary: Log4jAppender is unable to send the message. Key: KAFKA-1283 URL: https://issues.apache.org/jira/browse/KAFKA-1283 Project: Kafka Issue Type: Bug

[jira] [Commented] (KAFKA-1260) Integration Test for New Producer Part II: Broker Failure Handling

2014-02-26 Thread Jay Kreps (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1260?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13914025#comment-13914025 ] Jay Kreps commented on KAFKA-1260: -- I don't see the actual ProducerFailureHandlingTest in

Re: Review Request 18102: Integration Test for New Producer: Part II

2014-02-26 Thread Jay Kreps
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18102/#review35593 --- Ship it! Ship It! - Jay Kreps On Feb. 26, 2014, 9:51 p.m., Guozh

[jira] [Commented] (KAFKA-266) Kafka web console

2014-02-26 Thread Jay Kreps (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-266?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13913975#comment-13913975 ] Jay Kreps commented on KAFKA-266: - That is correct. If JMX would be a workable approach, ad

[jira] [Updated] (KAFKA-1250) Add slf4j logging to new producer

2014-02-26 Thread Jay Kreps (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1250?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jay Kreps updated KAFKA-1250: - Attachment: kafka_trace.txt kafka_debug.txt Okay guys, I have capitulated on the config l

[jira] [Updated] (KAFKA-1250) Add slf4j logging to new producer

2014-02-26 Thread Jay Kreps (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1250?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jay Kreps updated KAFKA-1250: - Attachment: KAFKA-1250_2014-02-26_18:32:24.patch > Add slf4j logging to new producer > --

[jira] [Commented] (KAFKA-1250) Add slf4j logging to new producer

2014-02-26 Thread Jay Kreps (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1250?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13913957#comment-13913957 ] Jay Kreps commented on KAFKA-1250: -- Updated reviewboard https://reviews.apache.org/r/1834

Re: Review Request 18343: Patch for KAFKA-1250

2014-02-26 Thread Jay Kreps
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18343/ --- (Updated Feb. 27, 2014, 2:32 a.m.) Review request for kafka. Bugs: KAFKA-1250

Re: Review Request 18299: Proposed In-place Compression on MemoryRecords

2014-02-26 Thread Guozhang Wang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18299/ --- (Updated Feb. 27, 2014, 1:33 a.m.) Review request for kafka. Bugs: KAFKA-1253

[jira] [Updated] (KAFKA-1253) Implement compression in new producer

2014-02-26 Thread Guozhang Wang (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1253?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Guozhang Wang updated KAFKA-1253: - Attachment: KAFKA-1253_2014-02-26_17:31:30.patch > Implement compression in new producer > --

[jira] [Commented] (KAFKA-1253) Implement compression in new producer

2014-02-26 Thread Guozhang Wang (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1253?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13913881#comment-13913881 ] Guozhang Wang commented on KAFKA-1253: -- Updated reviewboard https://reviews.apache.or

Re: Review Request 18299: Proposed In-place Compression on MemoryRecords

2014-02-26 Thread Guozhang Wang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18299/ --- (Updated Feb. 27, 2014, 1:31 a.m.) Review request for kafka. Bugs: KAFKA-1253

[jira] [Commented] (KAFKA-266) Kafka web console

2014-02-26 Thread Claude Mamo (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-266?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13913800#comment-13913800 ] Claude Mamo commented on KAFKA-266: --- Definitely [~jkreps], docs are in my TODO list befor

Re: Review Request 18343: Patch for KAFKA-1250

2014-02-26 Thread Jay Kreps
> On Feb. 26, 2014, 10:49 a.m., Neha Narkhede wrote: > > clients/src/main/java/org/apache/kafka/clients/producer/internals/Sender.java, > > line 386 > > > > > > In order to meaningfully trace a request in the producer

Re: Review Request 18102: Integration Test for New Producer: Part II

2014-02-26 Thread Guozhang Wang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18102/ --- (Updated Feb. 26, 2014, 9:51 p.m.) Review request for kafka. Bugs: KAFKA-1260

Re: Review Request 18102: Integration Test for New Producer: Part II

2014-02-26 Thread Guozhang Wang
> On Feb. 26, 2014, 7:56 p.m., Jun Rao wrote: > > core/src/test/scala/integration/kafka/api/ProducerSendTest.scala, lines > > 161-162 > > > > > > Shouldn't we add the code to call send after producer.close()? The sec

[jira] [Updated] (KAFKA-1260) Integration Test for New Producer Part II: Broker Failure Handling

2014-02-26 Thread Guozhang Wang (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1260?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Guozhang Wang updated KAFKA-1260: - Attachment: KAFKA-1260_2014-02-26_13:49:24.patch > Integration Test for New Producer Part II: Bro

[jira] [Commented] (KAFKA-1260) Integration Test for New Producer Part II: Broker Failure Handling

2014-02-26 Thread Guozhang Wang (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1260?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13913561#comment-13913561 ] Guozhang Wang commented on KAFKA-1260: -- Updated reviewboard https://reviews.apache.or

Re: Review Request 18102: Integration Test for New Producer: Part II

2014-02-26 Thread Guozhang Wang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18102/ --- (Updated Feb. 26, 2014, 9:49 p.m.) Review request for kafka. Bugs: KAFKA-1260

Re: Review Request 18102: Integration Test for New Producer: Part II

2014-02-26 Thread Jun Rao
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18102/#review35559 --- Ship it! +1 Just the following minor comments. core/src/main/scal

Re: Review Request 18299: Proposed In-place Compression on MemoryRecords

2014-02-26 Thread Guozhang Wang
> On Feb. 25, 2014, 6:22 p.m., Jun Rao wrote: > > Could we extend ProducerSendTest to test sending/reading compressed > > messages? Yep > On Feb. 25, 2014, 6:22 p.m., Jun Rao wrote: > > clients/src/main/java/org/apache/kafka/common/record/CompressedMemoryRecords.java, > > lines 72-73 > >

[jira] [Commented] (KAFKA-1281) add the new producer to existing tools

2014-02-26 Thread Jay Kreps (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1281?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13913223#comment-13913223 ] Jay Kreps commented on KAFKA-1281: -- Well, but I suppose when using these tools you just w

Re: Review Request 18102: Integration Test for New Producer: Part II

2014-02-26 Thread Guozhang Wang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18102/ --- (Updated Feb. 26, 2014, 5:48 p.m.) Review request for kafka. Bugs: KAFKA-1260

[jira] [Updated] (KAFKA-1260) Integration Test for New Producer Part II: Broker Failure Handling

2014-02-26 Thread Guozhang Wang (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1260?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Guozhang Wang updated KAFKA-1260: - Attachment: KAFKA-1260_2014-02-26_09:47:08.patch > Integration Test for New Producer Part II: Bro

Re: Review Request 18102: Integration Test for New Producer: Part II

2014-02-26 Thread Guozhang Wang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18102/ --- (Updated Feb. 26, 2014, 5:47 p.m.) Review request for kafka. Bugs: KAFKA-1260

[jira] [Commented] (KAFKA-1260) Integration Test for New Producer Part II: Broker Failure Handling

2014-02-26 Thread Guozhang Wang (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1260?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13913222#comment-13913222 ] Guozhang Wang commented on KAFKA-1260: -- Updated reviewboard https://reviews.apache.or

Re: Review Request 18102: Integration Test for New Producer: Part II

2014-02-26 Thread Guozhang Wang
> On Feb. 26, 2014, 2:47 a.m., Jun Rao wrote: > > clients/src/main/java/org/apache/kafka/clients/producer/KafkaProducer.java, > > lines 230-231 > > > > > > Not sure we need to wrap InterruptedException. We need, sinc

[GitHub] kafka pull request: Fix to run hadoop-consumer with hadoop 2

2014-02-26 Thread mvalleavila
GitHub user mvalleavila opened a pull request: https://github.com/apache/kafka/pull/18 Fix to run hadoop-consumer with hadoop 2 You can merge this pull request into a Git repository by running: $ git pull https://github.com/mvalleavila/kafka 0.8 Alternatively you can review a

Re: About removal of RAT from kafka build.

2014-02-26 Thread Joe Stein
Hi Prashant , rat is still run as part of the release process https://cwiki.apache.org/confluence/display/KAFKA/Release+Process (this document is going to change in the next day or so for the 0.8.1 release now that we moved to Gradle and away from SBT, fyi) Gradle also has a license mechanism t

Re: Review Request 18343: Patch for KAFKA-1250

2014-02-26 Thread Jun Rao
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18343/#review35532 --- 1. Is there a reason that you want to change the license header? We

[jira] [Commented] (KAFKA-1281) add the new producer to existing tools

2014-02-26 Thread Neha Narkhede (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1281?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13912776#comment-13912776 ] Neha Narkhede commented on KAFKA-1281: -- But wouldn't we need this while we are on 0.8

Re: Review Request 18343: Patch for KAFKA-1250

2014-02-26 Thread Neha Narkhede
> On Feb. 25, 2014, 7:14 p.m., Neha Narkhede wrote: > > clients/src/main/java/org/apache/kafka/clients/producer/KafkaProducer.java, > > line 227 > > > > > > My understanding is that any per message log message be at t

Re: Review Request 18343: Patch for KAFKA-1250

2014-02-26 Thread Neha Narkhede
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18343/#review35520 --- Thanks for the updated patch, Jay! clients/src/main/java/org/apach

About removal of RAT from kafka build.

2014-02-26 Thread Prashant Sharma
Hi all, I am one of the contributors to Apache Spark and was looking into RAT for catching licensing errors in the codebase. From the git log it is clear KAFKA once had Apache RAT in the build and was later removed. It is not clear what was the alternative taken. This information would be helpful,