Re: Review Request 18441: Patch for KAFKA-1279

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18441/#review35375 --- core/src/main/scala/kafka/network/SocketServer.scala

Re: Metrics in new producer

Clark, As Martin pointed out, if a stat is stable, the numbers that you get from the new metrics are going to be close to what you get from Coda metrics. If a stat is not stable, what the new metrics gives you is probably more intuitive. Given that, would you still want the Coda metrics through a

Re: Review Request 18102: New Producer Integration Test Phase II

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18102/#review35370 --- clients/src/main/java/org/apache/kafka/clients/producer/KafkaProduc

[jira] [Commented] (KAFKA-266) Kafka web console

[ https://issues.apache.org/jira/browse/KAFKA-266?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13911204#comment-13911204 ] Jay Kreps commented on KAFKA-266: - [~claude.mamo] Very cool. I added it to the Ecosystem pa

[jira] [Resolved] (KAFKA-1279) SocketServer.shutdown() doesn't close open connections

[ https://issues.apache.org/jira/browse/KAFKA-1279?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jay Kreps resolved KAFKA-1279. -- Resolution: Fixed > SocketServer.shutdown() doesn't close open connections > --

[jira] [Updated] (KAFKA-1278) More flexible helper scripts

[ https://issues.apache.org/jira/browse/KAFKA-1278?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nathan Brown updated KAFKA-1278: Attachment: trunk.patch > More flexible helper scripts > > >

[jira] [Commented] (KAFKA-1278) More flexible helper scripts

[ https://issues.apache.org/jira/browse/KAFKA-1278?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13911025#comment-13911025 ] Nathan Brown commented on KAFKA-1278: - Just uploaded a patch based on trunk. Let me kn

Re: Review Request 18441: Patch for KAFKA-1279

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18441/#review35330 --- Ship it! Ship It! - Guozhang Wang On Feb. 24, 2014, 10:47 p.m.,

Re: Review Request 18441: Patch for KAFKA-1279

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18441/#review35324 --- Ship it! Ship It! - Sriram Subramanian On Feb. 24, 2014, 10:47 p

[jira] [Updated] (KAFKA-1279) SocketServer.shutdown() doesn't close open connections

[ https://issues.apache.org/jira/browse/KAFKA-1279?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jay Kreps updated KAFKA-1279: - Attachment: KAFKA-1279.patch > SocketServer.shutdown() doesn't close open connections > -

[jira] [Commented] (KAFKA-1279) SocketServer.shutdown() doesn't close open connections

[ https://issues.apache.org/jira/browse/KAFKA-1279?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13910928#comment-13910928 ] Jay Kreps commented on KAFKA-1279: -- Created reviewboard https://reviews.apache.org/r/1844

Review Request 18441: Patch for KAFKA-1279

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18441/ --- Review request for kafka. Bugs: KAFKA-1279 https://issues.apache.org/jira/b

Re: Review Request 18299: Proposed In-place Compression on MemoryRecords

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18299/ --- (Updated Feb. 24, 2014, 9:34 p.m.) Review request for kafka. Bugs: KAFKA-1253

[jira] [Updated] (KAFKA-1253) Implement compression in new producer

[ https://issues.apache.org/jira/browse/KAFKA-1253?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Guozhang Wang updated KAFKA-1253: - Attachment: KAFKA-1253_2014-02-24_13:31:50.patch > Implement compression in new producer > --

[jira] [Commented] (KAFKA-1253) Implement compression in new producer

[ https://issues.apache.org/jira/browse/KAFKA-1253?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13910844#comment-13910844 ] Guozhang Wang commented on KAFKA-1253: -- Updated reviewboard https://reviews.apache.or

Re: Review Request 18299: Proposed In-place Compression on MemoryRecords

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18299/ --- (Updated Feb. 24, 2014, 9:31 p.m.) Review request for kafka. Bugs: KAFKA-1253

[jira] [Commented] (KAFKA-266) Kafka web console

[ https://issues.apache.org/jira/browse/KAFKA-266?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13910843#comment-13910843 ] Claude Mamo commented on KAFKA-266: --- Adding another one to the list: https://github.com/

[jira] [Created] (KAFKA-1279) SocketServer.shutdown() doesn't close open connections

Jay Kreps created KAFKA-1279: Summary: SocketServer.shutdown() doesn't close open connections Key: KAFKA-1279 URL: https://issues.apache.org/jira/browse/KAFKA-1279 Project: Kafka Issue Type: Bug

Re: Review Request 18299: Proposed In-place Compression on MemoryRecords

> On Feb. 23, 2014, 10:38 p.m., Jun Rao wrote: > > clients/src/main/java/org/apache/kafka/common/record/CompressedMemoryRecords.java, > > lines 101-112 > > > > > > This is actually not the right place to add the offse

[jira] Subscription: outstanding kafka patches

Issue Subscription Filter: outstanding kafka patches (88 issues) The list of outstanding kafka patches Subscriber: kafka-mailing-list Key Summary KAFKA-1278 More flexible helper scripts https://issues.apache.org/jira/browse/KAFKA-1278 KAFKA-1276 Provide a list of config overr

[jira] [Commented] (KAFKA-1278) More flexible helper scripts

[ https://issues.apache.org/jira/browse/KAFKA-1278?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13910601#comment-13910601 ] Jun Rao commented on KAFKA-1278: Thanks for the patch. Looks good. It doesn't apply to tru

[jira] [Commented] (KAFKA-1210) Windows Bat files are not working properly

[ https://issues.apache.org/jira/browse/KAFKA-1210?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13910606#comment-13910606 ] Jun Rao commented on KAFKA-1210: Thanks for the patch. We have moved to gradle now. Could

[jira] [Updated] (KAFKA-1273) Brokers should make sure replica.fetch.max.bytes >= message.max.bytes

[ https://issues.apache.org/jira/browse/KAFKA-1273?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jun Rao updated KAFKA-1273: --- Labels: newbie (was: ) > Brokers should make sure replica.fetch.max.bytes >= message.max.bytes > ---

[jira] [Updated] (KAFKA-1269) Minor typos in documentation

[ https://issues.apache.org/jira/browse/KAFKA-1269?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jun Rao updated KAFKA-1269: --- Resolution: Fixed Assignee: Evan Zacks Status: Resolved (was: Patch Available) Thanks for the

Re: Metrics in new producer

Hey guys, I think this is the first item where we haven't had fairly obvious consensus. I will call a vote if there isn't more discussion worth doing. I think the alternatives I have understood: 1. JMX 2. Coda Hale 3. Custom package in there now with improvements (histograms, additional reporters

Re: Metrics in new producer

Hi Jay, 1. Agree with your assessment. Let me know when you start writing the metrics library to rule them all, I'm interested :-) 2. If I understood you correctly, you need to give an indication of what range of values you expect for a metric (e.g. a latency might be in log-scale of buckets b

[jira] [Commented] (KAFKA-1215) Rack-Aware replica assignment option

[ https://issues.apache.org/jira/browse/KAFKA-1215?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13910578#comment-13910578 ] Jun Rao commented on KAFKA-1215: Sorry for not getting to this earlier, commented on the R

Re: Review Request 17248: Patch for KAFKA-1215

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17248/#review35293 --- Sorry for the late review. The high level comment is that we need to

[jira] [Updated] (KAFKA-1269) Minor typos in documentation

[ https://issues.apache.org/jira/browse/KAFKA-1269?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Evan Zacks updated KAFKA-1269: -- Status: Patch Available (was: Open) > Minor typos in documentation > > >

[jira] [Updated] (KAFKA-1269) Minor typos in documentation

[ https://issues.apache.org/jira/browse/KAFKA-1269?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Evan Zacks updated KAFKA-1269: -- Attachment: KAFKA-1269-documentation-typos-2.patch > Minor typos in documentation > ---

[jira] [Updated] (KAFKA-1269) Minor typos in documentation

[ https://issues.apache.org/jira/browse/KAFKA-1269?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Evan Zacks updated KAFKA-1269: -- Attachment: (was: KAFKA-1269-documentation-typos.patch) > Minor typos in documentation > --

[jira] [Updated] (KAFKA-1269) Minor typos in documentation

[ https://issues.apache.org/jira/browse/KAFKA-1269?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Evan Zacks updated KAFKA-1269: -- Status: Open (was: Patch Available) Updating with additional fixes. > Minor typos in documentation >

[jira] [Commented] (KAFKA-1028) per topic configuration of preference for consistency over availability

[ https://issues.apache.org/jira/browse/KAFKA-1028?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13910490#comment-13910490 ] Andrew Olson commented on KAFKA-1028: - [~nehanarkhede], can you respond to my latest c

Re: Review Request 15711: Patch for KAFKA-930

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/15711/#review35281 --- Ship it! Just the following minor comment. core/src/main/scala/ka

[jira] [Updated] (KAFKA-930) Integrate preferred replica election logic into kafka

[ https://issues.apache.org/jira/browse/KAFKA-930?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sriram Subramanian updated KAFKA-930: - Attachment: KAFKA-930_2014-02-24_01:59:46.patch > Integrate preferred replica election log

[jira] [Commented] (KAFKA-930) Integrate preferred replica election logic into kafka

[ https://issues.apache.org/jira/browse/KAFKA-930?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13910155#comment-13910155 ] Sriram Subramanian commented on KAFKA-930: -- Updated reviewboard https://reviews.ap

Re: Review Request 15711: Patch for KAFKA-930

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/15711/ --- (Updated Feb. 24, 2014, 9:59 a.m.) Review request for kafka. Bugs: KAFKA-930