Re: Exception in logs

Filed kafka-1271. Will upload a patch there. Thanks, Jun On Tue, Feb 18, 2014 at 7:27 PM, Jay Kreps wrote: > Yes. It shouldn't result in an NPE, though, right? > > -Jay > > > On Tue, Feb 18, 2014 at 5:20 PM, Jun Rao wrote: > > > Do you see ZK session expiration in the log too? > > > > Thanks

Re: Exception in logs

Yes. It shouldn't result in an NPE, though, right? -Jay On Tue, Feb 18, 2014 at 5:20 PM, Jun Rao wrote: > Do you see ZK session expiration in the log too? > > Thanks, > > Jun > > > On Tue, Feb 18, 2014 at 5:12 PM, Jay Kreps wrote: > > > I see this exception in the logs a lot when doing load t

Review Request 18258: Patch for KAFKA-1271

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18258/ --- Review request for kafka. Bugs: KAFKA-1271 https://issues.apache.org/jira/b

Re: Review Request 18022: KAFKA-1012: In-built offset management in Kafka

> On Feb. 19, 2014, 1:25 a.m., Guozhang Wang wrote: > > Some general comments: > > > > 1. sbt: do we really want to delete this file in this patch? > > > > 2. offset retention minutes: > > > > I was not aware of the retention before. I think this is like the consumer > > heartbeat scheme: th

[jira] [Commented] (KAFKA-1252) Implement re-tries in new producer

[ https://issues.apache.org/jira/browse/KAFKA-1252?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13905054#comment-13905054 ] Jun Rao commented on KAFKA-1252: There is a compilation error after the checkin. /Users/j

[jira] [Resolved] (KAFKA-1272) controller logs exceptions during ZK session expiration

[ https://issues.apache.org/jira/browse/KAFKA-1272?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jun Rao resolved KAFKA-1272. Resolution: Duplicate > controller logs exceptions during ZK session expiration > -

[jira] [Created] (KAFKA-1272) controller logs exceptions during ZK session expiration

Jun Rao created KAFKA-1272: -- Summary: controller logs exceptions during ZK session expiration Key: KAFKA-1272 URL: https://issues.apache.org/jira/browse/KAFKA-1272 Project: Kafka Issue Type: Bug

[jira] [Created] (KAFKA-1271) controller logs exceptions during ZK session expiration

Jun Rao created KAFKA-1271: -- Summary: controller logs exceptions during ZK session expiration Key: KAFKA-1271 URL: https://issues.apache.org/jira/browse/KAFKA-1271 Project: Kafka Issue Type: Bug

Re: Review Request 18022: KAFKA-1012: In-built offset management in Kafka

> On Feb. 18, 2014, 3:48 a.m., Tejas Patil wrote: > > My views (which hardly matter !!) about the points in 'Questions/comments > > for discussion' section: > > > > - Change in partition assignment would need sync of offsets across brokers > > and subsequent bootstrap. Would be better to addre

[jira] [Created] (KAFKA-1270) controller logs exceptions during ZK session expiration

Jun Rao created KAFKA-1270: -- Summary: controller logs exceptions during ZK session expiration Key: KAFKA-1270 URL: https://issues.apache.org/jira/browse/KAFKA-1270 Project: Kafka Issue Type: Bug

Re: Review Request 18022: KAFKA-1012: In-built offset management in Kafka

> On Feb. 18, 2014, 3:31 a.m., Tejas Patil wrote: > > core/src/main/scala/kafka/server/OffsetManager.scala, line 338 > > > > > > This is used only for DEBUG. Waste of memory for higher logging levels. > > Why not allo

Re: Review Request 16923: Patch for KAFKA-1206

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/16923/#review34829 --- I'm no Kafka/Scala expert, but I'm interested in seeing Kafka on Mes

Re: Review Request 18022: KAFKA-1012: In-built offset management in Kafka

> On Feb. 17, 2014, 7:16 p.m., Jun Rao wrote: > > Thanks for the patch. Some comments. > > > > 1. KafkaApis: The way that we handle OffsetCommit request pollutes > > handleProducerRequest() and DelayedProduce. It would be great if we can > > isolate the logic better. I was thinking that we can

[jira] [Commented] (KAFKA-1252) Implement re-tries in new producer

[ https://issues.apache.org/jira/browse/KAFKA-1252?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13904967#comment-13904967 ] Guozhang Wang commented on KAFKA-1252: -- Sure, will do. > Implement re-tries in new p

Re: Review Request 18022: KAFKA-1012: In-built offset management in Kafka

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18022/#review34803 --- Some general comments: 1. sbt: do we really want to delete this fil

Re: Exception in logs

Do you see ZK session expiration in the log too? Thanks, Jun On Tue, Feb 18, 2014 at 5:12 PM, Jay Kreps wrote: > I see this exception in the logs a lot when doing load testing. I haven't > noticed any ill effect. Presumably related to the delete topic stuff? > > [2014-02-18 15:16:58,569] ERRO

[jira] [Commented] (KAFKA-1252) Implement re-tries in new producer

[ https://issues.apache.org/jira/browse/KAFKA-1252?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13904939#comment-13904939 ] Jay Kreps commented on KAFKA-1252: -- Cool, I posted an update that addresses your comments

[jira] [Updated] (KAFKA-1252) Implement re-tries in new producer

[ https://issues.apache.org/jira/browse/KAFKA-1252?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jay Kreps updated KAFKA-1252: - Attachment: KAFKA-1252_2014-02-18_17:14:38.patch > Implement re-tries in new producer > -

[jira] [Commented] (KAFKA-1252) Implement re-tries in new producer

[ https://issues.apache.org/jira/browse/KAFKA-1252?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13904936#comment-13904936 ] Jay Kreps commented on KAFKA-1252: -- Updated reviewboard https://reviews.apache.org/r/1819

Re: Review Request 18199: Patch for KAFKA-1252

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18199/ --- (Updated Feb. 19, 2014, 1:15 a.m.) Review request for kafka. Bugs: KAFKA-1252

Exception in logs

I see this exception in the logs a lot when doing load testing. I haven't noticed any ill effect. Presumably related to the delete topic stuff? [2014-02-18 15:16:58,569] ERROR Error handling event ZkEvent[Children of /admin/delete_topics changed sent to kafka.controller.PartitionStateMachine$Delet

[jira] [Commented] (KAFKA-1245) the jar files and pom are not being signed so nexus is failing to publish them

[ https://issues.apache.org/jira/browse/KAFKA-1245?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13904808#comment-13904808 ] Jun Rao commented on KAFKA-1245: Hi, Joe, I ran the following after your patch and got a

[jira] [Commented] (KAFKA-1245) the jar files and pom are not being signed so nexus is failing to publish them

[ https://issues.apache.org/jira/browse/KAFKA-1245?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13904805#comment-13904805 ] Jun Rao commented on KAFKA-1245: Hi, Joe, I ran the following after your patch and got a

Re: Review Request 18199: Patch for KAFKA-1252

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18199/#review34795 --- Ship it! Minor comments below clients/src/main/java/org/apache/ka

Re: Review Request 18022: KAFKA-1012: In-built offset management in Kafka

> On Feb. 17, 2014, 6:04 a.m., Tejas Patil wrote: > > core/src/main/scala/kafka/server/KafkaApis.scala, line 210 > > > > > > For small batch of offset message(s), compression would increase the > > message size. For a

[jira] [Updated] (KAFKA-1269) Minor typos in documentation

[ https://issues.apache.org/jira/browse/KAFKA-1269?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Evan Zacks updated KAFKA-1269: -- Labels: documentation (was: ) Status: Patch Available (was: Open) > Minor typos in documentation

[jira] [Updated] (KAFKA-1269) Minor typos in documentation

[ https://issues.apache.org/jira/browse/KAFKA-1269?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Evan Zacks updated KAFKA-1269: -- Attachment: KAFKA-1269-documentation-typos.patch Attached patch without git prefix (git diff --no-prefi

[jira] [Updated] (KAFKA-1269) Minor typos in documentation

[ https://issues.apache.org/jira/browse/KAFKA-1269?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Evan Zacks updated KAFKA-1269: -- Attachment: (was: KAFKA-1269-documentation-typos.patch) > Minor typos in documentation > --

[jira] [Updated] (KAFKA-1269) Minor typos in documentation

[ https://issues.apache.org/jira/browse/KAFKA-1269?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Evan Zacks updated KAFKA-1269: -- Attachment: KAFKA-1269-documentation-typos.patch Attached patch to 08/configuration.html and 08/introdu

[jira] [Created] (KAFKA-1269) Minor typos in documentation

Evan Zacks created KAFKA-1269: - Summary: Minor typos in documentation Key: KAFKA-1269 URL: https://issues.apache.org/jira/browse/KAFKA-1269 Project: Kafka Issue Type: Bug Components: we

Re: Review Request 18199: Patch for KAFKA-1252

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18199/#review34705 --- Ship it! +1. Just some minor comments below. clients/src/main/jav

Retries in new producer code

Looking for a review: https://issues.apache.org/jira/browse/KAFKA-1252 -Jay

[jira] [Commented] (KAFKA-266) Kafka web console

[ https://issues.apache.org/jira/browse/KAFKA-266?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13904224#comment-13904224 ] Jay Kreps commented on KAFKA-266: - Hey James, That's awesome! Yeah I recommend github and

[jira] [Commented] (KAFKA-1182) Topic not created if number of live brokers less than # replicas

[ https://issues.apache.org/jira/browse/KAFKA-1182?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13904180#comment-13904180 ] Jun Rao commented on KAFKA-1182: Todd, What you are thinking might work too. We will have