Re: code layout

2014-01-31 Thread Steve Morin
I like A or C I think it will be clearer for people to separate the two. On Fri, Jan 31, 2014 at 3:29 PM, Jay Kreps wrote: > For the new producer code we currently added the new module >clients > This builds the jar kafka-clients.jar. The core module should be renamed to > kafka-server and

[jira] [Updated] (KAFKA-1125) Add options to let admin tools blocking until finish

2014-01-31 Thread Guozhang Wang (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1125?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Guozhang Wang updated KAFKA-1125: - Description: Topic config change as well as create-topic, add-partition, partition-reassignment

[jira] [Created] (KAFKA-1235) Enable server to indefinitely retry on controlled shutdown

2014-01-31 Thread Guozhang Wang (JIRA)
Guozhang Wang created KAFKA-1235: Summary: Enable server to indefinitely retry on controlled shutdown Key: KAFKA-1235 URL: https://issues.apache.org/jira/browse/KAFKA-1235 Project: Kafka Issu

[jira] [Updated] (KAFKA-330) Add delete topic support

2014-01-31 Thread Neha Narkhede (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-330?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Neha Narkhede updated KAFKA-330: Attachment: KAFKA-330_2014-01-31_17:45:25.patch > Add delete topic support > --

Re: Review Request 17460: Patch for KAFKA-330

2014-01-31 Thread Neha Narkhede
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17460/ --- (Updated Feb. 1, 2014, 1:45 a.m.) Review request for kafka. Bugs: KAFKA-330

[jira] [Commented] (KAFKA-330) Add delete topic support

2014-01-31 Thread Neha Narkhede (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-330?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13888385#comment-13888385 ] Neha Narkhede commented on KAFKA-330: - Updated reviewboard https://reviews.apache.org/r

kafka pull request: Adding rack-aware replication option.

2014-01-31 Thread jmlvanre
GitHub user jmlvanre opened a pull request: https://github.com/apache/kafka/pull/16 Adding rack-aware replication option. Adding rack-aware replication option. rack-id defaults to -1. use the max-rack-replication option when creating a topic to distribute replicas such that no more

kafka pull request: Rack-Aware replica assignment option

2014-01-31 Thread jmlvanre
Github user jmlvanre closed the pull request at: https://github.com/apache/kafka/pull/14

kafka pull request: Rack aware replication

2014-01-31 Thread jmlvanre
Github user jmlvanre closed the pull request at: https://github.com/apache/kafka/pull/15

Re: [jira] [Commented] (KAFKA-1234) All kafka-run-class.sh to source in user config file (to set env vars like KAFKA_OPTS)

2014-01-31 Thread Benjamin Black
On CentOS the equivalent is files in /etc/sysconfig. As with /etc/default, they are per service settings exactly as you want and exactly to solve the problem you have. There is no need to change Kafka to behave in a non-standard way in its startup scripts. On Fri, Jan 31, 2014 at 4:14 PM, Alex Gr

Re: Review Request 17248: Patch for KAFKA-1215

2014-01-31 Thread Joris Van Remoortere
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17248/ --- (Updated Feb. 1, 2014, 12:20 a.m.) Review request for kafka. Changes ---

[jira] [Updated] (KAFKA-1215) Rack-Aware replica assignment option

2014-01-31 Thread Joris Van Remoortere (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1215?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Joris Van Remoortere updated KAFKA-1215: Attachment: rack_aware_replica_assignment_v2.patch Rebased to trunk: - Made rack-id

[jira] [Commented] (KAFKA-1234) All kafka-run-class.sh to source in user config file (to set env vars like KAFKA_OPTS)

2014-01-31 Thread Alex Gray (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1234?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13888339#comment-13888339 ] Alex Gray commented on KAFKA-1234: -- True, but the problem is that I don't want to set sys

kafka pull request: Rack aware replication

2014-01-31 Thread jmlvanre
GitHub user jmlvanre opened a pull request: https://github.com/apache/kafka/pull/15 Rack aware replication Adding rack-aware replication option. rack-id defaults to -1. use the max-rack-replication option when creating a topic to distribute replicas such that no more than max-rack-

code layout

2014-01-31 Thread Jay Kreps
For the new producer code we currently added the new module clients This builds the jar kafka-clients.jar. The core module should be renamed to kafka-server and producer kafka-server.jar. It is the intention that the server will end up depending on the clients but not vice versa (or we could ma

Proposed Changes To New Producer Public API

2014-01-31 Thread Jay Kreps
Hey folks, Thanks for all the excellent suggestions on the producer API, I think this really made things better. We'll do a similar thing for the consumer as we get a proposal together. I wanted to summarize everything I heard and the proposed changes I plan to do versus ignore. I'd like to get fe

[jira] [Commented] (KAFKA-330) Add delete topic support

2014-01-31 Thread Neha Narkhede (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-330?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13888237#comment-13888237 ] Neha Narkhede commented on KAFKA-330: - Updated reviewboard https://reviews.apache.org/r

[jira] [Updated] (KAFKA-330) Add delete topic support

2014-01-31 Thread Neha Narkhede (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-330?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Neha Narkhede updated KAFKA-330: Attachment: KAFKA-330_2014-01-31_14:19:14.patch > Add delete topic support > --

Re: Review Request 17460: Patch for KAFKA-330

2014-01-31 Thread Neha Narkhede
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17460/ --- (Updated Jan. 31, 2014, 10:19 p.m.) Review request for kafka. Bugs: KAFKA-330

[jira] [Commented] (KAFKA-1234) All kafka-run-class.sh to source in user config file (to set env vars like KAFKA_OPTS)

2014-01-31 Thread Benjamin Black (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1234?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13888211#comment-13888211 ] Benjamin Black commented on KAFKA-1234: --- There are OS-specific ways of doing this th

[jira] [Updated] (KAFKA-1234) All kafka-run-class.sh to source in user config file (to set env vars like KAFKA_OPTS)

2014-01-31 Thread Alex Gray (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1234?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Alex Gray updated KAFKA-1234: - Attachment: patch.txt Attaching patch file (I wasn't sure if I should attach the patch file or to put th

[jira] [Created] (KAFKA-1234) All kafka-run-class.sh to source in user config file (to set env vars like KAFKA_OPTS)

2014-01-31 Thread Alex Gray (JIRA)
Alex Gray created KAFKA-1234: Summary: All kafka-run-class.sh to source in user config file (to set env vars like KAFKA_OPTS) Key: KAFKA-1234 URL: https://issues.apache.org/jira/browse/KAFKA-1234 Project:

[jira] [Updated] (KAFKA-1234) All kafka-run-class.sh to source in user config file (to set env vars like KAFKA_OPTS)

2014-01-31 Thread Alex Gray (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1234?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Alex Gray updated KAFKA-1234: - Status: Patch Available (was: Open) >From 79ace5698b859753d734d976a0539d703bb3babb Mon Sep 17 00:00:00 2

[jira] [Comment Edited] (KAFKA-1100) metrics shouldn't have generation/timestamp specific names

2014-01-31 Thread Otis Gospodnetic (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1100?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13873644#comment-13873644 ] Otis Gospodnetic edited comment on KAFKA-1100 at 1/31/14 7:19 PM: --

Re: Review Request 17479: Patch for KAFKA-1232

2014-01-31 Thread Guozhang Wang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17479/#review8 --- Ship it! Ship It! - Guozhang Wang On Jan. 30, 2014, 5:51 p.m., J

Re: New Producer Public API

2014-01-31 Thread David Arthur
On 1/30/14 8:18 PM, Joel Koshy wrote: That's a good point about 1A - does seem that we would need to have some kind of TTL for each topic's metadata. Also, WRT ZK dependency I don't think that decision (for the Java client) affects other clients. i.e., other client implementations can use whate