Re: Review Request 16759: Patch for KAFKA-1199

2014-01-10 Thread Jun Rao
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/16759/#review31555 --- For non-detailed description, would it be useful to include #partiti

[jira] [Commented] (KAFKA-1025) Producer.send should provide recoverability info on failiure

2014-01-10 Thread Jason Rosenberg (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1025?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13868279#comment-13868279 ] Jason Rosenberg commented on KAFKA-1025: Yes! Or some sort of error code. > Prod

[jira] [Commented] (KAFKA-1025) Producer.send should provide recoverability info on failiure

2014-01-10 Thread Joe Stein (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1025?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13868197#comment-13868197 ] Joe Stein commented on KAFKA-1025: -- [~jbrosenb...@gmail.com] So what you are saying/askin

[jira] [Commented] (KAFKA-1025) Producer.send should provide recoverability info on failiure

2014-01-10 Thread Jason Rosenberg (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1025?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13868144#comment-13868144 ] Jason Rosenberg commented on KAFKA-1025: [~joestein], I'm not sure I understand yo

[jira] [Commented] (KAFKA-1025) Producer.send should provide recoverability info on failiure

2014-01-10 Thread Guozhang Wang (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1025?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13868033#comment-13868033 ] Guozhang Wang commented on KAFKA-1025: -- Thanks for the patch, non-committer +1. > Pr

[jira] [Updated] (KAFKA-1025) Producer.send should provide recoverability info on failiure

2014-01-10 Thread Dima Pekar (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1025?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dima Pekar updated KAFKA-1025: -- Attachment: KAFKA-1025.patch Provided patch, containing updated docs for send method of Producer. Docs

[jira] [Updated] (KAFKA-1025) Producer.send should provide recoverability info on failiure

2014-01-10 Thread Dima Pekar (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1025?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dima Pekar updated KAFKA-1025: -- Status: Patch Available (was: Open) > Producer.send should provide recoverability info on failiure > -

[jira] [Commented] (KAFKA-1025) Producer.send should provide recoverability info on failiure

2014-01-10 Thread Joe Stein (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1025?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13867909#comment-13867909 ] Joe Stein commented on KAFKA-1025: -- Hi Dima, I would say no for two reason. As Jun says

[jira] [Commented] (KAFKA-1025) Producer.send should provide recoverability info on failiure

2014-01-10 Thread Dima Pekar (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1025?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13867879#comment-13867879 ] Dima Pekar commented on KAFKA-1025: --- It's relatively easy to add FailedToSendMessageExce