Re: Review Request 16360: Patch for KAFKA-1188

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/16360/#review30768 --- core/src/main/scala/kafka/cluster/Partition.scala

Re: Review Request 16360: Patch for KAFKA-1188

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/16360/#review30767 --- Thanks for the patch. Some comments. core/src/main/scala/kafka/clu

Re: Review Request 16335: Patch for KAFKA-1187

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/16335/#review30765 --- Ship it! Ship It! - Jun Rao On Dec. 18, 2013, 12:29 a.m., Neha N

[jira] [Commented] (KAFKA-930) Integrate preferred replica election logic into kafka

[ https://issues.apache.org/jira/browse/KAFKA-930?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13854605#comment-13854605 ] Sriram Subramanian commented on KAFKA-930: -- checked in to trunk > Integrate prefe

Re: Review Request 16357: Patch for KAFKA-1185

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/16357/#review30764 --- Ship it! Ship It! - Jun Rao On Dec. 20, 2013, 12:47 a.m., Neha N

Re: Review Request 15711: Patch for KAFKA-930

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/15711/#review30761 --- Ship it! Ship It! - Neha Narkhede On Dec. 20, 2013, 7:23 p.m., S

Re: Review Request 15711: Patch for KAFKA-930

> On Dec. 12, 2013, 12:17 a.m., Neha Narkhede wrote: > > core/src/main/scala/kafka/controller/KafkaController.scala, line 947 > > > > > > If a massive admin-triggered preferred replica election is in progress, > > thi

Re: Review Request 15711: Patch for KAFKA-930

> On Dec. 12, 2013, 12:17 a.m., Neha Narkhede wrote: > > core/src/main/scala/kafka/controller/KafkaController.scala, line 947 > > > > > > If a massive admin-triggered preferred replica election is in progress, > > thi

Re: Review Request 15711: Patch for KAFKA-930

> On Dec. 12, 2013, 12:17 a.m., Neha Narkhede wrote: > > core/src/main/scala/kafka/controller/KafkaController.scala, line 773 > > > > > > Currently, all admin tools depend on state changes like preferred > > replica e

[jira] [Updated] (KAFKA-930) Integrate preferred replica election logic into kafka

[ https://issues.apache.org/jira/browse/KAFKA-930?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sriram Subramanian updated KAFKA-930: - Attachment: KAFKA-930_2013-12-20_11:22:36.patch > Integrate preferred replica election log

[jira] [Commented] (KAFKA-930) Integrate preferred replica election logic into kafka

[ https://issues.apache.org/jira/browse/KAFKA-930?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13854458#comment-13854458 ] Sriram Subramanian commented on KAFKA-930: -- Updated reviewboard https://reviews.ap

Re: Review Request 15711: Patch for KAFKA-930

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/15711/ --- (Updated Dec. 20, 2013, 7:23 p.m.) Review request for kafka. Bugs: KAFKA-930

[jira] [Commented] (KAFKA-1006) Consumer loses messages of a new topic with auto.offset.reset = largest

[ https://issues.apache.org/jira/browse/KAFKA-1006?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13854450#comment-13854450 ] Guozhang Wang commented on KAFKA-1006: -- Propose the following fix: 1. Add one more p

[jira] [Updated] (KAFKA-930) Integrate preferred replica election logic into kafka

[ https://issues.apache.org/jira/browse/KAFKA-930?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sriram Subramanian updated KAFKA-930: - Attachment: KAFKA-930_2013-12-20_11:13:01.patch > Integrate preferred replica election log

[jira] [Commented] (KAFKA-930) Integrate preferred replica election logic into kafka

[ https://issues.apache.org/jira/browse/KAFKA-930?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13854441#comment-13854441 ] Sriram Subramanian commented on KAFKA-930: -- Updated reviewboard https://reviews.ap

Re: Review Request 15711: Patch for KAFKA-930

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/15711/ --- (Updated Dec. 20, 2013, 7:13 p.m.) Review request for kafka. Bugs: KAFKA-930

[jira] [Commented] (KAFKA-1180) WhiteList topic filter gets a NullPointerException on complex Regex

[ https://issues.apache.org/jira/browse/KAFKA-1180?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13854371#comment-13854371 ] Joe Stein commented on KAFKA-1180: -- Created reviewboard https://reviews.apache.org/r/1642

[jira] [Updated] (KAFKA-1180) WhiteList topic filter gets a NullPointerException on complex Regex

[ https://issues.apache.org/jira/browse/KAFKA-1180?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Joe Stein updated KAFKA-1180: - Attachment: KAFKA-1180.patch > WhiteList topic filter gets a NullPointerException on complex Regex >

Review Request 16425: Patch for KAFKA-1180

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/16425/ --- Review request for kafka. Bugs: KAFKA-1180 https://issues.apache.org/jira/b