[jira] [Commented] (KAFKA-1100) metrics shouldn't have generation/timestamp specific names

2013-10-22 Thread Jason Rosenberg (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1100?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13802642#comment-13802642 ] Jason Rosenberg commented on KAFKA-1100: Hi Swapnil, Unfortunately, we aren't usi

[jira] [Commented] (KAFKA-1100) metrics shouldn't have generation/timestamp specific names

2013-10-22 Thread Swapnil Ghike (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1100?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13802635#comment-13802635 ] Swapnil Ghike commented on KAFKA-1100: -- Hi Jason, at LinkedIn, we use wildcards/regex

[jira] [Created] (KAFKA-1100) metrics shouldn't have generation/timestamp specific names

2013-10-22 Thread Jason Rosenberg (JIRA)
Jason Rosenberg created KAFKA-1100: -- Summary: metrics shouldn't have generation/timestamp specific names Key: KAFKA-1100 URL: https://issues.apache.org/jira/browse/KAFKA-1100 Project: Kafka

[jira] [Commented] (KAFKA-1098) Unit test failure in 0.8.1 related to LogCleaner

2013-10-22 Thread Jay Kreps (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1098?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13802606#comment-13802606 ] Jay Kreps commented on KAFKA-1098: -- Sorry about the churn btw I was only compiling for 2.

[jira] [Updated] (KAFKA-1098) Unit test failure in 0.8.1 related to LogCleaner

2013-10-22 Thread Jay Kreps (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1098?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jay Kreps updated KAFKA-1098: - Attachment: KAFKA-1098-v2.patch Here is a patch that seems to fix the issue. > Unit test failure in 0.8

[jira] [Commented] (KAFKA-1097) Race condition while reassigning low throughput partition leads to incorrect ISR information in zookeeper

2013-10-22 Thread Neha Narkhede (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1097?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13802598#comment-13802598 ] Neha Narkhede commented on KAFKA-1097: -- I think the changes are tricky and non trivia

[jira] [Commented] (KAFKA-1097) Race condition while reassigning low throughput partition leads to incorrect ISR information in zookeeper

2013-10-22 Thread Neha Narkhede (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1097?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13802591#comment-13802591 ] Neha Narkhede commented on KAFKA-1097: -- Created reviewboard https://reviews.apache.or

Review Request 14865: Patch for KAFKA-1097

2013-10-22 Thread Neha Narkhede
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/14865/ --- Review request for kafka. Bugs: KAFKA-1097 https://issues.apache.org/jira/b

[jira] [Updated] (KAFKA-1097) Race condition while reassigning low throughput partition leads to incorrect ISR information in zookeeper

2013-10-22 Thread Neha Narkhede (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1097?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Neha Narkhede updated KAFKA-1097: - Attachment: KAFKA-1097.patch > Race condition while reassigning low throughput partition leads to

[jira] [Commented] (KAFKA-1098) Unit test failure in 0.8.1 related to LogCleaner

2013-10-22 Thread Jay Kreps (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1098?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13802585#comment-13802585 ] Jay Kreps commented on KAFKA-1098: -- Joel, I think you're right. I can grab this. > Unit

[jira] [Commented] (KAFKA-1098) Unit test failure in 0.8.1 related to LogCleaner

2013-10-22 Thread Neha Narkhede (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1098?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13802572#comment-13802572 ] Neha Narkhede commented on KAFKA-1098: -- +1 on [~jjkoshy]'s suggestion. [~jvanremoorte

[jira] [Commented] (KAFKA-1097) Race condition while reassigning low throughput partition leads to incorrect ISR information in zookeeper

2013-10-22 Thread Neha Narkhede (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1097?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13802566#comment-13802566 ] Neha Narkhede commented on KAFKA-1097: -- [~joestein] This can happen only during parti

[jira] [Commented] (KAFKA-1097) Race condition while reassigning low throughput partition leads to incorrect ISR information in zookeeper

2013-10-22 Thread Joe Stein (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1097?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13802546#comment-13802546 ] Joe Stein commented on KAFKA-1097: -- So, quick question. If you have 3 brokers with repli

[jira] [Commented] (KAFKA-1098) Unit test failure in 0.8.1 related to LogCleaner

2013-10-22 Thread Joris Van Remoortere (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1098?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13802481#comment-13802481 ] Joris Van Remoortere commented on KAFKA-1098: - I think the behavior is depende

[jira] [Commented] (KAFKA-1098) Unit test failure in 0.8.1 related to LogCleaner

2013-10-22 Thread Joel Koshy (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1098?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13802477#comment-13802477 ] Joel Koshy commented on KAFKA-1098: --- Thanks for the patch - this is interesting/weird.

[jira] [Commented] (KAFKA-1097) Race condition while reassigning low throughput partition leads to incorrect ISR information in zookeeper

2013-10-22 Thread Joel Koshy (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1097?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13802344#comment-13802344 ] Joel Koshy commented on KAFKA-1097: --- nm.. i think the previous comment addressed the con

[jira] [Commented] (KAFKA-1097) Race condition while reassigning low throughput partition leads to incorrect ISR information in zookeeper

2013-10-22 Thread Joel Koshy (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1097?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13802335#comment-13802335 ] Joel Koshy commented on KAFKA-1097: --- [~guozhang] Neha's comment wrt not getting any more

[jira] [Commented] (KAFKA-1097) Race condition while reassigning low throughput partition leads to incorrect ISR information in zookeeper

2013-10-22 Thread Neha Narkhede (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1097?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13802324#comment-13802324 ] Neha Narkhede commented on KAFKA-1097: -- [~guozhang] The ISR shrink logic marks replic

[jira] [Commented] (KAFKA-1097) Race condition while reassigning low throughput partition leads to incorrect ISR information in zookeeper

2013-10-22 Thread Guozhang Wang (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1097?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13802292#comment-13802292 ] Guozhang Wang commented on KAFKA-1097: -- Hi [~nehanarkhede], as you have mentioned lea

[jira] [Comment Edited] (KAFKA-1097) Race condition while reassigning low throughput partition leads to incorrect ISR information in zookeeper

2013-10-22 Thread Neha Narkhede (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1097?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13802251#comment-13802251 ] Neha Narkhede edited comment on KAFKA-1097 at 10/22/13 9:07 PM:

[jira] [Commented] (KAFKA-1097) Race condition while reassigning low throughput partition leads to incorrect ISR information in zookeeper

2013-10-22 Thread Neha Narkhede (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1097?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13802251#comment-13802251 ] Neha Narkhede commented on KAFKA-1097: -- [~sriramsub] Agree that it is sort of corner

[jira] [Commented] (KAFKA-1097) Race condition while reassigning low throughput partition leads to incorrect ISR information in zookeeper

2013-10-22 Thread Sriram Subramanian (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1097?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13802132#comment-13802132 ] Sriram Subramanian commented on KAFKA-1097: --- >From the description, it does not

[jira] [Updated] (KAFKA-1098) Unit test failure in 0.8.1 related to LogCleaner

2013-10-22 Thread Joris Van Remoortere (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1098?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Joris Van Remoortere updated KAFKA-1098: Attachment: kafka_1098-v1.patch logSegments can currently be called with to = -1. T

[jira] [Commented] (KAFKA-1097) Race condition while reassigning low throughput partition leads to incorrect ISR information in zookeeper

2013-10-22 Thread Neha Narkhede (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1097?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13802108#comment-13802108 ] Neha Narkhede commented on KAFKA-1097: -- This is a timing issue between when the contr

[jira] [Created] (KAFKA-1099) StopReplicaRequest and StopReplicaResponse should also carry the replica ids

2013-10-22 Thread Neha Narkhede (JIRA)
Neha Narkhede created KAFKA-1099: Summary: StopReplicaRequest and StopReplicaResponse should also carry the replica ids Key: KAFKA-1099 URL: https://issues.apache.org/jira/browse/KAFKA-1099 Project: K

Re: Review Request 14730: Patch for KAFKA-1001

2013-10-22 Thread Jun Rao
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/14730/#review27309 --- core/src/main/scala/kafka/server/AbstractFetcherManager.scala

[jira] [Created] (KAFKA-1098) Unit test failure in 0.8.1 related to LogCleaner

2013-10-22 Thread Neha Narkhede (JIRA)
Neha Narkhede created KAFKA-1098: Summary: Unit test failure in 0.8.1 related to LogCleaner Key: KAFKA-1098 URL: https://issues.apache.org/jira/browse/KAFKA-1098 Project: Kafka Issue Type: Bu

[jira] [Updated] (KAFKA-1097) Race condition while reassigning partition leads to incorrect ISR information in zookeeper

2013-10-22 Thread Neha Narkhede (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1097?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Neha Narkhede updated KAFKA-1097: - Description: While moving partitions, the controller moves the old replicas through the followin

[jira] [Updated] (KAFKA-1097) Race condition while reassigning low throughput partition leads to incorrect ISR information in zookeeper

2013-10-22 Thread Neha Narkhede (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1097?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Neha Narkhede updated KAFKA-1097: - Summary: Race condition while reassigning low throughput partition leads to incorrect ISR informa