[jira] [Resolved] (KAFKA-1094) Configure reviewboard url in kafka-patch-review tool

2013-10-19 Thread Neha Narkhede (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1094?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Neha Narkhede resolved KAFKA-1094. -- Resolution: Fixed Thanks for the patch, committed to 0.8 and trunk > Configure reviewboard url

[jira] [Closed] (KAFKA-1094) Configure reviewboard url in kafka-patch-review tool

2013-10-19 Thread Neha Narkhede (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1094?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Neha Narkhede closed KAFKA-1094. > Configure reviewboard url in kafka-patch-review tool > --

Re: Review Request 14772: Configure reviewboard url in kafka-patch-review tool

2013-10-19 Thread Neha Narkhede
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/14772/#review27223 --- Ship it! Ship It! - Neha Narkhede On Oct. 19, 2013, 10:45 p.m.,

[jira] [Commented] (KAFKA-1094) Configure reviewboard url in kafka-patch-review tool

2013-10-19 Thread Swapnil Ghike (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1094?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13800024#comment-13800024 ] Swapnil Ghike commented on KAFKA-1094: -- Same patch will work for trunk. > Configure

[jira] [Commented] (KAFKA-1094) Configure reviewboard url in kafka-patch-review tool

2013-10-19 Thread Swapnil Ghike (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1094?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13800023#comment-13800023 ] Swapnil Ghike commented on KAFKA-1094: -- Created reviewboard https://reviews.apache.or

[jira] [Updated] (KAFKA-1094) Configure reviewboard url in kafka-patch-review tool

2013-10-19 Thread Swapnil Ghike (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1094?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Swapnil Ghike updated KAFKA-1094: - Attachment: KAFKA-1094.patch > Configure reviewboard url in kafka-patch-review tool > ---

[jira] [Created] (KAFKA-1094) Configure reviewboard url in kafka-patch-review tool

2013-10-19 Thread Swapnil Ghike (JIRA)
Swapnil Ghike created KAFKA-1094: Summary: Configure reviewboard url in kafka-patch-review tool Key: KAFKA-1094 URL: https://issues.apache.org/jira/browse/KAFKA-1094 Project: Kafka Issue Type

Review Request 14773: Configure reviewboard url in kafka-patch-review tool

2013-10-19 Thread Swapnil Ghike
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/14773/ --- Review request for kafka. Bugs: KAFKA-1094 https://issues.apache.org/jira/b

[jira] [Updated] (KAFKA-1093) Log.getOffsetsBefore(t, …) does not return the last confirmed offset before t

2013-10-19 Thread Swapnil Ghike (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1093?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Swapnil Ghike updated KAFKA-1093: - Attachment: (was: KAFKA-1093.patch) > Log.getOffsetsBefore(t, …) does not return the last con

[jira] [Commented] (KAFKA-1093) Log.getOffsetsBefore(t, …) does not return the last confirmed offset before t

2013-10-19 Thread Swapnil Ghike (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1093?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13800021#comment-13800021 ] Swapnil Ghike commented on KAFKA-1093: -- Created reviewboard https://reviews.apache.or

[jira] [Updated] (KAFKA-1093) Log.getOffsetsBefore(t, …) does not return the last confirmed offset before t

2013-10-19 Thread Swapnil Ghike (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1093?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Swapnil Ghike updated KAFKA-1093: - Attachment: KAFKA-1093.patch > Log.getOffsetsBefore(t, …) does not return the last confirmed offs

[jira] [Issue Comment Deleted] (KAFKA-1093) Log.getOffsetsBefore(t, …) does not return the last confirmed offset before t

2013-10-19 Thread Swapnil Ghike (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1093?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Swapnil Ghike updated KAFKA-1093: - Comment: was deleted (was: Created reviewboard https://reviews.apache.org/r/14772/ ) > Log.getOf

Review Request 14772: Configure reviewboard url in kafka-patch-review tool

2013-10-19 Thread Swapnil Ghike
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/14772/ --- Review request for kafka. Bugs: KAFKA-1093 https://issues.apache.org/jira/b

[jira] [Issue Comment Deleted] (KAFKA-1093) Log.getOffsetsBefore(t, …) does not return the last confirmed offset before t

2013-10-19 Thread Swapnil Ghike (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1093?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Swapnil Ghike updated KAFKA-1093: - Comment: was deleted (was: Created reviewboard ) > Log.getOffsetsBefore(t, …) does not return th

[jira] [Updated] (KAFKA-1093) Log.getOffsetsBefore(t, …) does not return the last confirmed offset before t

2013-10-19 Thread Swapnil Ghike (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1093?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Swapnil Ghike updated KAFKA-1093: - Attachment: (was: KAFKA-1093.patch) > Log.getOffsetsBefore(t, …) does not return the last con

Re: Review Request 14771: Log.getOffsetsBefore(t, …) does not return the last confirmed offset before t

2013-10-19 Thread Swapnil Ghike
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/14771/ --- (Updated Oct. 19, 2013, 10:34 p.m.) Review request for kafka. Bugs: KAFKA-109

[jira] [Updated] (KAFKA-1093) Log.getOffsetsBefore(t, …) does not return the last confirmed offset before t

2013-10-19 Thread Swapnil Ghike (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1093?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Swapnil Ghike updated KAFKA-1093: - Attachment: KAFKA-1093.patch > Log.getOffsetsBefore(t, …) does not return the last confirmed offs

[jira] [Commented] (KAFKA-1093) Log.getOffsetsBefore(t, …) does not return the last confirmed offset before t

2013-10-19 Thread Swapnil Ghike (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1093?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13800018#comment-13800018 ] Swapnil Ghike commented on KAFKA-1093: -- Created reviewboard https://reviews.apache.or

Review Request 14771: Log.getOffsetsBefore(t, …) does not return the last confirmed offset before t

2013-10-19 Thread Swapnil Ghike
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/14771/ --- Review request for kafka. Bugs: KAFKA-1093 https://issues.apache.org/jira/b

Re: preparing for the 0.8 final release

2013-10-19 Thread Jason Rosenberg
I'll try to, next time it hangs! On Sat, Oct 19, 2013 at 4:04 PM, Neha Narkhede wrote: > Can you send around a thread dump of the halted consumer process? > > > > On Sat, Oct 19, 2013 at 12:16 PM, Jason Rosenberg > wrote: > > > The latest HEAD does seem to solve one issue, where a new topic bei

[jira] [Updated] (KAFKA-1093) Log.getOffsetsBefore(t, …) does not return the last confirmed offset before t

2013-10-19 Thread Swapnil Ghike (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1093?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Swapnil Ghike updated KAFKA-1093: - Attachment: KAFKA-1093.patch > Log.getOffsetsBefore(t, …) does not return the last confirmed offs

[jira] [Commented] (KAFKA-1093) Log.getOffsetsBefore(t, …) does not return the last confirmed offset before t

2013-10-19 Thread Swapnil Ghike (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1093?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13800013#comment-13800013 ] Swapnil Ghike commented on KAFKA-1093: -- Created reviewboard > Log.getOffsetsBefore(

Re: CurrentMagicValue comment confusion in Message.scala at Branch 0.8

2013-10-19 Thread Neha Narkhede
The magic byte is used to allow format changes in a backwards compatible way. Kafka 0.6 used magic byte 0, we changed that to 1 in Kafka 0.7 as compression required adding new fields to Message. Value is 2 currently (kafka 0.8) since we changed the format of Message to implement replication. On S

Re: preparing for the 0.8 final release

2013-10-19 Thread Neha Narkhede
Can you send around a thread dump of the halted consumer process? On Sat, Oct 19, 2013 at 12:16 PM, Jason Rosenberg wrote: > The latest HEAD does seem to solve one issue, where a new topic being > created after the consumer is started, would not be consumed. > > But the bigger issue is that we

Re: preparing for the 0.8 final release

2013-10-19 Thread Jason Rosenberg
The latest HEAD does seem to solve one issue, where a new topic being created after the consumer is started, would not be consumed. But the bigger issue is that we have a couple different consumers both consuming the same set of topics (under different groupids), and hanging after a while (both ha

[jira] [Updated] (KAFKA-1093) Log.getOffsetsBefore(t, …) does not return the last confirmed offset before t

2013-10-19 Thread Swapnil Ghike (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1093?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Swapnil Ghike updated KAFKA-1093: - Description: Let's say there are three log segments s1, s2, s3. In Log.getoffsetsBefore(t, …), t

[jira] [Created] (KAFKA-1093) Log.getOffsetsBefore(t, …) does not return the last confirmed offset before t

2013-10-19 Thread Swapnil Ghike (JIRA)
Swapnil Ghike created KAFKA-1093: Summary: Log.getOffsetsBefore(t, …) does not return the last confirmed offset before t Key: KAFKA-1093 URL: https://issues.apache.org/jira/browse/KAFKA-1093 Project:

[jira] [Updated] (KAFKA-1093) Log.getOffsetsBefore(t, …) does not return the last confirmed offset before t

2013-10-19 Thread Swapnil Ghike (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1093?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Swapnil Ghike updated KAFKA-1093: - Affects Version/s: 0.8 > Log.getOffsetsBefore(t, …) does not return the last confirmed offset bef

CurrentMagicValue comment confusion in Message.scala at Branch 0.8

2013-10-19 Thread Heaton Chen
Dear team, I am looking at the source code at Branch 0.8. I have a confusion in Message.scala file. the CurrentMagicValue was set 0 initially, but in class comments I saw “1 byte "magic" identifier to allow format changes, value is 2 currently”? what does it mean? Regards Heaton Chen Web Ad