Re: Review Request 14013: Added support for Scala 2.10 builds while maintaining compatibility with 2.8.x

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/14013/ --- (Updated Sept. 9, 2013, 12:40 a.m.) Review request for kafka and Neha Narkhede.

Re: Review Request 14013: Added support for Scala 2.10 builds while maintaining compatibility with 2.8.x

> On Sept. 8, 2013, 10:47 p.m., Jun Rao wrote: > > I am wondering if there is any performance degradation due to the changes > > in implicit conversion. Could you run kafka.perf.ProducerPerformance and > > see if there is any noticeable performance change with and w/o the patch? both should co

[jira] [Commented] (KAFKA-1050) Support for "no data loss" mode

[ https://issues.apache.org/jira/browse/KAFKA-1050?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13761547#comment-13761547 ] Justin SB commented on KAFKA-1050: -- You're definitely right Jay that I'm conflating a few

Re: Review Request 14013: Added support for Scala 2.10 builds while maintaining compatibility with 2.8.x

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/14013/ --- (Updated Sept. 8, 2013, 9:47 p.m.) Review request for kafka and Neha Narkhede.

Re: Review Request 14013: Added support for Scala 2.10 builds while maintaining compatibility with 2.8.x

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/14013/#review25979 --- I am wondering if there is any performance degradation due to the ch

[jira] [Commented] (KAFKA-1050) Support for "no data loss" mode

[ https://issues.apache.org/jira/browse/KAFKA-1050?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13761530#comment-13761530 ] Jay Kreps commented on KAFKA-1050: -- Or actually, perhaps I am confused. The data loss cas

[jira] [Commented] (KAFKA-1050) Support for "no data loss" mode

[ https://issues.apache.org/jira/browse/KAFKA-1050?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13761528#comment-13761528 ] Jay Kreps commented on KAFKA-1050: -- I think there may be some confusion. Does this sectio

Re: review board is available

This is great. So far I reviewed 2 patches using reviewboard and it is a huge time saver. I have one question about the setup though - the reviewboard has a Bugs field that takes in the JIRA, can it update the respective JIRA with the reviewboard link ? The concern is that with more reviews coming

[jira] [Commented] (KAFKA-1046) Added support for Scala 2.10 builds while maintaining compatibility with 2.8.x

[ https://issues.apache.org/jira/browse/KAFKA-1046?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13761483#comment-13761483 ] Neha Narkhede commented on KAFKA-1046: -- Reviewboard is here - https://reviews.apache.

Re: Review Request 14013: Added support for Scala 2.10 builds while maintaining compatibility with 2.8.x

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/14013/#review25977 --- Overall, this is a great patch. Thanks for contributing it. I have s

[jira] [Updated] (KAFKA-1046) Added support for Scala 2.10 builds while maintaining compatibility with 2.8.x

[ https://issues.apache.org/jira/browse/KAFKA-1046?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Neha Narkhede updated KAFKA-1046: - Assignee: Christopher Freeman > Added support for Scala 2.10 builds while maintaining compati

Re: Review Request 14013: Added support for Scala 2.10 builds while maintaining compatibility with 2.8.x

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/14013/ --- (Updated Sept. 7, 2013, 11:35 p.m.) Review request for kafka and Neha Narkhede.