[jira] [Commented] (KAFKA-914) Deadlock between initial rebalance and watcher-triggered rebalances

2013-05-21 Thread Jun Rao (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-914?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13663605#comment-13663605 ] Jun Rao commented on KAFKA-914: --- Thanks for the patch. Looks good. +1. One minor comment: The

[jira] [Updated] (KAFKA-914) Deadlock between initial rebalance and watcher-triggered rebalances

2013-05-21 Thread Joel Koshy (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-914?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Joel Koshy updated KAFKA-914: - Attachment: KAFKA-914-v1.patch Patch with the mentioned fix. 1 - I added comments with some detail since

Re: produce request wire format question

2013-05-21 Thread Dave Peterson
In my case, there is a load balancer between the producers and the brokers, so I want the behavior described for the Java client (null key specifies "any partition"). If the Key field of each individual message specifies the partition to send it to, then I don't understand the purpose of the 32-bi

Re: produce request wire format question

2013-05-21 Thread Neha Narkhede
Dave, Colin described the producer behavior of picking the partition for a message before it is sent to Kafka broker correctly. However, I'm interested in knowing your use case a little before to see why you would rather have the broker decide the partition? Thanks, Neha On Tue, May 21, 2013 at

Re: produce request wire format question

2013-05-21 Thread Colin Blower
The key is used by the client to decide which partition to send the message to. By the time the client is creating the produce request, it should be known which partition each message is being sent to. I believe Neha described the behavior of the Java client which sends messages with a null key to

Re: produce request wire format question

2013-05-21 Thread Dave Peterson
I'm looking at the document entitled "A Guide to the Kafka Protocol" located here: https://cwiki.apache.org/KAFKA/a-guide-to-the-kafka-protocol.html It shows a produce request as containing a number of message sets, which are grouped first by topic and second by partition (a 32-bit integer).

[jira] [Resolved] (KAFKA-913) [Documentation] 0.8 Quickstart mentions sbt assembly-package-dependency - not needed

2013-05-21 Thread Martin Eigenbrodt (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-913?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Martin Eigenbrodt resolved KAFKA-913. - Resolution: Invalid Indeed. I mixed up the git branches and tried it on "trunk". on 0.8 i

Re: produce request wire format question

2013-05-21 Thread Neha Narkhede
No. In 0.8, if you don't specify a key for a message, it is sent to any of the available partitions. In other words, the partition id is selected on the partition and the server doesn't get -1 as the partition id. Thanks, Neha On Tue, May 21, 2013 at 9:54 AM, Dave Peterson wrote: > In the versi

[jira] [Commented] (KAFKA-914) Deadlock between initial rebalance and watcher-triggered rebalances

2013-05-21 Thread Joel Koshy (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-914?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13663146#comment-13663146 ] Joel Koshy commented on KAFKA-914: -- One more point: [td3] above does not need to originate

[jira] [Commented] (KAFKA-901) Kafka server can become unavailable if clients send several metadata requests

2013-05-21 Thread Neha Narkhede (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-901?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13663131#comment-13663131 ] Neha Narkhede commented on KAFKA-901: - Thanks for the quick review, committed it

produce request wire format question

2013-05-21 Thread Dave Peterson
In the version 0.8 wire format for a produce request, does a value of -1 still indicate "use a random partition" as it did for 0.7? Thanks, Dave

[jira] [Commented] (KAFKA-901) Kafka server can become unavailable if clients send several metadata requests

2013-05-21 Thread Jun Rao (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-901?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13663118#comment-13663118 ] Jun Rao commented on KAFKA-901: --- Thanks for the second followup patch. +1. >

[jira] [Commented] (KAFKA-913) [Documentation] 0.8 Quickstart mentions sbt assembly-package-dependency - not needed

2013-05-21 Thread Jun Rao (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-913?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13663093#comment-13663093 ] Jun Rao commented on KAFKA-913: --- Did you try this on the latest of the 0.8 branch? What OS di

[jira] [Resolved] (KAFKA-912) [Documentation] 0.8 Quickstart mentions sbt assembly-package-dependency - not needed

2013-05-21 Thread Jun Rao (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-912?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jun Rao resolved KAFKA-912. --- Resolution: Duplicate > [Documentation] 0.8 Quickstart mentions sbt assembly-package-dependency - > not

[jira] [Closed] (KAFKA-912) [Documentation] 0.8 Quickstart mentions sbt assembly-package-dependency - not needed

2013-05-21 Thread Jun Rao (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-912?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jun Rao closed KAFKA-912. - > [Documentation] 0.8 Quickstart mentions sbt assembly-package-dependency - > not needed > -

[jira] [Updated] (KAFKA-901) Kafka server can become unavailable if clients send several metadata requests

2013-05-21 Thread Neha Narkhede (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-901?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Neha Narkhede updated KAFKA-901: Attachment: kafka-901-followup2.patch I agree. Kept only the 2nd logging message about caching the l

[jira] [Commented] (KAFKA-901) Kafka server can become unavailable if clients send several metadata requests

2013-05-21 Thread Jun Rao (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-901?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13663063#comment-13663063 ] Jun Rao commented on KAFKA-901: --- Thanks for the followup patch. Some comments: 60. KafkaApis

[jira] [Created] (KAFKA-914) Deadlock between initial rebalance and watcher-triggered rebalances

2013-05-21 Thread Joel Koshy (JIRA)
Joel Koshy created KAFKA-914: Summary: Deadlock between initial rebalance and watcher-triggered rebalances Key: KAFKA-914 URL: https://issues.apache.org/jira/browse/KAFKA-914 Project: Kafka Issu