[jira] [Commented] (KAFKA-745) Remove getShutdownReceive() and other kafka specific code from the RequestChannel

2013-02-05 Thread Sriram Subramanian (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-745?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13572229#comment-13572229 ] Sriram Subramanian commented on KAFKA-745: -- Took a look at this. The main issue is

[jira] [Updated] (KAFKA-519) Allow commiting the state of single KafkaStream

2013-02-05 Thread Esko Suomi (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-519?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Esko Suomi updated KAFKA-519: - Priority: Minor (was: Major) > Allow commiting the state of single KafkaStream >

[jira] [Updated] (KAFKA-749) Bug in socket server shutdown logic makes the broker hang on shutdown until it has to be killed

2013-02-05 Thread Neha Narkhede (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-749?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Neha Narkhede updated KAFKA-749: Resolution: Fixed Status: Resolved (was: Patch Available) Thanks for the reviews, checked i

[jira] [Closed] (KAFKA-749) Bug in socket server shutdown logic makes the broker hang on shutdown until it has to be killed

2013-02-05 Thread Neha Narkhede (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-749?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Neha Narkhede closed KAFKA-749. --- > Bug in socket server shutdown logic makes the broker hang on shutdown until > it has to be killed >

[jira] [Closed] (KAFKA-695) Broker shuts down due to attempt to read a closed index file

2013-02-05 Thread Neha Narkhede (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-695?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Neha Narkhede closed KAFKA-695. --- > Broker shuts down due to attempt to read a closed index file > -

[jira] [Resolved] (KAFKA-695) Broker shuts down due to attempt to read a closed index file

2013-02-05 Thread Neha Narkhede (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-695?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Neha Narkhede resolved KAFKA-695. - Resolution: Fixed > Broker shuts down due to attempt to read a closed index file > ---

[jira] [Commented] (KAFKA-745) Remove getShutdownReceive() and other kafka specific code from the RequestChannel

2013-02-05 Thread Sriram Subramanian (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-745?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13571720#comment-13571720 ] Sriram Subramanian commented on KAFKA-745: -- I would like to take this and complete

[jira] [Assigned] (KAFKA-745) Remove getShutdownReceive() and other kafka specific code from the RequestChannel

2013-02-05 Thread Sriram Subramanian (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-745?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sriram Subramanian reassigned KAFKA-745: Assignee: Sriram Subramanian (was: Jun Rao) > Remove getShutdownReceive() and o

[jira] [Updated] (KAFKA-751) Fix windows build script - kafka-run-class.bat

2013-02-05 Thread Mark deVilliers (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-751?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mark deVilliers updated KAFKA-751: -- Attachment: kafka-run-class.diff > Fix windows build script - kafka-run-class.bat >

[jira] [Updated] (KAFKA-751) Fix windows build script - kafka-run-class.bat

2013-02-05 Thread Mark deVilliers (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-751?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mark deVilliers updated KAFKA-751: -- Description: I've updated the kafka-run-class.bat to keep it in line (and working) with the kaf

[jira] [Created] (KAFKA-751) Fix windows build script - kafka-run-class.bat

2013-02-05 Thread Mark deVilliers (JIRA)
Mark deVilliers created KAFKA-751: - Summary: Fix windows build script - kafka-run-class.bat Key: KAFKA-751 URL: https://issues.apache.org/jira/browse/KAFKA-751 Project: Kafka Issue Type: Bug

[jira] [Commented] (KAFKA-749) Bug in socket server shutdown logic makes the broker hang on shutdown until it has to be killed

2013-02-05 Thread Neha Narkhede (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-749?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13571625#comment-13571625 ] Neha Narkhede commented on KAFKA-749: - That is correct. Also, removing the getShutdownR

[jira] [Updated] (KAFKA-513) Add state change log to Kafka brokers

2013-02-05 Thread Neha Narkhede (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-513?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Neha Narkhede updated KAFKA-513: Labels: p1 replication tools (was: p2 replication tools) > Add state change log to Kafka broker

[jira] [Commented] (KAFKA-749) Bug in socket server shutdown logic makes the broker hang on shutdown until it has to be killed

2013-02-05 Thread Jay Kreps (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-749?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13571585#comment-13571585 ] Jay Kreps commented on KAFKA-749: - Also, not sure if I get it. If the I/O threads are able

[jira] [Commented] (KAFKA-749) Bug in socket server shutdown logic makes the broker hang on shutdown until it has to be killed

2013-02-05 Thread Jay Kreps (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-749?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13571578#comment-13571578 ] Jay Kreps commented on KAFKA-749: - Why is that a big change? > Bug in sock

[jira] [Commented] (KAFKA-749) Bug in socket server shutdown logic makes the broker hang on shutdown until it has to be killed

2013-02-05 Thread Neha Narkhede (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-749?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13571535#comment-13571535 ] Neha Narkhede commented on KAFKA-749: - KAFKA-745 is filed for that. I prefer to not tou

[jira] [Commented] (KAFKA-749) Bug in socket server shutdown logic makes the broker hang on shutdown until it has to be killed

2013-02-05 Thread Sriram Subramanian (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-749?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13571527#comment-13571527 ] Sriram Subramanian commented on KAFKA-749: -- Awesome. looks good to me. Nit - are w

[jira] [Commented] (KAFKA-749) Bug in socket server shutdown logic makes the broker hang on shutdown until it has to be killed

2013-02-05 Thread Neha Narkhede (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-749?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13571520#comment-13571520 ] Neha Narkhede commented on KAFKA-749: - Sriram, That is what I had described in my simpl

[jira] [Updated] (KAFKA-749) Bug in socket server shutdown logic makes the broker hang on shutdown until it has to be killed

2013-02-05 Thread Neha Narkhede (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-749?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Neha Narkhede updated KAFKA-749: Attachment: kafka-749-v2.patch Thanks for the review ! I think I was over thinking the issue of requ

[jira] [Commented] (KAFKA-749) Bug in socket server shutdown logic makes the broker hang on shutdown until it has to be killed

2013-02-05 Thread Sriram Subramanian (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-749?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13571511#comment-13571511 ] Sriram Subramanian commented on KAFKA-749: -- If that works fine. But it looks like

[jira] [Commented] (KAFKA-749) Bug in socket server shutdown logic makes the broker hang on shutdown until it has to be killed

2013-02-05 Thread Jay Kreps (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-749?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13571505#comment-13571505 ] Jay Kreps commented on KAFKA-749: - That makes sense, good solution. > Bug

[jira] [Updated] (KAFKA-736) Add an option to the 0.8 producer to mimic 0.7 producer behavior

2013-02-05 Thread Neha Narkhede (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-736?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Neha Narkhede updated KAFKA-736: Status: In Progress (was: Patch Available) > Add an option to the 0.8 producer to mimic 0.7 pro

[jira] [Updated] (KAFKA-736) Add an option to the 0.8 producer to mimic 0.7 producer behavior

2013-02-05 Thread Neha Narkhede (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-736?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Neha Narkhede updated KAFKA-736: Attachment: kafka-736-v3-producer-latency-20threads-acks1.out kafka-736-draft-produce

[jira] [Commented] (KAFKA-736) Add an option to the 0.8 producer to mimic 0.7 producer behavior

2013-02-05 Thread Neha Narkhede (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-736?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13571485#comment-13571485 ] Neha Narkhede commented on KAFKA-736: - Producer performance does not measure latency di

[jira] [Commented] (KAFKA-695) Broker shuts down due to attempt to read a closed index file

2013-02-05 Thread Jun Rao (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-695?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13571449#comment-13571449 ] Jun Rao commented on KAFKA-695: --- It's possible. However, some subclasses of ShutdownableThrea

[jira] [Commented] (KAFKA-695) Broker shuts down due to attempt to read a closed index file

2013-02-05 Thread Jay Kreps (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-695?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13571427#comment-13571427 ] Jay Kreps commented on KAFKA-695: - Can we just remove the interrupt entirely instead of mak

[jira] [Commented] (KAFKA-695) Broker shuts down due to attempt to read a closed index file

2013-02-05 Thread Jay Kreps (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-695?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13571427#comment-13571427 ] Jay Kreps commented on KAFKA-695: - Can we just remove the interrupt entirely instead of mak

[jira] [Commented] (KAFKA-749) Bug in socket server shutdown logic makes the broker hang on shutdown until it has to be killed

2013-02-05 Thread Neha Narkhede (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-749?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13571425#comment-13571425 ] Neha Narkhede commented on KAFKA-749: - Is this the logic for the shutdown() API in Kafk

[jira] [Commented] (KAFKA-695) Broker shuts down due to attempt to read a closed index file

2013-02-05 Thread Neha Narkhede (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-695?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13571413#comment-13571413 ] Neha Narkhede commented on KAFKA-695: - 1,3. Makes sense and the follow up patch v2 look

[jira] [Commented] (KAFKA-671) DelayedProduce requests should not hold full producer request data

2013-02-05 Thread Jay Kreps (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-671?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13571360#comment-13571360 ] Jay Kreps commented on KAFKA-671: - I think hacking requestObj is fine as an intermediate st

[jira] [Commented] (KAFKA-749) Bug in socket server shutdown logic makes the broker hang on shutdown until it has to be killed

2013-02-05 Thread Jay Kreps (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-749?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13571355#comment-13571355 ] Jay Kreps commented on KAFKA-749: - Err, should be while(true) { queue.clear() if(queue

[jira] [Commented] (KAFKA-749) Bug in socket server shutdown logic makes the broker hang on shutdown until it has to be killed

2013-02-05 Thread Jay Kreps (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-749?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13571353#comment-13571353 ] Jay Kreps commented on KAFKA-749: - So what if we just do while(true) { queue.clear() q

[jira] [Commented] (KAFKA-695) Broker shuts down due to attempt to read a closed index file

2013-02-05 Thread Jun Rao (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-695?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13571167#comment-13571167 ] Jun Rao commented on KAFKA-695: --- 1. Any unexpected exception in ReplicaFetcherThread will kil

[jira] [Updated] (KAFKA-695) Broker shuts down due to attempt to read a closed index file

2013-02-05 Thread Jun Rao (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-695?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jun Rao updated KAFKA-695: -- Attachment: kafka-695_followup_v2.patch Attach followup patch v2. > Broker shuts down due to at