Re: git workflow

2013-01-04 Thread Joe Stein
I am getting the no email after doing git am --signoff < xyz.patch so nothing gets in to commit to set the author :( On Sat, Jan 5, 2013 at 12:30 AM, Jay Kreps wrote: > I have but I don't really know why. This format worked for me: > git commit --author='Bertrand Russell ' > > > On Fri, Jan

Re: git workflow

2013-01-04 Thread Jay Kreps
I have but I don't really know why. This format worked for me: git commit --author='Bertrand Russell ' On Fri, Jan 4, 2013 at 8:35 PM, Joe Stein wrote: > I started following this so far really helpful thanks!! > > Running into some issues reviewing someone's patch getting "Patch does not > ha

Re: git workflow

2013-01-04 Thread Joe Stein
I started following this so far really helpful thanks!! Running into some issues reviewing someone's patch getting "Patch does not have a valid e-mail address." googling to figure out what is wrong figure I mention here if anyone bumped into this yet thnx On Thu, Jan 3, 2013 at 11:17 AM, Jun Rao

[jira] [Commented] (KAFKA-683) Fix correlation ids in all requests sent to kafka

2013-01-04 Thread Jun Rao (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-683?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13544506#comment-13544506 ] Jun Rao commented on KAFKA-683: --- Thanks for the patch. Some comments: 1. DefaultEventHandler

[jira] [Commented] (KAFKA-682) java.lang.OutOfMemoryError: Java heap space

2013-01-04 Thread Joel Koshy (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-682?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13544503#comment-13544503 ] Joel Koshy commented on KAFKA-682: -- I think that fix was merged into trunk (before 32da) s

[jira] [Commented] (KAFKA-657) Add an API to commit offsets

2013-01-04 Thread Jay Kreps (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-657?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13544370#comment-13544370 ] Jay Kreps commented on KAFKA-657: - I updated the property name. Normally I am against comme

[jira] [Commented] (KAFKA-657) Add an API to commit offsets

2013-01-04 Thread David Arthur (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-657?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13544354#comment-13544354 ] David Arthur commented on KAFKA-657: Jun, 80. Those commented out tests will be valid

[jira] [Commented] (KAFKA-682) java.lang.OutOfMemoryError: Java heap space

2013-01-04 Thread Jun Rao (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-682?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13544333#comment-13544333 ] Jun Rao commented on KAFKA-682: --- That commit is in trunk. Could you try the current head in 0

[jira] [Commented] (KAFKA-657) Add an API to commit offsets

2013-01-04 Thread Jun Rao (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-657?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13544322#comment-13544322 ] Jun Rao commented on KAFKA-657: --- v8 looks good. Just some minor comments. 80. OffsetCommitTe

[jira] [Resolved] (KAFKA-657) Add an API to commit offsets

2013-01-04 Thread Jay Kreps (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-657?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jay Kreps resolved KAFKA-657. - Resolution: Fixed Fix Version/s: 0.8.1 Committed. > Add an API to commit offsets >

[jira] [Closed] (KAFKA-680) ApiUtils#writeShortString uses String length instead of byte length

2013-01-04 Thread Jun Rao (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-680?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jun Rao closed KAFKA-680. - > ApiUtils#writeShortString uses String length instead of byte length > --

[jira] [Resolved] (KAFKA-680) ApiUtils#writeShortString uses String length instead of byte length

2013-01-04 Thread Jun Rao (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-680?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jun Rao resolved KAFKA-680. --- Resolution: Fixed Fix Version/s: 0.8 Thanks for the patch. +1. Committed to 0.8 and merged into trunk.

[jira] [Commented] (KAFKA-657) Add an API to commit offsets

2013-01-04 Thread Neha Narkhede (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-657?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13544261#comment-13544261 ] Neha Narkhede commented on KAFKA-657: - +1 on v8 > Add an API to commit

[jira] [Updated] (KAFKA-680) ApiUtils#writeShortString uses String length instead of byte length

2013-01-04 Thread David Arthur (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-680?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Arthur updated KAFKA-680: --- Attachment: KAFKA-680v1.patch Attaching v1 of patch, included some unit tests > ApiUt

[jira] [Updated] (KAFKA-683) Fix correlation ids in all requests sent to kafka

2013-01-04 Thread Neha Narkhede (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-683?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Neha Narkhede updated KAFKA-683: Attachment: kafka-683-v1.patch This patch does the following - 1. Fixes the correlation id for all r

[jira] [Work started] (KAFKA-683) Fix correlation ids in all requests sent to kafka

2013-01-04 Thread Neha Narkhede (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-683?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Work on KAFKA-683 started by Neha Narkhede. > Fix correlation ids in all requests sent to kafka > - > > Key

[jira] [Created] (KAFKA-683) Fix correlation ids in all requests sent to kafka

2013-01-04 Thread Neha Narkhede (JIRA)
Neha Narkhede created KAFKA-683: --- Summary: Fix correlation ids in all requests sent to kafka Key: KAFKA-683 URL: https://issues.apache.org/jira/browse/KAFKA-683 Project: Kafka Issue Type: Impro

[jira] [Commented] (KAFKA-682) java.lang.OutOfMemoryError: Java heap space

2013-01-04 Thread Joel Koshy (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-682?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13544119#comment-13544119 ] Joel Koshy commented on KAFKA-682: -- You might need to increase your heap size. What do you

Re: kafka mavenification

2013-01-04 Thread Joe Stein
I have been pretty intrenched in these tickets. I will give it a review and keep tabs on it yup. On Fri, Jan 4, 2013 at 12:19 PM, Jay Kreps wrote: > Thanks to Maxime it looks like it is done. Who can review this? > https://issues.apache.org/jira/browse/KAFKA-133 > > Would be good to have a "she

[jira] [Created] (KAFKA-682) java.lang.OutOfMemoryError: Java heap space

2013-01-04 Thread Ricky Ng-Adam (JIRA)
Ricky Ng-Adam created KAFKA-682: --- Summary: java.lang.OutOfMemoryError: Java heap space Key: KAFKA-682 URL: https://issues.apache.org/jira/browse/KAFKA-682 Project: Kafka Issue Type: Bug

[jira] [Commented] (KAFKA-657) Add an API to commit offsets

2013-01-04 Thread Jay Kreps (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-657?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13544054#comment-13544054 ] Jay Kreps commented on KAFKA-657: - This looks good to me. If no further objections I am tak

[jira] [Resolved] (KAFKA-681) Unclean shutdown testing - truncateAndStartWithNewOffset is not invoked when it is expected to

2013-01-04 Thread Jun Rao (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-681?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jun Rao resolved KAFKA-681. --- Resolution: Fixed Fix Version/s: 0.8 Assignee: Jun Rao Thanks for the review. Committed to 0.8

[jira] [Closed] (KAFKA-681) Unclean shutdown testing - truncateAndStartWithNewOffset is not invoked when it is expected to

2013-01-04 Thread Jun Rao (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-681?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jun Rao closed KAFKA-681. - > Unclean shutdown testing - truncateAndStartWithNewOffset is not invoked when > it is expected to >

[jira] [Commented] (KAFKA-681) Unclean shutdown testing - truncateAndStartWithNewOffset is not invoked when it is expected to

2013-01-04 Thread John Fung (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-681?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13543997#comment-13543997 ] John Fung commented on KAFKA-681: - Thanks Jun for the patch. * The patch is applied with t

[jira] [Updated] (KAFKA-657) Add an API to commit offsets

2013-01-04 Thread David Arthur (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-657?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Arthur updated KAFKA-657: --- Attachment: KAFKA-657v8.patch Attaching v8 70. I have consolidated (offset, metadata, error) into a c

[jira] [Updated] (KAFKA-133) Publish kafka jar to a public maven repository

2013-01-04 Thread Maxime Brugidou (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-133?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Maxime Brugidou updated KAFKA-133: -- Attachment: KAFKA-133.patch Taking Otis notes into account, Here is the simplest patch I could m