On 1/2/13 7:03 PM, Jay Kreps wrote:
David,
So are there any changes you think we should make to the instructions? I
think what I wrote matches what you are describing.
I think what you've got in the wiki is great (didn't read it before
sending my message earlier - oops)
The git patch support d
David,
So are there any changes you think we should make to the instructions? I
think what I wrote matches what you are describing.
The git patch support does seem better since I think it maintains
authorship and allows you to transmit multiple commits as a single file (if
needed).
-Jay
On Wed
[
https://issues.apache.org/jira/browse/KAFKA-657?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13542566#comment-13542566
]
Jay Kreps commented on KAFKA-657:
-
Looks good to me. A few things in addition to the other
[
https://issues.apache.org/jira/browse/KAFKA-513?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13542550#comment-13542550
]
Neha Narkhede commented on KAFKA-513:
-
Thanks for patch v1. Overall looks pretty good,
[
https://issues.apache.org/jira/browse/KAFKA-657?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13542540#comment-13542540
]
Jun Rao commented on KAFKA-657:
---
Thanks for patch v7. Some more comments:
70. OffsetFetchRes
Here is what I've been doing
* Clone Kafka locally (git clone git://github.com/apache/kafka.git)
* Create feature branch off of trunk (git branch KAFKA-657)
* Do work on the feature branch
* Rebase from trunk (git rebase trunk). This minimizes or eliminates any
conflicts when people try to apply
[
https://issues.apache.org/jira/browse/KAFKA-668?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Joel Koshy closed KAFKA-668.
> Controlled shutdown admin tool should not require controller JMX url/port to
> be supplied
>
[
https://issues.apache.org/jira/browse/KAFKA-668?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Joel Koshy resolved KAFKA-668.
--
Resolution: Fixed
Thanks for the review. Committed to 0.8.
> Controlled shutdown admin
[
https://issues.apache.org/jira/browse/KAFKA-668?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13542466#comment-13542466
]
Jun Rao commented on KAFKA-668:
---
Thanks for patch v2. +1
> Controlled shutdo
[
https://issues.apache.org/jira/browse/KAFKA-657?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
David Arthur updated KAFKA-657:
---
Attachment: KAFKA-657v7.patch
Attaching patch v7 - addresses Joel's comments.
> Add a
I don't know about other people but I find git kind of confusing. I thought
it would be useful to try to document the normal workflow for different use
cases:
1. Contributing a patch
2. Reviewing and integrating a patch that is contributed
3. Doing development as a committer
4. Keeping a copy of yo
[
https://issues.apache.org/jira/browse/KAFKA-657?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13542390#comment-13542390
]
Joel Koshy commented on KAFKA-657:
--
Hey David, the patch (and the wiki) looks great.
- Fo
[
https://issues.apache.org/jira/browse/KAFKA-674?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
John Fung updated KAFKA-674:
Attachment: kafka-674-reproduce-issue-v2.patch
Uploaded kafka-674-reproduce-issue-v2.patch with the followin
[
https://issues.apache.org/jira/browse/KAFKA-668?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Joel Koshy updated KAFKA-668:
-
Attachment: KAFKA-668-v2.patch
Needed a rebase.
> Controlled shutdown admin tool should n
[
https://issues.apache.org/jira/browse/KAFKA-668?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13542321#comment-13542321
]
Jun Rao commented on KAFKA-668:
---
The patch doesn't seem to apply on 0.8 for me.
git apply -p
[
https://issues.apache.org/jira/browse/KAFKA-657?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13542299#comment-13542299
]
David Arthur commented on KAFKA-657:
Post-holiday bump. Anyone had a chance to look at
Dear podling,
This email was sent by an automated system on behalf of the Apache Incubator
PMC.
It is an initial reminder to give you plenty of time to prepare your quarterly
board report.
The board meeting is scheduled for Wed, 16 January 2013, 10:00:00 PST. The
report
for your podling will
17 matches
Mail list logo
