[jira] [Commented] (KAFKA-675) Only bind to the interface declared in the 'hostname' config property

2012-12-20 Thread Matan (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-675?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13537688#comment-13537688 ] Matan commented on KAFKA-675: - Thanks guys! I appreciate the effort getting this in. This will

[jira] [Resolved] (KAFKA-675) Only bind to the interface declared in the 'hostname' config property

2012-12-20 Thread Jay Kreps (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-675?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jay Kreps resolved KAFKA-675. - Resolution: Fixed Fix Version/s: 0.8 Assignee: Jay Kreps > Only bind to the interface

[jira] [Commented] (KAFKA-675) Only bind to the interface declared in the 'hostname' config property

2012-12-20 Thread Jun Rao (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-675?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13537610#comment-13537610 ] Jun Rao commented on KAFKA-675: --- Patch v3 looks good to me. +1 > Only bind t

Re: Offset commit api

2012-12-20 Thread Jay Kreps
Yeah, I just meant that as an example, it should be configurable. -Jay On Thu, Dec 20, 2012 at 2:15 PM, Milind Parikh wrote: > +1 on limiting the size. But could you do 2k instead of 1k? Using Interval > Time Clocks gets you a lot on distributed autonomous processing; but most > large scale ITC

[jira] [Updated] (KAFKA-675) Only bind to the interface declared in the 'hostname' config property

2012-12-20 Thread Jay Kreps (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-675?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jay Kreps updated KAFKA-675: Attachment: KAFKA-675-v3.patch Here is a slightly tweaked version of your patch. I just fixed some problems

Re: Offset commit api

2012-12-20 Thread Milind Parikh
+1 on limiting the size. But could you do 2k instead of 1k? Using Interval Time Clocks gets you a lot on distributed autonomous processing; but most large scale ITCs go upto 1.5K. http://code.google.com/p/itclocks/refer to the link on conference paper. Regards Milind On Thu, Dec 20, 2012

Re: Offset commit api

2012-12-20 Thread David Arthur
Sounds good to me On 12/20/12 5:04 PM, Jay Kreps wrote: Err, to clarify, I meant punt on persisting the metadata not punt on persisting the offset. Basically that field would be in the protocol but would be unused in this phase. -Jay On Thu, Dec 20, 2012 at 2:03 PM, Jay Kreps wrote: I actu

Re: Offset commit api

2012-12-20 Thread Jay Kreps
Err, to clarify, I meant punt on persisting the metadata not punt on persisting the offset. Basically that field would be in the protocol but would be unused in this phase. -Jay On Thu, Dec 20, 2012 at 2:03 PM, Jay Kreps wrote: > I actually recommend we just punt on implementing persistence in

Re: Offset commit api

2012-12-20 Thread Jay Kreps
I actually recommend we just punt on implementing persistence in zk entirely, otherwise we have to have an upgrade path to grandfather over existing zk data to the new format. Let's just add it in the API and only actually store it out when we redo the backend. We can handle the size limit then too

Re: Offset commit api

2012-12-20 Thread David Arthur
No particular objection, though in order to support atomic writes of (offset, metadata), we will need to define a protocol for the ZooKeeper payloads. Something like: OffsetPayload => Offset [Metadata] Metadata => length prefixed string should suffice. Otherwise we would have to rely on th

[jira] [Commented] (KAFKA-657) Add an API to commit offsets

2012-12-20 Thread Jay Kreps (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-657?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13537390#comment-13537390 ] Jay Kreps commented on KAFKA-657: - Also I had one more generalization I would like to add--

Re: Offset commit api

2012-12-20 Thread Jay Kreps
Okay I did some assessment of use cases we have which aren't using the default offset storage API and came up with one generalization. I would like to propose--add a generic metadata field to the offset api on a per-partition basis. So that would leave us with the following: OffsetCommitRequest =>

[jira] [Commented] (KAFKA-657) Add an API to commit offsets

2012-12-20 Thread Jay Kreps (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-657?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13537368#comment-13537368 ] Jay Kreps commented on KAFKA-657: - It probably makes sense to do this in two phases. Let's

[jira] [Commented] (KAFKA-657) Add an API to commit offsets

2012-12-20 Thread Jun Rao (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-657?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13537327#comment-13537327 ] Jun Rao commented on KAFKA-657: --- Thanks for patch v4. Some comments: 40. Could you add the A

[jira] [Updated] (KAFKA-657) Add an API to commit offsets

2012-12-20 Thread David Arthur (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-657?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Arthur updated KAFKA-657: --- Attachment: KAFKA-657v4.patch I regenerated the patch after rebasing from trunk. Jun, see if it works

[jira] Subscription: outstanding kafka patches

2012-12-20 Thread jira
Issue Subscription Filter: outstanding kafka patches (54 issues) The list of outstanding kafka patches Subscriber: kafka-mailing-list Key Summary KAFKA-675 Only bind to the interface declared in the 'hostname' config property https://issues.apache.org/jira/browse/KAF

[jira] [Commented] (KAFKA-657) Add an API to commit offsets

2012-12-20 Thread Jun Rao (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-657?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13537237#comment-13537237 ] Jun Rao commented on KAFKA-657: --- I was trying to apply patch v3 in trunk (on a revision befor

[jira] [Commented] (KAFKA-496) high level producer send should return a response

2012-12-20 Thread Jay Kreps (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-496?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13537231#comment-13537231 ] Jay Kreps commented on KAFKA-496: - I found this helpful in thinking about futures: http://

[jira] [Commented] (KAFKA-657) Add an API to commit offsets

2012-12-20 Thread David Arthur (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-657?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13537062#comment-13537062 ] David Arthur commented on KAFKA-657: Jay, the one thing I'm still unclear on are the va

Re: order guarantee failure: better/best effort?

2012-12-20 Thread ben fleis
Heey Jy, Any luck with a java triggering test? b