Re: [PR] [JSPWIKI-1178] Address potential deadlock with JDK 21 Virtual Threads. [jspwiki]

2023-10-10 Thread via GitHub
arturobernalg commented on PR #307: URL: https://github.com/apache/jspwiki/pull/307#issuecomment-1754548191 > The utility/class method focus should be more about synchronizing than locking (hence the names). > > Hi @arturobernalg ! > > > However, this approach has limitatio

Re: [PR] JSPWIKI-925 - Add Missing i18n Literals for Multiple Languages [jspwiki]

2023-10-10 Thread via GitHub
arturobernalg commented on PR #312: URL: https://github.com/apache/jspwiki/pull/312#issuecomment-1755804657 > Hi, lgtm! > > agree on the ordering of the properties, should be done on a separate PR, probably renaming them according to where they are being used; right now they are orde

[jira] [Updated] (JSPWIKI-1182) Reorder and Rename i18n Literals According to Usage Context

2023-10-10 Thread Arturo Bernal (Jira)
[ https://issues.apache.org/jira/browse/JSPWIKI-1182?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Arturo Bernal updated JSPWIKI-1182: --- Affects Version/s: 2.12.1 > Reorder and Rename i18n Literals According to Usage Context > -

[jira] [Created] (JSPWIKI-1182) Reorder and Rename i18n Literals According to Usage Context

2023-10-10 Thread Arturo Bernal (Jira)
Arturo Bernal created JSPWIKI-1182: -- Summary: Reorder and Rename i18n Literals According to Usage Context Key: JSPWIKI-1182 URL: https://issues.apache.org/jira/browse/JSPWIKI-1182 Project: JSPWiki

Re: [PR] JSPWIKI-925 - Add Missing i18n Literals for Multiple Languages [jspwiki]

2023-10-10 Thread via GitHub
arturobernalg commented on PR #312: URL: https://github.com/apache/jspwiki/pull/312#issuecomment-1755833207 @juanpablo-santos I'm encountering the following error while when the CI is running: ```[ERROR] Failed to execute goal org.apache.maven.plugins:maven-deploy-plugin:3.1.1:deploy

Re: [PR] JSPWIKI-925 - Add Missing i18n Literals for Multiple Languages [jspwiki]

2023-10-10 Thread Murray Altheim
Hi Arturo, Does there happen to be an XML comment between the declaration and the start tag? That's what the error message suggests. Cheers, Murray On 11/10/23 05:44, arturobernalg (via GitHub) wrote: arturobernalg commented on PR #312: URL: https://github.com/apache/jspwiki/pull/312#issue

Re: [PR] JSPWIKI-925 - Add Missing i18n Literals for Multiple Languages [jspwiki]

2023-10-10 Thread Murray Altheim
To be clear, in XML, comments are permitted in the XML Prolog (Production 22 in the XML spec) and the doctypedecl (Production 28), but I think the POM parser barfs on them. On 11/10/23 12:24, Murray Altheim wrote: Hi Arturo, Does there happen to be an XML comment between the declaration and th