Re: [PR] [JSPWIKI-1178] Address potential deadlock with JDK 21 Virtual Threads. (jspwiki)

2023-10-03 Thread via GitHub
arturobernalg commented on PR #307: URL: https://github.com/apache/jspwiki/pull/307#issuecomment-1745343221 > Hi, > > interesting PR! :-) My only comment is that I'd extract the lock behaviour on a utility class something similar to (pseudocode, surely doesn't even compile): >

Discussion on Fixing Relative URLs in Email Notifications (JSPWIKI-1056)

2023-10-03 Thread Arturo Bernal
Hi Team, I hope this email finds you well. I am writing to open a discussion on the issue JSPWIKI-1056 , which concerns the generation of relative URLs in email notifications sent after user registration. As some of you may know, the emails curr

Re: Discussion on Fixing Relative URLs in Email Notifications (JSPWIKI-1056)

2023-10-03 Thread Arturo Bernal
HI, Maybe we should consider extending the URL construction logic to include checks for the X-Forwarded-Server header, in addition to X-Forwarded-Host and X-Forwarded-Proto. This would offer a more comprehensive way to determine the original server and scheme, particularly in scenarios where the a