[jira] [Commented] (JSPWIKI-1181) Search popup does not handle attachments correctly

2023-10-02 Thread Ulf Dittmer (Jira)
[ https://issues.apache.org/jira/browse/JSPWIKI-1181?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17771028#comment-17771028 ] Ulf Dittmer commented on JSPWIKI-1181: -- Yes, that fix works just as well. > Searc

Re: [PR] JSPWIKI-1181 - Fix: Correct URL Generation for Pages with Special Characters (jspwiki)

2023-10-02 Thread via GitHub
arturobernalg merged PR #310: URL: https://github.com/apache/jspwiki/pull/310 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@jspwiki.ap

[jira] [Commented] (JSPWIKI-1181) Search popup does not handle attachments correctly

2023-10-02 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/JSPWIKI-1181?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17771047#comment-17771047 ] ASF subversion and git services commented on JSPWIKI-1181: -- Co

[jira] [Commented] (JSPWIKI-1181) Search popup does not handle attachments correctly

2023-10-02 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/JSPWIKI-1181?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17771048#comment-17771048 ] ASF subversion and git services commented on JSPWIKI-1181: -- Co

[jira] [Resolved] (JSPWIKI-1181) Search popup does not handle attachments correctly

2023-10-02 Thread Arturo Bernal (Jira)
[ https://issues.apache.org/jira/browse/JSPWIKI-1181?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Arturo Bernal resolved JSPWIKI-1181. Resolution: Fixed > Search popup does not handle attachments correctly >

[jira] [Updated] (JSPWIKI-1056) URL in registration mail is relative while it should be absolute

2023-10-02 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/JSPWIKI-1056?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated JSPWIKI-1056: Labels: pull-request-available (was: ) > URL in registration mail is relative while it s

[PR] JSPWIKI-1056: Add Absolute URL Utility Methods (jspwiki)

2023-10-02 Thread via GitHub
arturobernalg opened a new pull request, #311: URL: https://github.com/apache/jspwiki/pull/311 ### Summary This PR addresses [JSPWIKI-1056](https://issues.apache.org/jira/browse/JSPWIKI-1056) by adding utility methods to generate absolute URLs. These methods are used to send abs

[jira] [Commented] (JSPWIKI-1056) URL in registration mail is relative while it should be absolute

2023-10-02 Thread Arturo Bernal (Jira)
[ https://issues.apache.org/jira/browse/JSPWIKI-1056?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17771253#comment-17771253 ] Arturo Bernal commented on JSPWIKI-1056: Hi [~metskem]    I've submitted a pul

Re: [PR] JSPWIKI-1056: Add Absolute URL Utility Methods (jspwiki)

2023-10-02 Thread via GitHub
juanpablo-santos commented on PR #311: URL: https://github.com/apache/jspwiki/pull/311#issuecomment-1743694515 Hi, wiki installations behind an apache web server (or similar) would send their internal URL, which surely wouldn't be intended. We could also check for known headers with

Re: [PR] [JSPWIKI-1178] Address potential deadlock with JDK 21 Virtual Threads. (jspwiki)

2023-10-02 Thread via GitHub
juanpablo-santos commented on PR #307: URL: https://github.com/apache/jspwiki/pull/307#issuecomment-1743774024 Hi, interesting PR! :-) My only comment is that I'd extract the lock behaviour on a utility class something similar to (pseudocode, surely doesn't even compile): ```j