Re: Post mortem JSPWiki 2.11.0.M1-rc1

2018-12-16 Thread Juan Pablo Santos Rodríguez
Hi Dirk, thanks for looking into it, seems that with latest commit, points 1 through 3 of the above issues' list get solved as well :-) Also, as a bonus, renaming the template to default addresses point 8, and people upgrading only have to modify their jspwiki[-custom].properties file if they want

Re: Post mortem JSPWiki 2.11.0.M1-rc1

2018-12-15 Thread Dirk Frederickx
I just pushed some fixes related to the default (now haddock) template. Please rerun your tests. dirk On Tue, Dec 11, 2018 at 10:11 PM Dirk Frederickx wrote: > Hi Juan, > > I did some further testing. > > JSPWiki's template engine has an automatic mechanism to resolve the > requested JSP's in

Re: Post mortem JSPWiki 2.11.0.M1-rc1

2018-12-11 Thread Dirk Frederickx
Hi Juan, I did some further testing. JSPWiki's template engine has an automatic mechanism to resolve the requested JSP's in 2 steps: - first the JSP is searched for in the current active template subdirectory : this is now HADDOCK - if that fails the JSP is searched for in the template/default

Re: Post mortem JSPWiki 2.11.0.M1-rc1

2018-12-10 Thread Juan Pablo Santos Rodríguez
Hi Dirk, meant to send an e-mail with it this afternoon, but forgot :-S That page is linked from the "Building from source" page, so hopefully will be easily discoverable. The mvn-cheatsheet.md file present on source still needs to be polished, though. As for the test itself, how is it failing?

Re: Post mortem JSPWiki 2.11.0.M1-rc1

2018-12-10 Thread Dirk Frederickx
Juan, Thanks for putting your description on https://jspwiki-wiki.apache.org/Wiki.jsp?page=Common%20problems%20when%20building%20JSPWiki ; That made the build run. I was able to create a war. Still one test is failing (testReadContentsFromPipe) so I needed to use the -DskipTests flag. dirk

Re: Post mortem JSPWiki 2.11.0.M1-rc1

2018-12-08 Thread Dirk Frederickx
Juan *- Point 6, question: on which version was that tested? the issue raisedpoints to 2.11.0.M2-SNAPSHOT (current master, not the RC tag), but that isalso building ([#2] does the whole build). On previous versions, themarkdown module was build after the main war, and with 2.11.0.M1 it b