Re: Code Standards

2014-02-23 Thread Adrien Beau
For your information, recent-enough versions of Eclipse have a code formatting setting that makes Eclipse only format modified lines when a file is saved. This way, new and recently-changed code can be migrated to a new style, while untouched lines remain intact. Le 21 févr. 2014 13:10, "Brian Burc

Re: Code Standards

2014-02-21 Thread Brian Burch
On 20/02/14 23:46, Glen Mazza wrote: Brian, if you'd like a larger role on the team, best to start submitting patches on actual code functionality enhancements -- as you gain more "cred" on the project, you'll naturally gain more influence on matters such as code style, especially if you become a

Re: Code Standards

2014-02-20 Thread Glen Mazza
Brian, if you'd like a larger role on the team, best to start submitting patches on actual code functionality enhancements -- as you gain more "cred" on the project, you'll naturally gain more influence on matters such as code style, especially if you become a committer. I felt your arguments

Re: Code Standards

2014-02-20 Thread Brian Burch
On 19/02/14 23:50, Juan Pablo Santos Rodríguez wrote: Hi, there is an Eclipse code style file and a a checkstyle file at $SVN/jspwiki-war/src/main/config/dev regarding the format itself, I use [#1] it while coding, as I find it more readable than if (cond) { whatever } else { whatever_ev

Re: Code Standards

2014-02-19 Thread Juan Pablo Santos Rodríguez
Hi, there is an Eclipse code style file and a a checkstyle file at $SVN/jspwiki-war/src/main/config/dev regarding the format itself, I use [#1] it while coding, as I find it more readable than if (cond) { whatever } else { whatever_ever } so I'm afraid I'm guilty of breaking the code format

Re: Code Standards

2014-02-13 Thread Ichiro Furusato
Hi Brian, IMO, these kinds of discussions are all about aesthetics and almost always devolve to arguments that go nowhere, at least nowhere productive. I know there have been a number of discussions over the many years of this project, involving Janne and others. Whether we love the current forma

Re: Code Standards

2014-02-12 Thread Harry Metske
Brian, I am rather neutral to code standards, but have also a preference to more "compact code". So I am +1 to your proposal. kind regards, Harry When I first started working on patches for tomcat several years ago, I found their code standards quite extreme compared to my personal preferences.