Re: Failing tests on ReferenceManagerTest (was: [VOTE] Release JSPWiki version 2.10.0)

2014-01-23 Thread Juan Pablo Santos Rodríguez
Hi, regarding on how to attach the patch, once you've logged into jira, go to https://issues.apache.org/jira/browse/JSPWIKI-813 and, under the "More" dropdown button, there should be displayed an "Attach Files" option. I recall older versions of JIRA having this option on a more visible place, but

Re: Failing tests on ReferenceManagerTest (was: [VOTE] Release JSPWiki version 2.10.0)

2014-01-23 Thread Brian Burch
On 23/01/14 17:24, Juan Pablo Santos Rodríguez wrote: Hi Brian, just seen you've already filed a JIRA. Yes. I am fine-tuning the code at this moment, so please wait until I attach my proposed change. You can then review it and modify it as you feel best. If you want to attach a patch in t

Re: Failing tests on ReferenceManagerTest (was: [VOTE] Release JSPWiki version 2.10.0)

2014-01-23 Thread Juan Pablo Santos Rodríguez
Hi Brian, just seen you've already filed a JIRA. If you want to attach a patch in there, I'd go for adding TestEngine.emptyWorkDir(null); at setUp(). Also, I would modify TestEngine.emptyWorkDir(Properties props) to check if cache is enabled and, in that case, call CacheManager.getInstance().remov

Re: Failing tests on ReferenceManagerTest (was: [VOTE] Release JSPWiki version 2.10.0)

2014-01-21 Thread Brian Burch
On 21/01/14 17:37, Brian Burch wrote: On 21/01/14 16:51, Brian Burch wrote: On 20/01/14 20:50, Juan Pablo Santos Rodríguez wrote: Hi Brian, would mind performing a couple of changes to see if they solve your build issue: 1) substitute lines 50-63 on setUp at ReferenceManagerTest, with the fol

Re: Failing tests on ReferenceManagerTest (was: [VOTE] Release JSPWiki version 2.10.0)

2014-01-21 Thread Brian Burch
On 21/01/14 16:51, Brian Burch wrote: On 20/01/14 20:50, Juan Pablo Santos Rodríguez wrote: Hi Brian, would mind performing a couple of changes to see if they solve your build issue: 1) substitute lines 50-63 on setUp at ReferenceManagerTest, with the following lines: TestEngine.emptyWorkDir(n

Re: Failing tests on ReferenceManagerTest (was: [VOTE] Release JSPWiki version 2.10.0)

2014-01-21 Thread Brian Burch
On 20/01/14 20:50, Juan Pablo Santos Rodríguez wrote: Hi Brian, would mind performing a couple of changes to see if they solve your build issue: 1) substitute lines 50-63 on setUp at ReferenceManagerTest, with the following lines: TestEngine.emptyWorkDir(null); CacheManager.getInstance().remova

Re: Failing tests on ReferenceManagerTest (was: [VOTE] Release JSPWiki version 2.10.0)

2014-01-21 Thread Brian Burch
On 20/01/14 20:50, Juan Pablo Santos Rodríguez wrote: Hi Brian, would mind performing a couple of changes to see if they solve your build issue: 1) substitute lines 50-63 on setUp at ReferenceManagerTest, with the following lines: TestEngine.emptyWorkDir(null); CacheManager.getInstance().remova

Re: Failing tests on ReferenceManagerTest (was: [VOTE] Release JSPWiki version 2.10.0)

2014-01-20 Thread Juan Pablo Santos Rodríguez
Hi Brian, would mind performing a couple of changes to see if they solve your build issue: 1) substitute lines 50-63 on setUp at ReferenceManagerTest, with the following lines: TestEngine.emptyWorkDir(null); CacheManager.getInstance().removalAll(); and then mvn clean install 2) change all refer

Re: Failing tests on ReferenceManagerTest

2014-01-18 Thread Brian Burch
On 18/01/14 16:32, Craig L Russell wrote: On Jan 18, 2014, at 3:31 AM, Brian Burch wrote: On 18/01/14 10:32, Harry Metske wrote: Brian, there is a small mvn cheatsheet in the root of the project (I ask myself this same question too every time) : http://svn.apache.org/viewvc/jspwiki/trunk/mvn

Re: Failing tests on ReferenceManagerTest (was: [VOTE] Release JSPWiki version 2.10.0)

2014-01-18 Thread Craig L Russell
On Jan 18, 2014, at 3:31 AM, Brian Burch wrote: > On 18/01/14 10:32, Harry Metske wrote: >> Brian, >> >> there is a small mvn cheatsheet in the root of the project (I ask myself >> this same question too every time) : >> http://svn.apache.org/viewvc/jspwiki/trunk/mvn_cheat-sheet.txt?view=markup

Re: Failing tests on ReferenceManagerTest (was: [VOTE] Release JSPWiki version 2.10.0)

2014-01-18 Thread Brian Burch
On 18/01/14 10:32, Harry Metske wrote: Brian, there is a small mvn cheatsheet in the root of the project (I ask myself this same question too every time) : http://svn.apache.org/viewvc/jspwiki/trunk/mvn_cheat-sheet.txt?view=markup So this would be the mvn equivalent: mvn test -Dtest=org.apach

Re: Failing tests on ReferenceManagerTest (was: [VOTE] Release JSPWiki version 2.10.0)

2014-01-18 Thread Brian Burch
On 18/01/14 10:26, Brian Burch wrote: On 18/01/14 01:03, Juan Pablo Santos Rodríguez wrote: (changed thread subject in order to not pollute the vote thread) Hi Brian, a couple of questions: did you an "mvn install" or "mvn clean install"? if the first, did you do it on a fresh copy or over a

Re: Failing tests on ReferenceManagerTest (was: [VOTE] Release JSPWiki version 2.10.0)

2014-01-18 Thread Harry Metske
Brian, there is a small mvn cheatsheet in the root of the project (I ask myself this same question too every time) : http://svn.apache.org/viewvc/jspwiki/trunk/mvn_cheat-sheet.txt?view=markup So this would be the mvn equivalent: mvn test -Dtest=org.apache.wiki.ReferenceManagerTest kind regards

Re: Failing tests on ReferenceManagerTest (was: [VOTE] Release JSPWiki version 2.10.0)

2014-01-18 Thread Brian Burch
On 18/01/14 01:03, Juan Pablo Santos Rodríguez wrote: (changed thread subject in order to not pollute the vote thread) Hi Brian, a couple of questions: did you an "mvn install" or "mvn clean install"? if the first, did you do it on a fresh copy or over a working copy? Clean checkout, then "m

Failing tests on ReferenceManagerTest (was: [VOTE] Release JSPWiki version 2.10.0)

2014-01-17 Thread Juan Pablo Santos Rodríguez
(changed thread subject in order to not pollute the vote thread) Hi Brian, a couple of questions: can you run those tests individually on your IDE? maybe there is an issue related to tests execution order (https://builds.apache.org/job/JSPWiki/does the build fine, as https://analysis.apache.org/