[jira] [Updated] (JSPWIKI-814) VersioningFileProvider does migrate original page properties

2014-02-13 Thread Brian Burch (JIRA)
[ https://issues.apache.org/jira/browse/JSPWIKI-814?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Brian Burch updated JSPWIKI-814: Attachment: JSPWIKI-814-patch-VersioningFileProvider Implements a new method getHeritagePageProper

[jira] [Updated] (JSPWIKI-814) VersioningFileProvider does migrate original page properties

2014-02-13 Thread Brian Burch (JIRA)
[ https://issues.apache.org/jira/browse/JSPWIKI-814?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Brian Burch updated JSPWIKI-814: Attachment: JSPWIKI-814-patch-VersioningFileProvider add a new method called getHeritagePageProper

[jira] [Commented] (JSPWIKI-814) VersioningFileProvider does migrate original page properties

2014-02-13 Thread Brian Burch (JIRA)
[ https://issues.apache.org/jira/browse/JSPWIKI-814?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13900600#comment-13900600 ] Brian Burch commented on JSPWIKI-814: - The associated patch file adds and wires-in a

[jira] [Updated] (JSPWIKI-814) VersioningFileProvider does migrate original page properties

2014-02-13 Thread Brian Burch (JIRA)
[ https://issues.apache.org/jira/browse/JSPWIKI-814?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Brian Burch updated JSPWIKI-814: Attachment: JSPWIKI-814-patch-VersioningFileProviderTest New test cases, 5 of which fail unless th

[jira] [Commented] (JSPWIKI-814) VersioningFileProvider does migrate original page properties

2014-02-13 Thread Brian Burch (JIRA)
[ https://issues.apache.org/jira/browse/JSPWIKI-814?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13900594#comment-13900594 ] Brian Burch commented on JSPWIKI-814: - My test failures were related to TestEngine's

Re: JSON-RPC support

2014-02-13 Thread Dirk Frederickx
Ichiro, I took some more time to read back through your message trace, and probably I was on the wrong foot. I understand you are trying to use JSON inside a JSPWiki-plugin (based on ' RPCSamplePlugin') Looking more in detail to the RPCSamplePlugin and the JSONRPCManager, I was puzzled about

[jira] [Updated] (JSPWIKI-814) VersioningFileProvider does migrate original page properties

2014-02-13 Thread Brian Burch (JIRA)
[ https://issues.apache.org/jira/browse/JSPWIKI-814?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Brian Burch updated JSPWIKI-814: Attachment: (was: JSPWIKI-814-patch-author) > VersioningFileProvider does migrate original pag

[jira] [Created] (JSPWIKI-821) TestEngine sometimes creates testrepositories with double timestamps after r1567444

2014-02-13 Thread Brian Burch (JIRA)
Brian Burch created JSPWIKI-821: --- Summary: TestEngine sometimes creates testrepositories with double timestamps after r1567444 Key: JSPWIKI-821 URL: https://issues.apache.org/jira/browse/JSPWIKI-821 Pro

[jira] [Updated] (JSPWIKI-814) VersioningFileProvider does migrate original page properties

2014-02-13 Thread Brian Burch (JIRA)
[ https://issues.apache.org/jira/browse/JSPWIKI-814?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Brian Burch updated JSPWIKI-814: Attachment: JSPWIKI-814-patch-TestEngine Standalone trivial change to TestEngine. The saveTextAsJa

[jira] [Commented] (JSPWIKI-814) VersioningFileProvider does migrate original page properties

2014-02-13 Thread Brian Burch (JIRA)
[ https://issues.apache.org/jira/browse/JSPWIKI-814?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13900299#comment-13900299 ] Brian Burch commented on JSPWIKI-814: - Please disregard the last patches for the 3 fi

Re: JSON-RPC support

2014-02-13 Thread Ichiro Furusato
Hi Dirk, Yup, that's what I meant by 'instrumented' the JSONRPCManager. The wiki log has my comments: JSONRPCManager.registerGlobalObject() id='blah' class: 'net.neocortext.wiki.plugin.json.JsonTest$JSONRPCTarget' hashcode: 974083980 JsonTest() registered 'blah' with JSONRPCBridge. So it

Re: JSON-RPC support

2014-02-13 Thread Dirk Frederickx
Ichiro, The json error indicates that the command "blah.response" is not found. Maybe the JSON registerGlobalObject was not called? Can you put a log just before/after the registerGlobalObject() to check whether it gets invoked ? dirk On Thu, Feb 13, 2014 at 9:41 AM, Ichiro Furusato wrote: >

Re: JSON-RPC support

2014-02-13 Thread Ichiro Furusato
Hi Dirk, My JSONRPCTarget is your MyJSONBlahSample. I'm quite literally doing exactly what you suggested. Here's my registration: JSONRPCManager.registerGlobalObject("blah",new JSONRPCTarget()); and my implementing class (i.e., an inner class, just the way it's done in SearchManager with its

Re: Code Standards

2014-02-13 Thread Ichiro Furusato
Hi Brian, IMO, these kinds of discussions are all about aesthetics and almost always devolve to arguments that go nowhere, at least nowhere productive. I know there have been a number of discussions over the many years of this project, involving Janne and others. Whether we love the current forma