Use AutoService library to generate Java SPI files in Ignite 3

2022-12-07 Thread Aleksandr Polovtsev
Dear Igniters! In Ignite 3, we have a bunch of classes that utilize the Java SPI (ConfigurationModule and MetricsExporter to name a few). For every interface implementation we need to manually create a file in the META-INF folder. This step can be automated by the AutoService library [1]. I can se

Re: Use AutoService library to generate Java SPI files in Ignite 3

2022-12-07 Thread Вячеслав Коптилин
Hi Aleksandr, This suggestion seems useful to me. As Aleksandr pointed out, this is a compile-time dependency, so it doesn't look risky. +1 Thanks, Slava. ср, 7 дек. 2022 г. в 10:20, Aleksandr Polovtsev : > Dear Igniters! In Ignite 3, we have a bunch of classes that utilize the > Java SPI (Co

Re: Use AutoService library to generate Java SPI files in Ignite 3

2022-12-07 Thread Ivan Bessonov
Hello, I'm all in for this change, thank you for the PR! +1 ср, 7 дек. 2022 г. в 12:15, Вячеслав Коптилин : > Hi Aleksandr, > > This suggestion seems useful to me. > As Aleksandr pointed out, this is a compile-time dependency, so it doesn't > look risky. > > +1 > > Thanks, > Slava. > > > ср, 7

Re: Use AutoService library to generate Java SPI files in Ignite 3

2022-12-07 Thread Mirza Aliev
Hello, Very useful change, huge +1 ср, 7 дек. 2022 г. в 13:01, Ivan Bessonov : > Hello, > > I'm all in for this change, thank you for the PR! > > +1 > > ср, 7 дек. 2022 г. в 12:15, Вячеслав Коптилин : > > > Hi Aleksandr, > > > > This suggestion seems useful to me. > > As Aleksandr pointed out, t

Re: Ignite support for IoC beyond spring framework

2022-12-07 Thread Łukasz Dywicki
Hello, I would like to check again status on proposed changes as the pull request went over first (and I think second) cycle of reviews. Looking forward for your feedback and possibility to include these changes in Ignite 2.15 release. Kind regards, Łukasz On 17.10.2022 18:56, Łukasz Dywicki