Re: Proxy (GridServiceProxy) for local services if required

2022-01-20 Thread Вячеслав Коптилин
Hi, > Yep, seems that current behaviour is not correct at all. `serviceProxy()` should return exactly what it should -- proxy. +1. I tend to have the same opinion. Thanks, S. ср, 19 янв. 2022 г. в 17:33, Ivan Daschinsky : > Yep, seems that current behaviour is not correct at all. `serviceProxy(

Re: Proxy (GridServiceProxy) for local services if required

2022-01-20 Thread Vladimir Steshin
    Slava, hi. There are many 'give-service' methods. I doubt we need one more. User should consider exact type of the service handle, instance or proxy. It's up to Ignite to decide. There is a service interface for user. But yes, we might just return proxy every time. On 18.01.2022 14:30

Re: Proxy (GridServiceProxy) for local services if required

2022-01-20 Thread Vladimir Steshin
    Valentin, hi. "Could you elaborate on why we count metrics incorrectly when theserviceProxy() returns an instance of a local service instead of an actual proxy?" Local instance executes direct calls without any wrapping and doesn't measure itself. That's why we bring proxy by 'serviceProxy(

Re: Proxy (GridServiceProxy) for local services if required

2022-01-20 Thread Vladimir Steshin
 Yes. Invocations from direct reference are not measured. This method in the javadoc: /* NOTE: Statistics are collected only with service proxies obtaining by methods like/ /* {@link IgniteServices#serviceProxy(String, Class, boolean)} and won't work for direct reference of local/ /* serv

Re: [VOTE] @Nullable/@NotNull annotation usage in Ignite 3

2022-01-20 Thread Alexander Polovtcev
Thanks everybody, the voting has finished. Here are the results: Option 2: 7 votes Option 4: 2 votes Other options: 0 votes Looks like the Option 2 is preferred, I will create a more formal description of it in Confluence as soon as we have the Ignite 3 code style page set up. On Thu, Jan 13, 2

[VOTE] Service proxy for local service by 'IgniteServices#serviceProxy()'

2022-01-20 Thread Vladimir Steshin
    Hi, Igniters.     Should we return a proxy even for local services by 'IgniteServices#serviceProxy()'? *I vote +1*, let's return proxy.     This question has recently raised again. Before the service metrics, we returned direct instance for local services. With service metrics enabled

Incorrect hash and sig links

2022-01-20 Thread Mark Thomas
Ignite developers, I noticed that your download page is incorrectly linking to dlcdn.apache.org for hashes and signatures. As per the release policy [1], these links MUST point to downloads.apache.org Please correct these links ASAP. Thanks, Mark [1] https://infra.apache.org/release-downlo

Re: Proxy (GridServiceProxy) for local services if required

2022-01-20 Thread Valentin Kulichenko
So the proposed change will not actually fix the issue with metrics, because it's still possible to get a local instance via the service() method. At the same time, the change removes an existing performance optimization. Let's figure out how to fix the actual problem. If the *only* way to have me

Re: [VOTE] Service proxy for local service by 'IgniteServices#serviceProxy()'

2022-01-20 Thread Valentin Kulichenko
-1 until we finish the discussion in another thread. The original problem we're trying to solve here is related to metrics, which will still be broken because of the service() method. Therefore, in the way the change is proposed, it doesn't fix the issue, but removes an existing performance optimi

Re: Incorrect hash and sig links

2022-01-20 Thread Valentin Kulichenko
Hi Mark, Thanks for letting us know. We will fix this. -Val On Thu, Jan 20, 2022 at 8:56 AM Mark Thomas wrote: > Ignite developers, > > I noticed that your download page is incorrectly linking to > dlcdn.apache.org for hashes and signatures. As per the release policy > [1], these links MUST po