Re: [VOTE] Release Apache Ignite 2.11.0 RC2

2021-09-13 Thread Zhenya Stanilovsky
Thanks Maxim ! I tries to compare this ver with 2.10 (some performance tests with persistence and transactional\atomic payload) and seems all ok there. +1 from me.   > > >Dear Community, > > >The release candidate for the 2.11 version is ready. > > >I have uploaded a release candidate to: >https

Re: Deprecating LOCAL cache

2021-09-13 Thread Ivan Daschinsky
Hi, Maxim. And what is the plan of removing this functionality? And I also have some questions regarding deprecation in binary protocol Currently thin client binary protocol 1. Does support LOCAL caches 2. Does not support node filters. I can hardly imagine the usefulness of this feature on thin

Re: [VOTE] Release Apache Ignite 2.11.0 RC2

2021-09-13 Thread Pavel Tupitsyn
+1 Downloaded binary packages, started a cluster with a few nodes, tested new .NET examples. On Mon, Sep 13, 2021 at 11:21 AM Zhenya Stanilovsky wrote: > > > Thanks Maxim ! > I tries to compare this ver with 2.10 (some performance tests with > persistence and transactional\atomic payload) and s

Re: [VOTE] Allow or prohibit usages of the Guava library methods

2021-09-13 Thread Alexander Polovtcev
The voting has finished and the results are the following: [+1 Allow]: 1 [-1 Prohibit]: 5 Therefore it is decided to prohibit using Guava in Ignite 3 codebase, even if it is included as a direct dependency. I will add this to the Ignite 3 code style document (or similar) as soon as it is availabl

Re: [VOTE] Allow or prohibit usages of the Guava library methods

2021-09-13 Thread Petr Ivanov
Should we somehow restrict using this dependency in the project with Maven (or any other tools)? > On 13 Sep 2021, at 12:47, Alexander Polovtcev wrote: > > The voting has finished and the results are the following: > > [+1 Allow]: 1 > [-1 Prohibit]: 5 > > Therefore it is decided to prohibit u

Re: Deprecating LOCAL cache

2021-09-13 Thread Maxim Muzafarov
Ivan, I don't think we can remove LOCAL caches at the nearest time, so there is no plan for that. I can only imagine a single release that will contain all the breaking changes we want to apply in 2.x version. My point here is only about deprecation: - there are a lot of motivation points to remo

Re: Deprecating LOCAL cache

2021-09-13 Thread Ivan Daschinsky
I personally support deprecation, but we should at least have a plan. I suppose that putting annotations and removing documentation are not enough. пн, 13 сент. 2021 г. в 13:22, Maxim Muzafarov : > Ivan, > > I don't think we can remove LOCAL caches at the nearest time, so there > is no plan for

Re: Tuple equality in Ignite 3.x

2021-09-13 Thread Pavel Tupitsyn
Let's clarify column order and nullable columns handling. Our current API (Table, KvView) does not rely on column order in user-provided tuples. Therefore, two tuples with the same set of columns and equal values for every column may be considered equal. Tuple a = Tuple.create().set("name", "x").

Re: Tuple equality in Ignite 3.x

2021-09-13 Thread Andrey Mashenkov
Pavel, 1. Comparator introduces an ordered relation, but we need only equality (e.g. Objects.deepEquals). Ok, we can implement some orders for basic types adding complexity to cast and compare for all the values. 2. Hashcode calculation will require iterating over all the columns. Most likely ite

Re: Ignite Website UI and UX improvements

2021-09-13 Thread Denis Magda
Hi Saikat, Thanks for the suggestions. I'll pass them over to the design team. - Denis On Sun, Sep 12, 2021 at 10:43 AM Saikat Maitra wrote: > Hi Denis, Kseniya > > Thank you for leading the effort in designing and revamping the website. > > I wanted to share a few thoughts and ideas: > 1. W

Re: Tuple equality in Ignite 3.x

2021-09-13 Thread Andrey Mashenkov
Maybe we can return user objects in the result? I suggest replacing Set/Map with a List in InternalTable because we don't need them actually. Uniqueness is not the issue. We can iterate over Set/Map, which we got from a user, and enumerate the keys, then put user objects back to the result based o

Re: [VOTE] Allow or prohibit usages of the Guava library methods

2021-09-13 Thread Alexander Polovtcev
Petr, In the original thread we decided to add Guava as an explicit dependency in order to avoid dependency conflicts and to possibly shade it later. If there exists a check that will scan for Guava imports in Ignite code, that would probably be nice to have. On Mon, Sep 13, 2021 at 12:54 PM Petr

Re: [VOTE] Allow or prohibit usages of the Guava library methods

2021-09-13 Thread Petr Ivanov
We can run dependency:tree command and search for guava in transitive dependencies. Can you describe how it should be and where should this explicit dependency reside? > On 13 Sep 2021, at 17:15, Alexander Polovtcev wrote: > > Petr, > In the original thread we decided to add Guava as an explic

Re: [VOTE] Allow or prohibit usages of the Guava library methods

2021-09-13 Thread Alexander Polovtcev
> We can run dependency:tree command and search for guava in transitive dependencies. It is ok to have Guava as a transitive dependency (at least for now), so this step is not necessary. > Can you describe how it should be and where should this explicit dependency reside? As I see it, we will de

Re: Ban Java Streams usage in Ignite 3 code

2021-09-13 Thread Pavel Tupitsyn
Konstantin, > The performance penalty ... is 25%, not 8 times I'm sure you are using a different JDK, I'm on OpenJDK 11 as listed in the gist. Ivan, > rewrite it using BlackHole I did, updated the gist, the results are the same. On Thu, Sep 9, 2021 at 11:12 AM Ilya Kasnacheev wrote: > Hello

Re: Ban Java Streams usage in Ignite 3 code

2021-09-13 Thread Pavel Tupitsyn
To summarize: We don't ban streams but use them with caution, avoid on hot paths. The decision is up to the author and reviewer. Thanks for the discussion! On Mon, Sep 13, 2021 at 10:25 PM Pavel Tupitsyn wrote: > Konstantin, > > > The performance penalty ... is 25%, not 8 times > I'm sure you a

Re: [VOTE] Release Apache Ignite 2.11.0 RC2

2021-09-13 Thread 18624049226
Should the following two issue be merged into the ignite-2.11 branch? https://issues.apache.org/jira/browse/IGNITE-14404 https://issues.apache.org/jira/browse/IGNITE-15503 在 2021/9/13 17:12, Pavel Tupitsyn 写道: +1 Downloaded binary packages, started a cluster with a few nodes, tested new .NET