Hi Val,
This is a very good point.
I've looked around blogs, docs, and system APIs, and updated the IEP
accordingly:
For Ignite.NET I propose NOT to add sync methods when the actual
implementation is async:
- It is easy to consume async APIs in C# with async/await keywords (added
in 2012 and wide
Folks,
The patch [1] for the azure module seems to be ready for review,
however, there are still some questions that exist:
- Do we have a technical account in azure to test the moude on TC?
Manual testing for such changes is really annoying.
- Is there any reason to add these changes to the main
I would argue that the module Co exists with the other IP discovery modules
(such as GCP and AWS), which are part of core.
In terms of tests, the azure module has exactly the same type of tests as
the other two modules mentioned above.
On Fri, 3 Sep 2021, 17:54 Maxim Muzafarov, wrote:
> Folks,
Disagree to exclude this contribution from the 2.11 release. As Atri
explained, its implementation and testing approach is identical to the AWS,
GCP and Kubernetes IP finders.
If we want to move the modules to extensions and improve the testing
approach, then it needs to be done for all similar com
It was extensively tested by myself (running the tests on an actual Azure
account and running an Ignite cluster using an Azure account) and Ilya
(thanks Ilya!) prior to merging it in the core
On Fri, 3 Sep 2021, 18:50 Denis Magda, wrote:
> Disagree to exclude this contribution from the 2.11 rele
Folks,
The GCP and AWS should also be moved to extensions, but this is a
discussion for another topic.
I trust you all :-)
But who can validate the patch [1]? This is a bad practice that only a
few members be able to test the code.
[1] https://issues.apache.org/jira/browse/IGNITE-15388
On Fri,
Folks,
I'd like to mention that currently THE BUILD is broken not only for
the release branch but for the master also.
It's true that the TC has cached the artefacts, so we don't see broken
builds but how to build the Apache Ignite locally? I'm not able to do
so.
On Fri, 3 Sept 2021 at 16:59, Max
I am not sure why is it can be tested by few members?
Anyone with azure account should be able to test it
On Fri, 3 Sep 2021, 19:29 Maxim Muzafarov, wrote:
> Folks,
>
> The GCP and AWS should also be moved to extensions, but this is a
> discussion for another topic.
>
> I trust you all :-)
> Bu
Atri.
Right now code can’t be tested because it doesn’t compile.
> 3 сент. 2021 г., в 17:42, Atri Sharma написал(а):
>
> I am not sure why is it can be tested by few members?
>
> Anyone with azure account should be able to test it
>
> On Fri, 3 Sep 2021, 19:29 Maxim Muzafarov, wrote:
>
>> F
Atri,
> Anyone with azure account should be able to test it
I checked the test included in the module with an Azure account (as I
mentioned in Jira), it passes successfully. But I'm not sure if this
is enough.
пт, 3 сент. 2021 г. в 17:48, Nikolay Izhikov :
>
> Atri.
>
> Right now code can’t be t
Makes sense, thanks!
-Val
On Fri, Sep 3, 2021 at 2:00 AM Pavel Tupitsyn wrote:
> Hi Val,
>
> This is a very good point.
>
> I've looked around blogs, docs, and system APIs, and updated the IEP
> accordingly:
> For Ignite.NET I propose NOT to add sync methods when the actual
> implementation is
11 matches
Mail list logo
