Re: IGNITE-15256 request for review

2021-08-12 Thread Pavel Tupitsyn
Hi Ivan, Thank you for your contribution! Please see my comments in JIRA. On Wed, Aug 11, 2021 at 5:54 PM Mirza Aliev wrote: > Helo Ivan! Thank you for your effort! > > Here [1] you can find info about the process of contributing to Apache > Ignite. > As Krill said before, you need to get "gree

Re: IGNITE-15256 request for review

2021-08-12 Thread Ivan Fedorenkov
Thank you guys! чт, 12 авг. 2021 г. в 14:04, Pavel Tupitsyn : > Hi Ivan, > > Thank you for your contribution! > Please see my comments in JIRA. > > On Wed, Aug 11, 2021 at 5:54 PM Mirza Aliev wrote: > > > Helo Ivan! Thank you for your effort! > > > > Here [1] you can find info about the process

Re: [DISCUSSION] Allow use QuerySqlField.precision for varlen types

2021-08-12 Thread Maksim Timonin
Hi, Ivan! I agree about String. It looks like there is someone who just forgot to document it. But what about binary? H2 supports varbinary type (along with varchar). So I think we can easily support it. Also it will open the door to an improved inline size calculation for binary types the same

Re: [DISCUSSION] Allow use QuerySqlField.precision for varlen types

2021-08-12 Thread Ivan Daschinsky
Max, i've the same thoughts about varbinary. чт, 12 авг. 2021 г. в 18:27, Maksim Timonin : > Hi, Ivan! > > I agree about String. It looks like there is someone who just forgot to > document it. > > But what about binary? H2 supports varbinary type (along with varchar). So > I think we can easily

Re: [DISCUSSION] Allow use QuerySqlField.precision for varlen types

2021-08-12 Thread Maksim Timonin
Hi, Ivan! I prepared a ticket [1] for this patch, and got the TC bot visa. Could you please have a look at it? [1] https://issues.apache.org/jira/browse/IGNITE-15302 On Thu, Aug 12, 2021 at 8:52 PM Ivan Daschinsky wrote: > Max, i've the same thoughts about varbinary. > > чт, 12 авг. 2021 г. в