Hello!
As I understood, we don't try to solve the problem mentioned in the IEP:
there is unexpected behavior,
users should carefully read the docs to know about this, and so on.
A thread that executes an incorrect listener hung in any case,
and the suggested solution is to change the pool which ow
Andrey, I can't find any async methods,
can you please check if the changes are pushed?
On Tue, Mar 16, 2021 at 10:06 PM Andrey Mashenkov <
andrey.mashen...@gmail.com> wrote:
> Pavel, good point.
> Thanks. I've added async methods.
>
> On Fri, Mar 12, 2021 at 2:29 PM Pavel Tupitsyn
> wrote:
>
>
Pavel,
There are 2 PR's for the ticket[1] with two different APIs suggested.
Please, take a look at PR [2].
[1] https://issues.apache.org/jira/browse/IGNITE-14035
[2] https://github.com/apache/ignite-3/pull/69
On Wed, Mar 17, 2021 at 11:11 AM Pavel Tupitsyn
wrote:
> Andrey, I can't find any as
Denis,
> we don't try to solve the problem mentioned in the IEP
The problem: user code executes on striped pool (which causes issues)
The solution: don't execute user code on striped pool
I believe this solves the problem and removes any and all restrictions
for async listeners/continuations. Am
I see, thanks.
Let's discuss the return type - Future is not the one to use.
We should return CompletionStage, CompletableFuture, or introduce our own
interface.
We agreed on the last one (custom interface) for thin clients:
http://apache-ignite-developers.2346864.n4.nabble.com/IEP-51-Java-Thin-Cl
My initial confusion was due to I did not know the
TaskCompletionSource.SetResult() internally handles
SynchronizationContext captured before the async operation. I thought we
would have to do it in Ignite. Now I know that and have no problems with
the IEP.
ср, 17 мар. 2021 г. в 11:18, Pavel Tupit
Maksim,
Great summary!
+1 for versioning scheme.
However, deprecation rules can be possibly misleading.
I think that we should use 'since' as a mandatory annotation, that will mark
the release where the API can (not should) be changed, regardless of our
intention to modify it.
And add some ki
Nikolay Izhikov created IGNITE-14328:
Summary: .NET: Array of Collections can't be used as service
method parameters
Key: IGNITE-14328
URL: https://issues.apache.org/jira/browse/IGNITE-14328
Proje
Hi Nikolay! Can you do an additional review or can we merge?
15.03.2021, 08:48, "ткаленко кирилл" :
> Hi Nikolay! Can you do an additional review or can we merge?
>
> 05.03.2021, 16:33, "Nikolay Izhikov" :
>> Yes, definitely.
>>
>>> 5 марта 2021 г., в 16:31, ткаленко кирилл
>>> написал(а):
>>
Pavel, thank you for your answer.
Sorry, the previous version of IEP motivation highlighted what could be
wrong with user listeners,
so I thought that is the main problem.
I'm wondering why you suggest using ForkJoinPool.commonPool as the default
pool to run listeners?
ср, 17 мар. 2021 г. в 11:5
Denis,
Yes, I've updated the Motivation section, it really was a bit vague - thank
you.
> why you suggest using ForkJoinPool.commonPool as the default pool to run
listeners
- It is recommended to be used by default [1]
- There are no alternatives?
[1]
https://docs.oracle.com/javase/8/docs/api/j
Maxim,
I've prepared a blog post about Ignite.NET changes [1],
please link it in the main post.
[1] https://ptupitsyn.github.io/Whats-New-In-Ignite-Net-2.10/
On Tue, Mar 16, 2021 at 5:15 PM Maxim Muzafarov wrote:
> Denis,
>
>
> Thank you. I'll prepare a blog post notes for the major 2.10 featu
Anton Vinogradov created IGNITE-14329:
-
Summary: Set 2.9.1 as LATEST_2.9 and 2.10 as LATEST
Key: IGNITE-14329
URL: https://issues.apache.org/jira/browse/IGNITE-14329
Project: Ignite
Issue
Hi Valentine,
Hoping you are well.
Please let me know if the PR looks ok.
Regards,
Atri
On Thu, 11 Mar 2021, 12:09 Atri Sharma, wrote:
> Hi Val,
>
> Thanks for taking a look. I have updated the PR, please see and let me
> know your thoughts and feedback.
>
> Regards,
>
> Atri
>
> On Thu, Ma
Hello Pavel,
I took a look at your IEP and pool request. I have the following concerns.
First of all, this change breaks the contract of IgniteFuture#listen(lsnr)
/**
* Registers listener closure to be asynchronously notified whenever
future completes.
* Closure will be processed in
Pavel, I got it.
Thank you.
ср, 17 мар. 2021 г. в 13:11, Pavel Tupitsyn :
> Denis,
>
> Yes, I've updated the Motivation section, it really was a bit vague - thank
> you.
>
> > why you suggest using ForkJoinPool.commonPool as the default pool to run
> listeners
>
> - It is recommended to be used b
Well, the specified method already exists :)
/**
* Registers listener closure to be asynchronously notified whenever
future completes.
* Closure will be processed in specified executor.
*
* @param lsnr Listener closure to register. Cannot be {@code null}.
* @param exec
Hi,
I agree with Nikita, it would be a very simple way of getting feedback to
improve the documentation.
This tool in particular is quite easy to integrate into the online docs
template.
Best,
Mauricio
On Tue, Mar 16, 2021 at 4:46 PM Denis Magda wrote:
> Nikita, thanks for starting the conv
Andrey Mashenkov created IGNITE-14330:
-
Summary: Implement binary table views API.
Key: IGNITE-14330
URL: https://issues.apache.org/jira/browse/IGNITE-14330
Project: Ignite
Issue Type: Im
Slava,
Your suggestion is to keep things as is and discard the IEP, right?
> this can lead to significant overhead
Yes, there is some overhead, but the cost of accidentally starving the
striped pool is worse,
not to mention the deadlocks.
I believe that we should favor correctness over performa
Vladimir Pligin created IGNITE-14331:
Summary: Possible distributed race related to a data streamer
flushing leading to a thread being stuck forever trying to close the streamer
Key: IGNITE-14331
URL: https://
Kseniya Romanova created IGNITE-14332:
-
Summary: Update for event schedule page
Key: IGNITE-14332
URL: https://issues.apache.org/jira/browse/IGNITE-14332
Project: Ignite
Issue Type: Task
Hi Pavel,
Well, I think that the user should use the right API instead of introducing
uncontested overhead for everyone.
For instance, the code that is provided by IEP can changed as follows:
IgniteFuture fut = cache.putAsync(1, 1);
fut.listenAync(f -> {
// Executes on Striped pool and deadlo
> the user should use the right API
Not a good excuse really. We have a usability problem, you have to admit it.
"The brakes did not work on your car - too bad, you should have known that
on Sundays only your left foot is allowed on the pedal"
This particular use case is too intricate.
Even when
Hi Pavel,
> Not a good excuse really. We have a usability problem, you have to admit
it.
Fair enough. I agree that this is a usability issue, but I have doubts that
the proposed approach to overcome it is the best one.
> Documentation won't help - no one is going to read the Javadoc for a
trivial
Anton Vinogradov created IGNITE-14333:
-
Summary: Zookeeper uses kill -1
Key: IGNITE-14333
URL: https://issues.apache.org/jira/browse/IGNITE-14333
Project: Ignite
Issue Type: Sub-task
Denis,
I'd like to create a post on the blogs.apache.org news feed with the
2.10 release news. Do I need additional privileges to do this?
According to the wiki page [1] after login with my credentials, I
should see the `add post` button, however, I can't find it on the main
page. Am I missing s
Nikolay Izhikov created IGNITE-14334:
Summary: .NET: Thin client don't support ICollection parameters
Key: IGNITE-14334
URL: https://issues.apache.org/jira/browse/IGNITE-14334
Project: Ignite
Maxim,
Check one more time. The infra instruction that you shared says a
contributor needs to be in the Admin group in JIRA to get write access to
the blog. I've added you to the Admin group.
-
Denis
On Wed, Mar 17, 2021 at 12:00 PM Maxim Muzafarov wrote:
> Denis,
>
>
> I'd like to create a p
Denis,
I'm getting the following error while trying to create a new Weblog
> Sorry, the blog administrator has disabled creation of new blogs.
By the way, Nikita, Denis
Can you review my blog post, please?
https://github.com/Mmuzaf/mmuzaf.github.io/blob/main/_post/Release_Newsletter_210.md
On
Pavel,
I tried this:
@Test
public void test() throws Exception {
IgniteCache cache =
startGrid().getOrCreateCache("test_cache");
cache.putAsync(1, "one").listen(f -> cache.replace(1, "two"));
assertEquals("two", cache.get(1));
}
and this test is green.
I believe that an user can mak
Mikhail Petrov created IGNITE-14335:
---
Summary: Merge APIs of IgniteAuthenticationProcessor and
IgniteSecurity
Key: IGNITE-14335
URL: https://issues.apache.org/jira/browse/IGNITE-14335
Project: Ign
Hi Denis,
I think Pavel's main point is that behavior is unpredictable. For example,
AFAIK, putAsync can be executed in the main thread instead of the striped
pool thread if the operation is local. The listener can also be executed in
the main thread - this happens if the future is completed prior
Hi Atri,
Looks good to me, I've merged the changes. Please resolve the ticket.
-Val
On Wed, Mar 17, 2021 at 5:07 AM Atri Sharma wrote:
> Hi Valentine,
>
> Hoping you are well.
>
> Please let me know if the PR looks ok.
>
> Regards,
>
> Atri
>
>
> On Thu, 11 Mar 2021, 12:09 Atri Sharma, wrote:
Kseniya,
>From my point of view he contribute.html and CONTRIBUTING.md should be
the same with the reference to the wiki page How_to_Contribute_2021
describing all the additional details and common issues with the first
contributions.
I also think it would be better to create special dedicated pa
We implemented the ContinueWith() suggestion from Pavel, and it works well
so far in testing, though we do not have data to support if there is or is
not a performance penalty in our use case..
To lend another vote to the 'Don't do continuations on the striped thread
pool' line of thinking: Deadlo
Maxim,
I had to grant you admin access in the blogging settings. No you should be
able to create an article and invite other members (log in with your apache
ID): https://blogs.apache.org/roller-ui/authoring/members!save.rol
Like the blog. (if you haven't done this yet, I'm encouraging you to wor
Hi Igniters,
I've detected some new issue on TeamCity to be handled. You are more than
welcomed to help.
If your changes can lead to this failure(s): We're grateful that you were a
volunteer to make the contribution to this project, but things change and you
may no longer be able to finalize
Hi Igniters,
I've detected some new issue on TeamCity to be handled. You are more than
welcomed to help.
*New test failure in master
IgniteLocalWalSizeTest.testLocalSegmentSizesArchiveOnly
https://ci.ignite.apache.org/project.html?projectId=IgniteTests24Java8&testNameId=59301762291918696
In my mind CONTRIBUTING.md is a nice and quite common starting point
for contributors. Other projects use it as well [1], [2]. Also GitHub
treats it somehow specially, I recall it suggested me to make familiar
with CONTRIBUTING.md of some repo.
[1] https://github.com/hazelcast/hazelcast/blob/maste
Thank you so much!
On Thu, Mar 18, 2021 at 3:01 AM Valentin Kulichenko
wrote:
>
> Hi Atri,
>
> Looks good to me, I've merged the changes. Please resolve the ticket.
>
> -Val
>
> On Wed, Mar 17, 2021 at 5:07 AM Atri Sharma wrote:
>
> > Hi Valentine,
> >
> > Hoping you are well.
> >
> > Please let
41 matches
Mail list logo
