Re: Code inspection

2018-12-19 Thread Petr Ivanov
Investigating problem, stand by. > On 18 Dec 2018, at 19:41, Dmitriy Pavlov wrote: > > Both patches were applied. Maxim, thank you! > > What about 1. An `Unexpected error during build messages processing in > TeamCity`, what can we do as the next step to fix it? > > Sincerely, > Dmitriy Pavlo

Re: Async debugging in IDEA

2018-12-19 Thread Ivan Bessonov
Hi guys, First of all, considering cons: I couldn't find a way to see the whole stacktrace from worker in "Frames" window. Maybe this'll be fixed in future versions of IDEA. Workaround it to use "Threads" tab of the debugger. It's not that comfortable but does its job pretty well. > Are there any

Re: Is it time to move forward to JUnit4 (5)?

2018-12-19 Thread Павлухин Иван
Hi Oleg, I have not quite understood who is going to call (from standpoint of test framework) beforeTestsStarted, beforeTest, afterTest, afterTestsStarted methods? вт, 18 дек. 2018 г. в 23:31, oignatenko : > > Hi Ivan, > > To answer your last question, yes, all the tests are to be marked with @Tes

[jira] [Created] (IGNITE-10737) Enable inspection Collections.sort(..) can be replaced with list.sort(..)

2018-12-19 Thread Maxim Muzafarov (JIRA)
Maxim Muzafarov created IGNITE-10737: Summary: Enable inspection Collections.sort(..) can be replaced with list.sort(..) Key: IGNITE-10737 URL: https://issues.apache.org/jira/browse/IGNITE-10737 P

Re: Critical worker threads liveness checking drawbacks

2018-12-19 Thread Alexey Goncharuk
Folks, why did not we include IGNITE-10003 to ignite-2.7 release scope? This causes an Ignite node to be stopped by default when checkpoint read lock acquire times out. I expect a lot of Ignite 2.7 users will be affected by this mistake. We should at least update the documentation and make users a

Re: Critical worker threads liveness checking drawbacks

2018-12-19 Thread Nikolay Izhikov
Hello, Alexey. No, we don't include this ticket to 2.7. Should we? ср, 19 дек. 2018 г. в 12:55, Alexey Goncharuk : > Folks, why did not we include IGNITE-10003 to ignite-2.7 release scope? > This causes an Ignite node to be stopped by default when checkpoint read > lock acquire times out. I expe

Re: Is it time to move forward to JUnit4 (5)?

2018-12-19 Thread Dmitriy Pavlov
Hi Igniters, I've tried yesterday to find any of @Ignore d tests with a link to the issue in its value on TeamCity, but I did not manage to. Do you know if JUnit Ignored tests are completely invisible in the TC and its REST? I've also tried to google it, but not found anything yet. I remember th

Re: Critical worker threads liveness checking drawbacks

2018-12-19 Thread Dmitriy Pavlov
Hi, Sorry for being too formal here, but IGNITE-10003 is in progress. Also, I've tried to find anything related to it in the list. So according to the list, no one was asking to include. Sincerely, Dmitriy Pavlov ср, 19 дек. 2018 г. в 13:24,

[jira] [Created] (IGNITE-10738) MVCC: Enable page evictions for MVCC caches with in-memory mode

2018-12-19 Thread Roman Kondakov (JIRA)
Roman Kondakov created IGNITE-10738: --- Summary: MVCC: Enable page evictions for MVCC caches with in-memory mode Key: IGNITE-10738 URL: https://issues.apache.org/jira/browse/IGNITE-10738 Project: Igni

[jira] [Created] (IGNITE-10739) get rid of using JUnit 3 API in IgniteConfigVariationsAbstractTest

2018-12-19 Thread Oleg Ignatenko (JIRA)
Oleg Ignatenko created IGNITE-10739: --- Summary: get rid of using JUnit 3 API in IgniteConfigVariationsAbstractTest Key: IGNITE-10739 URL: https://issues.apache.org/jira/browse/IGNITE-10739 Project: I

Re: Is it time to move forward to JUnit4 (5)?

2018-12-19 Thread oignatenko
Hi Ivan, These methods are called from within GridAbstractTest in exactly same sequence as they were called in the past from JUnit 3 TestCase class. This is by the way the reason why these methods should not be annotated with Before* / After* - because if someone does that then method will be cal

Re: Is it time to move forward to JUnit4 (5)?

2018-12-19 Thread Павлухин Иван
Dmitriy, Thank you for noticing! It seems we have a problem here. When junit4 test is called from junit3 suite (with help of JUnit4TestAdapter) such tests is skipped silently. It seems that we cannot use @Ignore everywhere yet. ср, 19 дек. 2018 г. в 15:09, oignatenko : > > Hi Ivan, > > These metho

Re: Suggestion to improve deadlock detection

2018-12-19 Thread Павлухин Иван
Igor, I see your points. And I agree to start with "lightweight implementation". Today we have 2PL and there is no activity on implementing rollback to savepoint. And if we do it in the future we will have to return to the subject of deadlock detection anyway. I will proceed with "forward-only" a

Re: Service grid redesign

2018-12-19 Thread Denis Mekhanikov
Slava, I think, it's better to replace word "Change" with "Request". Nik, We have IgniteServiceProcessor and GridServiceProcessor with singular "Service", ServicesDeploymentManager and ServicesDeploymentTask with plural "Services" for some reason. So, you need to remember, where Service and where

[jira] [Created] (IGNITE-10740) Add documentation for IGNITE_DISABLE_TRIGGERING_CACHE_INTERCEPTOR_ON_CONFLICT

2018-12-19 Thread Sergey Antonov (JIRA)
Sergey Antonov created IGNITE-10740: --- Summary: Add documentation for IGNITE_DISABLE_TRIGGERING_CACHE_INTERCEPTOR_ON_CONFLICT Key: IGNITE-10740 URL: https://issues.apache.org/jira/browse/IGNITE-10740

[jira] [Created] (IGNITE-10741) MVCC: Document disabled page evictions for in-memory MVCC caches.

2018-12-19 Thread Roman Kondakov (JIRA)
Roman Kondakov created IGNITE-10741: --- Summary: MVCC: Document disabled page evictions for in-memory MVCC caches. Key: IGNITE-10741 URL: https://issues.apache.org/jira/browse/IGNITE-10741 Project: Ig

RE: Asynchronous index rebuild

2018-12-19 Thread Stanislav Lukyanov
Hi Vladimir, Thanks for this summary! Why the third option and not the second? The process of join-leave-build indexes-rejoin sounds kind of heavy. Topology changes are complex because of PME, so I think the less PME – the better. Rejoin to build indexes also means that not having indexes for

Re: Service grid redesign

2018-12-19 Thread Vyacheslav Daradur
> We have IgniteServiceProcessor and GridServiceProcessor with singular > "Service" Maybe we should rename new 'IgniteServiceProcessor' to 'IgniteServicesProcessor'? > And ServiceSingleDeploymentsResults name doesn't make sense to me. > "Single deployments" doesn't sound right. 'Single' means '

Re: Service grid redesign

2018-12-19 Thread Nikolay Izhikov
Denis, I don't think that differences with your and my naming is huge :) And, it's definetely a matter of taste. If there is no any other issues with PR let's rename and move on! :) ср, 19 дек. 2018 г. в 17:32, Vyacheslav Daradur : > > We have IgniteServiceProcessor and GridServiceProcessor wit

Re: Pre-touch for Ignite off-heap memory

2018-12-19 Thread Stanislav Lukyanov
Well, I'm not saying "we need all three features all the time", I'm just summarizing why someone would use pre-touch. And having c) is better than having none. Also, we do get a) and b) as well, the timing is just a bit different. But I find it better to fail at the time of dynamic cache creation

[jira] [Created] (IGNITE-10742) Replace java.io.Console to GridConsole

2018-12-19 Thread Sergey Antonov (JIRA)
Sergey Antonov created IGNITE-10742: --- Summary: Replace java.io.Console to GridConsole Key: IGNITE-10742 URL: https://issues.apache.org/jira/browse/IGNITE-10742 Project: Ignite Issue Type:

Re: Service grid redesign

2018-12-19 Thread Denis Mekhanikov
Guys, I finished my code review. The pool request looks good to me. Does anybody else want to look at the changes? There are a few points, that we didn't meet an agreement on, though they don't affect the behaviour in any way: - *Class naming. * See the discussion above. - *Unnecessary tas

Hibernate 5.3 merged!

2018-12-19 Thread Ilya Kasnacheev
Hello! I am proud to announce that I have just merged Hibernate 5.3 module, courtesy Scott Feldstein. There were also important fixes which should make TC greener than ever. Since this is a large patch there might be rough edges, please notify me if anything went awry, I will try to follow it up

Re: Hibernate 5.3 merged!

2018-12-19 Thread Павлухин Иван
Good news! I also believe that a lot of users will be happy once it is released. Cheers! By the way, I noticed that the latest Hibernate version is 5.4. It is compatible with 5.3? Should it be somehow addressed by Ignite developers? ср, 19 дек. 2018 г. в 19:09, Ilya Kasnacheev : > > Hello! > > I

Re: Hibernate 5.3 merged!

2018-12-19 Thread Ilya Kasnacheev
Hello! I have just checked, and it looks like hibernate-5.3 module works correctly with Hibernate 5.4.0.Final! It builds without errors and all tests pass. So maybe we can rebrand it as hibernate-5.3+ for the duration. Regards, -- Ilya Kasnacheev ср, 19 дек. 2018 г. в 19:53, Павлухин Иван :

Re: Dealing with changing class definitions in Ignite

2018-12-19 Thread Ilya Kasnacheev
Hello! I have found that you can avoid compute job type incompatibility problem (please see history below) by setting .setMarshaller(new OptimizedMarshaller()) in your Ignite configuration on all nodes. However, it is not clear at all why this is needed. Anybody can help? Why co

[jira] [Created] (IGNITE-10743) MVCC: Mute flaky mvcc tests

2018-12-19 Thread Roman Kondakov (JIRA)
Roman Kondakov created IGNITE-10743: --- Summary: MVCC: Mute flaky mvcc tests Key: IGNITE-10743 URL: https://issues.apache.org/jira/browse/IGNITE-10743 Project: Ignite Issue Type: Task

RE: Volunteer needed: AWS Elastic Load Balancer IP Findersimplemented

2018-12-19 Thread Stanislav Lukyanov
Hi, Regarding the name - a not-so-good name isn’t always a sufficient justification for renaming. Public products such as Ignite have to also take into account convenience for existing users. Even in 3.0 when we technically can break compatibility I would avoid breaking it just to rename “ELB”

[jira] [Created] (IGNITE-10744) class org.apache.ignite.IgniteCheckedException: Failed to read WAL record at position: 5237375 size: -1

2018-12-19 Thread ARomantsov (JIRA)
ARomantsov created IGNITE-10744: --- Summary: class org.apache.ignite.IgniteCheckedException: Failed to read WAL record at position: 5237375 size: -1 Key: IGNITE-10744 URL: https://issues.apache.org/jira/browse/IGNITE-

[jira] [Created] (IGNITE-10745) SQL: jdbc metadata's getColumns returns wrong value for "ORDINAL_POSITION"

2018-12-19 Thread Pavel Kuznetsov (JIRA)
Pavel Kuznetsov created IGNITE-10745: Summary: SQL: jdbc metadata's getColumns returns wrong value for "ORDINAL_POSITION" Key: IGNITE-10745 URL: https://issues.apache.org/jira/browse/IGNITE-10745

Re: Hibernate 5.3 merged!

2018-12-19 Thread Scott Feldstein
Hi Ilya, that’s great news! What’s the likelihood of pushing the artifacts to a public maven repo along with the other ignite artifacts? Are we constrained by the LGPL2 license? If so, I wonder how spring works around that with their jpa impl? Scott On Wed, Dec 19, 2018 at 09:03 Ilya Kasnacheev

Re: Service grid redesign

2018-12-19 Thread Nikolay Izhikov
Denis, great news! Alexey, Vova, Yakov, do you want to take a look at this PR? В Ср, 19/12/2018 в 18:47 +0300, Denis Mekhanikov пишет: > Guys, > > I finished my code review. The pool request looks good to me. > > Does anybody else want to look at the changes? > There are a few points, that we