Re: IGNITE-3422 - ready for review

2017-03-01 Thread Vyacheslav Daradur
Guys, any thoughts? 2017-02-23 13:22 GMT+03:00 Vyacheslav Daradur : > I think it makes a sense to define factory in IgniteConfiguration, as the > Map which will be ised when deserializing. > > Interface example: > > public intterface InstanceFactory { > newInstance(Class clazz, BinaryReader r

PR IGNITE-1094 Ignite.createCache(CacheConfiguration) hangs if some exception occurs during cache initialization

2017-03-01 Thread ALEKSEY KUZNETSOV
Plz, review my changes https://issues.apache.org/jira/browse/IGNITE-1094 https://github.com/apache/ignite/pull/1581 -- *Best Regards,* *Kuznetsov Aleksey*

Re: Renaming TcpDiscoverySpi.heartbeatsFrequency to TcpDiscoverySpi.metricsUpdateFrequency

2017-03-01 Thread Yakov Zhdanov
I think we should not rename this, but properly document the behavior and all the relationships. --Yakov 2017-02-28 20:40 GMT+03:00 Dani Traphagen : > I had this thought when exploring this parameter at first and only was able > to change my understanding when evaluating it more deeply in the so

Re: Locking of partition with affinityRun/affinityCall

2017-03-01 Thread Vladimir Ozerov
I do not like the change because it is too verbose and adds no useful information for users. Moreover, normally users have no idea what "partition eviction" means. Let's simply write "Partition's data is guaranteed to be available on the node while job is being executed". This should be enough. On

Re: PR IGNITE-1094 Ignite.createCache(CacheConfiguration) hangs if some exception occurs during cache initialization

2017-03-01 Thread Yakov Zhdanov
Alexey, I will take a look at this in couple of days. --Yakov 2017-03-01 11:25 GMT+03:00 ALEKSEY KUZNETSOV : > Plz, review my changes > https://issues.apache.org/jira/browse/IGNITE-1094 > > https://github.com/apache/ignite/pull/1581 > -- > > *Best Regards,* > > *Kuznetsov Aleksey* >

JIRA ticket

2017-03-01 Thread Seliverstov Igor
Hi guys! Doesn't anybody mind if I take IGNITE-4681 ticket? Regards, Igor

[GitHub] ignite pull request #1535: IGNITE-4694 Add tests to check there are no memor...

2017-03-01 Thread gvvinblade
Github user gvvinblade closed the pull request at: https://github.com/apache/ignite/pull/1535 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

Re: JIRA ticket

2017-03-01 Thread Yakov Zhdanov
Igor, please go ahead. --Yakov 2017-03-01 12:58 GMT+03:00 Seliverstov Igor : > Hi guys! > > Doesn't anybody mind if I take IGNITE-4681 ticket? > > Regards, > Igor >

Re: JIRA ticket

2017-03-01 Thread Vladimir Ozerov
Igor, Please consider throwing away *startTime() *and *duration() *from future interface. These two methods are not need in 99% cases, but consume memory. They should not belong to future. On Wed, Mar 1, 2017 at 2:22 PM, Yakov Zhdanov wrote: > Igor, please go ahead. > > --Yakov > > 2017-03-01 1

Re: IGNITE-4713 : refactoring of GridFinishedFuture and GridFutureAdapter

2017-03-01 Thread Александр Меньшиков
First of all I want to replace the "byte resFlag" on the "bool haveResult" only for aesthetic reasons. I think that use a byte as a boolean flag looks like C in 1983. And constructions like return haveResult ? (R)res : null; more readable unlike return resFlag == RES ? (R)res : null; because yo

[GitHub] ignite pull request #1582: ignite-3477-index2 SQL inline indexes (simple typ...

2017-03-01 Thread kdudkov
GitHub user kdudkov opened a pull request: https://github.com/apache/ignite/pull/1582 ignite-3477-index2 SQL inline indexes (simple types, Strings, Bytes) You can merge this pull request into a Git repository by running: $ git pull https://github.com/gridgain/apache-ignite ign

[GitHub] ignite pull request #1555: ignite-3477-h2bench

2017-03-01 Thread kdudkov
Github user kdudkov closed the pull request at: https://github.com/apache/ignite/pull/1555 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is en

Re: Remove CacheAtomicWriteOrderMode.CLOCK mode.

2017-03-01 Thread Kozlov Maxim
Andrey, ok. Also remove in the modules/platform/dotnet CacheAtomicWriteOrderMode.cs? Rename classes: GridCacheAtomicNearCacheSelfTest.startGrids -> GridCacheAtomicNearCacheSelfTest.startGridsLocal (commit) IgniteCacheAtomicPrimaryWriteOrderWithStoreInvokeTest -> IgniteCacheWithStoreInvokeTest

Re: IGNITE-13

2017-03-01 Thread Вадим Опольский
Hi Valentin! Thank you for comments. There is a new method which writes directly to BinaryOutputStream instead of intermediate array. https://github.com/javaller/MyBenchmark/blob/master/src/ main/java/org/sample/BinaryUtilsNew.java There is benchmark. https://github.com/javaller/MyBenchmark/blob

[GitHub] ignite pull request #1451: GridGain 1.7.7

2017-03-01 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/ignite/pull/1451 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is ena

[GitHub] ignite pull request #1580: GridGain 1.9.1

2017-03-01 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/ignite/pull/1580 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is ena

[GitHub] ignite pull request #1569: IGNITE-4742 IgniteCacheUpdateSqlQuerySelfTest.tes...

2017-03-01 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/ignite/pull/1569 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is ena

[GitHub] ignite pull request #1554: IGNITE-4409 UUID literals handling.

2017-03-01 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/ignite/pull/1554 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is ena

[GitHub] ignite pull request #1437: IGNITE-4550: Move service deployment to certain t...

2017-03-01 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/ignite/pull/1437 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is ena

[GitHub] ignite pull request #1568: IGNITE-4741 JDBC DML streaming test fix

2017-03-01 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/ignite/pull/1568 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is ena

[GitHub] ignite pull request #1553: IGNITE-4169 Streamed SQL INSERTs

2017-03-01 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/ignite/pull/1553 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is ena

[GitHub] ignite pull request #1400: IGNITE-1.8.3

2017-03-01 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/ignite/pull/1400 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is ena

[GitHub] ignite pull request #1390: IGNITE-4458 Hadoop: striped shuffle mode must be ...

2017-03-01 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/ignite/pull/1390 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is ena

Re: Same Affinity For Same Key On All Caches

2017-03-01 Thread Andrey Mashenkov
Crossposting to dev list. I've made a test. It looks ok for Rendevouz A, partition distribution for caches with similar settings and same Rendevouz AF keep same. But FairAF partition distribution can differed for two caches that one was created before and second - after rebalancing. So, collocat

Re: REVIEW IGNITE-2552 EvictionPolicies refactored, logic changed

2017-03-01 Thread Andrey Gura
Hi, Aleksey! Thank you for contribution! I've reviewed your changes and have some comments (mostly cosmetic). Could you please fix this comment? See review in Upsource for details. On Tue, Feb 28, 2017 at 2:17 PM, ALEKSEY KUZNETSOV wrote: > Plz, review my PR : > http://reviews.ignite.apache.org

Re: Remove CacheAtomicWriteOrderMode.CLOCK mode.

2017-03-01 Thread Andrey Gura
Maxim, I think that during renaming we should not lose "Atomic" prefix. On Wed, Mar 1, 2017 at 5:16 PM, Kozlov Maxim wrote: > Andrey, ok. > > Also remove in the modules/platform/dotnet CacheAtomicWriteOrderMode.cs? > > Rename classes: > > GridCacheAtomicNearCacheSelfTest.startGrids -> > GridCa

Re: Remove CacheAtomicWriteOrderMode.CLOCK mode.

2017-03-01 Thread Kozlov Maxim
Ok. What do you say for the rest? > 1 марта 2017 г., в 18:15, Andrey Gura написал(а): > > Maxim, > > I think that during renaming we should not lose "Atomic" prefix. > > > On Wed, Mar 1, 2017 at 5:16 PM, Kozlov Maxim wrote: >> Andrey, ok. >> >> Also remove in the modules/platform/dotnet Cac

Re: Remove CacheAtomicWriteOrderMode.CLOCK mode.

2017-03-01 Thread Andrey Gura
I think that it is ok. On Wed, Mar 1, 2017 at 6:34 PM, Kozlov Maxim wrote: > Ok. What do you say for the rest? > >> 1 марта 2017 г., в 18:15, Andrey Gura написал(а): >> >> Maxim, >> >> I think that during renaming we should not lose "Atomic" prefix. >> >> >> On Wed, Mar 1, 2017 at 5:16 PM, Kozlo

[GitHub] ignite pull request #1583: Ignite 1.9.1 #2

2017-03-01 Thread avinogradovgg
GitHub user avinogradovgg opened a pull request: https://github.com/apache/ignite/pull/1583 Ignite 1.9.1 #2 You can merge this pull request into a Git repository by running: $ git pull https://github.com/gridgain/apache-ignite ignite-1.9.1 Alternatively you can review and app

[GitHub] ignite pull request #1548: IGNITE-4611

2017-03-01 Thread daradurvs
Github user daradurvs closed the pull request at: https://github.com/apache/ignite/pull/1548 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] ignite pull request #1551: IGNITE-4611 for merge in 2.0

2017-03-01 Thread daradurvs
Github user daradurvs closed the pull request at: https://github.com/apache/ignite/pull/1551 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] ignite pull request #1584: IGNITE-4681

2017-03-01 Thread gvvinblade
GitHub user gvvinblade opened a pull request: https://github.com/apache/ignite/pull/1584 IGNITE-4681 You can merge this pull request into a Git repository by running: $ git pull https://github.com/gridgain/apache-ignite ignite-4681 Alternatively you can review and apply these

[GitHub] ignite pull request #1582: ignite-3477-index2 SQL inline indexes (simple typ...

2017-03-01 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/ignite/pull/1582 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is ena

Re: IGNITE-4758 - introducing cache memory policies

2017-03-01 Thread Dmitriy Setrakyan
When 2 caches share the same memory policy, does it mean that they are using the same Page Memory offheap space? On Tue, Feb 28, 2017 at 11:49 PM, Sergey Chugunov wrote: > Dmitriy, > > Correct, cache configuration may contain a name of memory policy to use for > this cache. > If memory policy is

Re: Locking of partition with affinityRun/affinityCall

2017-03-01 Thread Denis Magda
I’ve reworked the doc removing “migration” mentioning at all that caused the confusion. Merged my changes: * It's guaranteed that the data of the whole partition, the affinity key belongs to, * will present on the destination node throughout the job execution. Taras, please close your pull-requ

Re: Hibernate OGM for Ignite. I need a help with documentation

2017-03-01 Thread Victor Z
Hello! I hope so, but I don't know for sure. 2017-02-28 22:14 GMT+03:00 Denis Magda : > Hi Victor, > > Looks like your contribution was accepted and will be rolled out as a part > of the next release: > https://github.com/hibernate/hibernate-ogm/labels/Next%20release > > Is it so? Do you know

Re: Hibernate OGM for Ignite. I need a help with documentation

2017-03-01 Thread Dmitriy Setrakyan
Thanks Victor! Definitely a very important contribution for the Apache Ignite project. On Wed, Mar 1, 2017 at 1:24 PM, Victor Z wrote: > I made a separate repository only for Ignite module. > https://github.com/Z-z-z-z/hibernate-ogm-ignite > It may be useful if somebody wants to try Hibernate OG

Re: Hibernate OGM for Ignite. I need a help with documentation

2017-03-01 Thread Victor Z
I made a separate repository only for Ignite module. https://github.com/Z-z-z-z/hibernate-ogm-ignite It may be useful if somebody wants to try Hibernate OGM with Ignite while it is not in Hibernate OGM distribution. 2017-03-02 0:15 GMT+03:00 Victor Z : > Hello! > > I hope so, but I don't know fo

Re: [VOTE] Apache Ignite 1.9.0 RC1

2017-03-01 Thread Valentin Kulichenko
-1 Building with 'mvn clean package -DskipTests' under JDK8 fails with the error below. JDK7 is fine, though. [INFO] [INFO] BUILD FAILURE [INFO] [INF

Re: Hibernate OGM for Ignite. I need a help with documentation

2017-03-01 Thread Dmitriy Setrakyan
By the way, Victor, it would be great if you could write a blog describing how to the Ignite OGM integration, so the community could get easily started with it. On Wed, Mar 1, 2017 at 1:24 PM, Victor Z wrote: > I made a separate repository only for Ignite module. > https://github.com/Z-z-z-z/hib

Re: Renaming TcpDiscoverySpi.heartbeatsFrequency to TcpDiscoverySpi.metricsUpdateFrequency

2017-03-01 Thread Denis Magda
Yasha, Is there any other reason rather than compatibility that prevents us from both improving documentation and renaming the parameter? — Denis > On Mar 1, 2017, at 1:13 AM, Yakov Zhdanov wrote: > > I think we should not rename this, but properly document the behavior and > all the relation

[jira] [Created] (IGNITE-4764) Web console: Correctly handle cache removing for cache checlpoint SPI

2017-03-01 Thread Vasiliy Sisko (JIRA)
Vasiliy Sisko created IGNITE-4764: - Summary: Web console: Correctly handle cache removing for cache checlpoint SPI Key: IGNITE-4764 URL: https://issues.apache.org/jira/browse/IGNITE-4764 Project: Igni

Re: [VOTE] Apache Ignite 1.9.0 RC1

2017-03-01 Thread Denis Magda
Getting absolutely the same exception under JDK 8. — Denis > On Mar 1, 2017, at 3:12 PM, Valentin Kulichenko > wrote: > > -1 > > Building with 'mvn clean package -DskipTests' under JDK8 fails with the > error below. JDK7 is fine, though. > > [INFO] ---

Re: Renaming TcpDiscoverySpi.heartbeatsFrequency to TcpDiscoverySpi.metricsUpdateFrequency

2017-03-01 Thread Yakov Zhdanov
I don't think new name makes things better. Btw, what if we remove metrics from heartbeats at all and make metrics local and allow aggregations only via management console? --Yakov 2017-03-02 2:24 GMT+03:00 Denis Magda : > Yasha, > > Is there any other reason rather than compatibility that prev

[jira] [Created] (IGNITE-4765) Different partition mapping for caches that use Fair Affinity Function

2017-03-01 Thread Alper Tekinalp (JIRA)
Alper Tekinalp created IGNITE-4765: -- Summary: Different partition mapping for caches that use Fair Affinity Function Key: IGNITE-4765 URL: https://issues.apache.org/jira/browse/IGNITE-4765 Project: I

Re: [VOTE] Apache Ignite 1.9.0 RC1

2017-03-01 Thread Sergey Kozlov
Hi I confirm the issue. Unfortunately it was introduced with latest commits after the run of full set of tests. On Thu, Mar 2, 2017 at 6:38 AM, Denis Magda wrote: > Getting absolutely the same exception under JDK 8. > > — > Denis > > > On Mar 1, 2017, at 3:12 PM, Valentin Kulichenko < > valenti