Re: Review of IGNITE-11521

2019-03-19 Thread Lukas Polacek
Hi, I've suggested an edit of the documentation at readme.io and updated the issue with a different description. If you can think of other use-cases for this event, please let me know. On Wed, Mar 13,

Re: Review of IGNITE-11521

2019-03-13 Thread Yakov Zhdanov
I think there should be a link on the page - Suggest edits --Yakov

Re: Review of IGNITE-11521

2019-03-13 Thread Lukas Polacek
We've changed our code to use IgniteConfiguration#setLocalEventListeners instead and it works fine, so at this point we don't need to get the pull request accepted. However, if you think it will be useful, I don't mind finishing the work. Yakov, should I create a bug for the documentation update?

Re: Review of IGNITE-11521

2019-03-13 Thread Yakov Zhdanov
Lukas, would you be so kind as to suggest edits for the mentioned documentation page. Your suggesions will be reviewed and incorporated. Thanks! --Yakov

Re: Review of IGNITE-11521

2019-03-12 Thread Lukas Polacek
Hi, I didn't know that IgniteConfiguration#setLocalEventListeners existed, since we followed the documentation at readme.io which only mentions 'Ignite.events().localListen'. We'll try it to see if it works for us. In the meantime I'll expand the JIRA t

Re: Review of IGNITE-11521

2019-03-12 Thread Павлухин Иван
Hi Lukas, Thank you for your efforts! I am not 100% sure but perhaps IgniteConfiguration#setLocalEventListeners can help in your use case? But added BEFORE_CLUSTER_CONNNECTION lifecycle event can be still valuable. It is good idea to describe implemented approach in jira ticket and how can it be u

Review of IGNITE-11521

2019-03-12 Thread Lukas Polacek
Hi, this is my first contribution to Apache Ignite. I've created a bug , made a pull request which the TC Bot is happy about