Re: Replace Future.get with Future.get(int timeout) in tests

2020-12-08 Thread Ivan Daschinsky
Not only futures, there are a lot of latches, barriers etc. with same problem. вт, 8 дек. 2020 г. в 18:41, ткаленко кирилл : > It seems to be a good topic, but it seems to be left to the reviewer's > discretion. > > 08.12.2020, 18:36, "Nikolay Izhikov" : > > Hello, Igniters. > > > > Currently, we

Re: Replace Future.get with Future.get(int timeout) in tests

2020-12-08 Thread ткаленко кирилл
It seems to be a good topic, but it seems to be left to the reviewer's discretion. 08.12.2020, 18:36, "Nikolay Izhikov" : > Hello, Igniters. > > Currently, we have a lot of usages `Future.get` without a timeout in tests. > In case the test that uses `Future.get` is flaky it can lead to the whole

Replace Future.get with Future.get(int timeout) in tests

2020-12-08 Thread Nikolay Izhikov
Hello, Igniters. Currently, we have a lot of usages `Future.get` without a timeout in tests. In case the test that uses `Future.get` is flaky it can lead to the whole suite hang. Is there any reason to use the get method without a timeout? Can we a. Replace all invocation of get with the timeou