Re: Orphaned, duplicate, and main-class tests!

Hello, fellow Ignite developers! I'm still waiting for review on ticket https://issues.apache.org/jira/browse/IGNITE-9215 Please check out https://github.com/apache/ignite/pull/8052 Thanks! -- Ilya Kasnacheev пт, 7 авг. 2020 г. в 14:54, Ilya Kasnacheev : > Hello! > > I have uncommented yet a

Re: Orphaned, duplicate, and main-class tests!

Hello! I have uncommented yet another batch, plus some minor code improvement. Please review: https://issues.apache.org/jira/browse/IGNITE-9215 https://issues.apache.org/jira/browse/IGNITE-9215 Regards, -- Ilya Kasnacheev ср, 5 февр. 2020 г. в 17:30, Ilya Kasnacheev : > Hello! > > Just to res

Re: Orphaned, duplicate, and main-class tests!

Hello! Just to resurrect this old thread: I have uncommented another batch of tests, would appreciate a review of PR: https://issues.apache.org/jira/browse/IGNITE-9216 Regards, -- Ilya Kasnacheev ср, 31 окт. 2018 г. в 15:22, Ilya Kasnacheev : > Hello! > > So we have uncommented 4 batches out

Re: Orphaned, duplicate, and main-class tests!

Hello! So we have uncommented 4 batches out of 10! 6 to go. Some broken functionality were exposed. There is still work to do, so do not hesitate to assign a subtask to yourself. Regards, -- Ilya Kasnacheev ср, 15 авг. 2018 г. в 19:42, Ilya Kasnacheev : > Hello! > > So we have enabled a firs

Re: Orphaned, duplicate, and main-class tests!

Hello! So we have enabled a first batch of tests: https://github.com/apache/ignite/pull/4504 How it was done: I have uncommented classes. Some of these were absent in code base, so I have checked if we didn't lose anything important - they were testing CLOCK mode which isn't with us for some time

Re: Orphaned, duplicate, and main-class tests!

Hello! Thank you Dmitriy, and thanks to everybody who participated in discussions. I have created tickets for next steps: https://issues.apache.org/jira/browse/IGNITE-9210 (with subtasks) https://issues.apache.org/jira/browse/IGNITE-9222 https://issues.apache.org/jira/browse/IGNITE-9223 As usual

Re: Orphaned, duplicate, and main-class tests!

Hi Igniters, I've merged chages for following tickets IGNITE-7615: Find orphaned tests without test suites, create separate test suite for them; IGNITE-8344: Remove duplicate tests and suites; IGNITE-8345: Streamline tests' class names: mark Abstract and Load tests obviously so; After including t

Re: Orphaned, duplicate, and main-class tests!

Hi Ilya, could you please actualize this PR. TC Bot can now detect newly contributed tests' failures, so I think it is best point to apply you change. Sincerely, Dmitriy Pavlov пт, 25 мая 2018 г. в 18:16, Eduard Shangareev : > Igniters, > > While making review I checked next main-method tests:

Re: Orphaned, duplicate, and main-class tests!

Igniters, While making review I checked next main-method tests: org.apache.ignite.loadtests.mapper.GridContinuousMapperLoadTest1 org.apache.ignite.loadtests.mapper.GridContinuousMapperLoadTest2 And I have found that they are totally outdated! They use config which was changed a long time ago. An

Re: Orphaned, duplicate, and main-class tests!

Hello, Igniters! One moment more of your time. One, we seem to have a consensus now that tests should be added to suites, but commented out. They should be uncommented out later, for which numerous tickets will be created. This way we can tackle. Another issue sprang up, just now I have discovere

Re: Orphaned, duplicate, and main-class tests!

Hello Dmitry, igniters! Still, the policy of removal of unused tests is not clear to me. We have roughly three groups of such tests: - Odd ancient main class tests. I think we can remove those. - JVM features/quirks tests (some are main class, some are JUnit tests. Reside in package jvmtest. Shou

Re: Orphaned, duplicate, and main-class tests!

Ilya, I guess we can remove all these suites GridActivationAtomicCacheSuit GridActivationCacheAbstractTestSuit GridActivationLocalAndNearCacheSuit GridActivationPartitionedCacheSuit GridActivationReplicatedCacheSuit They became not relevant after standby mode became part of the basic functionali

Re: Orphaned, duplicate, and main-class tests!

Yakov, Agree. On Tue, Apr 24, 2018 at 6:11 AM, Yakov Zhdanov wrote: > Alexey Goncharuk, Vladimir Ozerov, what do you think about these tests? > > I believe they were created as a part of variuos optimization and profiling > activities. I also think we can remove them since nobody cares about th

Re: Orphaned, duplicate, and main-class tests!

I agree with Yakov here. If nobody responds here we can consider we have lazy consensus on removal of tests. I'm going to review PRs from Ilya. вт, 24 апр. 2018 г. в 6:11, Yakov Zhdanov : > Alexey Goncharuk, Vladimir Ozerov, what do you think about these tests? > > I believe they were created as

Re: Orphaned, duplicate, and main-class tests!

Alexey Goncharuk, Vladimir Ozerov, what do you think about these tests? I believe they were created as a part of variuos optimization and profiling activities. I also think we can remove them since nobody cares about them for too long. Thoughts? Yakov Zhdanov ср, 18 апр. 2018 г., 16:42 Ilya Kas

Re: Orphaned, duplicate, and main-class tests!

Hello! I have reworked my change in three commits: https://github.com/apache/ignite/pull/3464 Part one is to delete some duplicate/unused tests and suites - IGNITE-8344 Part two is to rename abstract tests to *AbstractTest and load/performance t

Re: Orphaned, duplicate, and main-class tests!

What's up with the following files: GridActivationAtomicCacheSuit GridActivationCacheAbstractTestSuit GridActivationLocalAndNearCacheSuit GridActivationPartitionedCacheSuit GridActivationReplicatedCacheSuit May I remove them? -- Ilya Kasnacheev 2018-04-19 16:41 GMT+03:00 Ilya Kasnacheev : >

Re: Orphaned, duplicate, and main-class tests!

Hello! I have also noticed that we seem to miss a Cassandra test suite. We have a Cassandra module with quite a few tests, but they're not in any suite. Maybe we should set one up? -- Ilya Kasnacheev 2018-04-18 16:42 GMT+03:00 Ilya Kasnacheev : > Hello! > > I've decided to return to this tas

Re: Orphaned, duplicate, and main-class tests!

Ilya, what's the reason to create new thread with unreadable history attached? 2018-04-18 17:07 GMT+03:00 Ilya Kasnacheev : > Hello! > > Most of tests were committed by Semyon Boikov. I hope he can shed some > light on the purpose of those. > > E.g. GridBasicPerformanceTest. > > -- > Ilya Kasnac

Re: Orphaned, duplicate, and main-class tests!

Hello! Most of tests were committed by Semyon Boikov. I hope he can shed some light on the purpose of those. E.g. GridBasicPerformanceTest. -- Ilya Kasnacheev 2018-04-18 16:51 GMT+03:00 Dmitry Pavlov : > Hi Ilya, > > could you please involve authors to this dicussions personally? What git > a

Re: Orphaned, duplicate, and main-class tests!

Hi Ilya, could you please involve authors to this dicussions personally? What git annotate says us about test author? Can I hope you would provide assistance to MakeTC Green in case some returned to CI classes will began to fail? Sincerely, Dmitriy Pavlov ср, 18 апр. 2018 г. в 16:42, Ilya Kasna

Re: Orphaned, duplicate, and main-class tests!

Hello! I've decided to return to this task after a break. Can you please tell me why do we have main-class tests? Such as GridBasicPerformanceTest.class, GridBenchmarkCacheGetLoadTest.class, GridBoundedConcurrentLinkedHashSetLoadTest.class, GridCacheDataStructuresLoadTest.class,

Re: Orphaned, duplicate, and main-class tests!

Anton, >Tests should be attached to appropriate suites This I can do > and muted if necessary, Issues should be created on each mute. This is roughly a week of work. I can't spare that right now. I doubt anyone can. Can we approach this by smaller steps? -- Ilya Kasnacheev 2018-02-06 19:55

Re: Orphaned, duplicate, and main-class tests!

Val, Tests should be attached to appropriate suites and muted if necessary, Issues should be created on each mute. On Tue, Feb 6, 2018 at 7:23 PM, Valentin Kulichenko < valentin.kuliche...@gmail.com> wrote: > Anton, > > I tend to agree with Ilya that identifying and fixing all the possible > bro

Re: Orphaned, duplicate, and main-class tests!

Anton, I tend to agree with Ilya that identifying and fixing all the possible broken tests in one go is not feasible. What is the proper way in your view? What are you suggesting? -Val On Mon, Feb 5, 2018 at 2:18 AM, Anton Vinogradov wrote: > Ilya, > > 1) Still see no reason for such changes.

Re: Orphaned, duplicate, and main-class tests!

Ilya, 1) Still see no reason for such changes. Does this break something? 2) Looks like you're trying to add Trash*TestSuite.java which will never be refactored. We should do everything in proper way now, not sometime. 3) Your comments looks odd to me. Issue should be resolved in proper way. On

Re: Orphaned, duplicate, and main-class tests!

Anton, 1) We already have ~100 files named "*AbstractTest.java". Renaming these several files will help checking for orphaned tests in the future, as well as increasing code base consistency. 2) This is huge work that is not doable by any single developer. While IgniteLostAndFoundTestSuite can be

Re: Orphaned, duplicate, and main-class tests!

Ilya, 1) I don't think it's a good idea to rename classes to *AbstractTest.java since they already have abstract word at definition. We can perform such renaming only in case whole project will be refactored, but I see no reason to do this. 2) All not included test should be included to appropria

Re: Orphaned, duplicate, and main-class tests!

Hi Ilya, Thank you for this research. I think it is useful for community to identify and remove obsolete tests (if any), and include lost test into CI run chain (if applicable). For test with main() methods I suggest to ask authors (git annotate) and if there is no response probably we should rem