Re: Null cache names

2017-07-03 Thread Roman Shtykh
Shall we add the notes to REST and memcached docs pages that "default" cache has to be specified in xml configs? Otherwise it is not created and "cacheName" cannot be optional (as REST API docs say) -- no default cache. https://apacheignite.readme.io/docs/rest-api -- Roman On Monday, Ap

Re: Null cache names

2017-04-26 Thread Denis Magda
Thanks, Roman! As I see the changes have been already incorporated in 2.0. Please document them on 2.0 specific Redis documentation: https://apacheignite.readme.io/docs/redis-20 — Denis > On Apr 25, 2017, at 10:58 PM, Roman Shtykh wrote: > > Deni

Re: Null cache names

2017-04-25 Thread Roman Shtykh
Denis, PR is created. https://issues.apache.org/jira/browse/IGNITE-5083 for review. We will have to find a good solution to "externalize" the default cache name in future, as Vladimir suggested. As Igor pointed out, probably for memcached too.I'll create another JIRA issue for that. Roman

Re: Null cache names

2017-04-25 Thread Denis Magda
> So it is approach 1 ("redis_cache") I proposed initially. Any concerns? If it > is ok, I set Redis to that cache and update the documentation. Let’s handle the way Roman suggests. Don’t see any reason why we keep discussing this if the whole story is about a “one line” fix. Roman, could you i

Re: Null cache names

2017-04-25 Thread Roman Shtykh
Vladimir, I agree. But, if I get it right, according to your concern for using memcached and Redis simultaneously, we'll need a separate default cache for each. So it is approach 1 ("redis_cache") I proposed initially. Any concerns? If it is ok, I set Redis to that cache and update the documenta

Re: Null cache names

2017-04-25 Thread Sergi Vladykin
Agree, lets move forward with the simplest possible solution for now. Sergi 2017-04-25 13:07 GMT+03:00 Vladimir Ozerov : > Folks, > > I do not think it is legal to add such property to ConnectorConfiguration. > Connector is a generic gateway to cluster resources. It should not bother > about cac

Re: Null cache names

2017-04-25 Thread Vladimir Ozerov
Folks, I do not think it is legal to add such property to ConnectorConfiguration. Connector is a generic gateway to cluster resources. It should not bother about caches anyhow. What if there are multiple caches in the cluster? What is I want to access "cache A" from Memcached and "cache B" from Re

Re: Null cache names

2017-04-24 Thread Roman Shtykh
Igor, +1 from me.We can add a field to ConnectorConfiguration (not sure if it's a proper place, but it's shared by REST, memcached and Redis). A user will have to create a cache, configure as needed and specify the name in ConnectorConfiguration. Roman On Monday, April 24, 2017 10:34 PM,

Re: Null cache names

2017-04-24 Thread Roman Shtykh
configuration, but a real cache name in Ignite settings). Roman On Mon, 4/24/17, Seliverstov Igor wrote: Subject: Re: Null cache names To: dev@ignite.apache.org, "Roman Shtykh" Received: Monday, April 24, 2017, 10:49 PM Roman, Why ca

Re: Null cache names

2017-04-24 Thread Seliverstov Igor
Roman, Why can't we use just some kind of mapping to bind Redis database ID to cache name and define it via xml or programmatically? In this case 0 database will be mapped to a default cache, so that we won't break abstraction in Redis terms. Regards, Igor 2017-04-24 12:43 GMT+03:00 Roman Shtyk

Re: Null cache names

2017-04-24 Thread Dmitriy Setrakyan
Can we just use the name "default" in such cases? On Mon, Apr 24, 2017 at 6:33 AM, Seliverstov Igor wrote: > Dear Igniters, > > Seems we have almost the same issue with Memcached protocol. > > There is an ability to define a cache name via operation extras message > part ( > https://github.com/m

Re: Null cache names

2017-04-24 Thread Seliverstov Igor
Dear Igniters, Seems we have almost the same issue with Memcached protocol. There is an ability to define a cache name via operation extras message part ( https://github.com/memcached/memcached/wiki/BinaryProtocolRevamped#packet-structure) but it looks a bit complicated from my point of view...

Re: Null cache names

2017-04-24 Thread Roman Shtykh
Vladimir, Probably we may set the cache name via  https://redis.io/commands/client-setname, save it and use until the user specifies another name. #That will be the name for the default cache (mainly for STRING data). For other data types, like hashes (https://redis.io/topics/data-types), I am t

Re: Null cache names

2017-04-24 Thread Roman Shtykh
Alexey, Thank you for sharing the idea. "REDIS_CACHE" can be specified in xml or programmatically (as in your example). If not, Ignite will behave in the same way when a cache the user intends to use is not created (I think it will produce an error or warning).I.e. it is a normal cache a user en

Re: Null cache names

2017-04-24 Thread Vladimir Ozerov
Roman, Is it possible to define a kind of property in Redis connection string (or property map) for this purpose? IMO ideally we should "externalize" cache name somehow, so that it can be changed with no changes to user's code. Alex, Not sure if this is a good idea as you will end up with PARTITIO

Re: Null cache names

2017-04-23 Thread Alexey Kuznetsov
Roman, Just as idea, how about in case of user does not configured "REDIS_CACHE" then create it via ignite.getOrCreateCache(new CacheConfiguration("REDIS_CACHE")) and prin warning to log "REDIS_CACHE not configured, using default partitioned cache". What do you think? On Mon, Apr 24, 2017 at 10

Re: Null cache names

2017-04-23 Thread Roman Shtykh
Denis, Igor, What can be done now 1. create a default cache name for Redis data, e.g. "REDIS_CACHE" that has to be configured explicitly in xml file (as it is done with other caches) by a user if he/she needs Redis protocol. 2. Force users to specify cache names as prefix to their keys, so that w

Re: Null cache names

2017-04-23 Thread Denis Magda
Roman, would you suggest a quick solution for the redis integration or even implement it in the nearest couple of days? We need to change the defaul cache name in 2.0. Otherwise, it can be done only in an year or so in 3.0. Denis On Sunday, April 23, 2017, Seliverstov Igor wrote: > Hi Roman, >

Re: Null cache names

2017-04-23 Thread Seliverstov Igor
Hi Roman, The ticket number is IGNITE-3488. It's planned not to have null-named or default caches at all. All the caches must be defined explicitly or via templates and have names. The current implementation uses a cache with null name, so, we need some configuration property to define which cach

Re: Null cache names

2017-04-21 Thread Roman Shtykh
Hi Igor, The current implementation supports only STRING data type of Redis. In addition, AFAIK, scaling Redis per dataset is normally done via running separate instances of Redis for each dataset. Therefore my choice was storing to the default cache. It looks fine from Redis' perspective, but p

Re: Null cache names

2017-04-21 Thread Denis Magda
Copying Roman S. in the discussion. — Denis > On Apr 21, 2017, at 4:17 AM, Seliverstov Igor wrote: > > Hi Roman, > > As far as I inderstand you're the author of the Redis protocol > implementation. > > Currently I'm working on a task to prohibit null names for caches and I've > found that cur