Re: Migration to JUnit 5

2019-07-05 Thread Ivan Fedotov
Ivan, thank you for clarification. If nobody is against I can uncomment them in the context of IGNITE-711. пт, 5 июл. 2019 г. в 11:33, Павлухин Иван : > Ivan, > > I think that it is a really good that you found those not tested > examples. Thank you! > > пт, 5 июл. 2019 г. в 11:31, Павлухин Иван

Re: Migration to JUnit 5

2019-07-05 Thread Павлухин Иван
Ivan, I think that it is a really good that you found those not tested examples. Thank you! пт, 5 июл. 2019 г. в 11:31, Павлухин Иван : > > Ivan, > > I uncommented all tests referring to IGNITE-711 [1] in > BasicExamplesSelfTest and all they passed. > > Generally, example tests are needed to be s

Re: Migration to JUnit 5

2019-07-05 Thread Павлухин Иван
Ivan, I uncommented all tests referring to IGNITE-711 [1] in BasicExamplesSelfTest and all they passed. Generally, example tests are needed to be sure that our examples launch. And commented tests refer to existing examples. So, an ideal way here is to uncomment them in scope of IGNITE-711 [1], r

Re: Migration to JUnit 5

2019-07-01 Thread Ivan Fedotov
Hi, Igniters During work on IEP-30, which is about JUnit migration, I found that some tests in examples module were commented [1] with the remark, that they should be fixed in the ticket IGNITE-711 [2] which is about the implementation of Java 8 examples. In the context of the ticket IGNITE-10973

Re: Migration to JUnit 5

2019-02-26 Thread Ivan Fedotov
Ivan, I will investigate GridAbstractTest refactoring issue more precisely when I finish with JUnit3Legacy classes. Anyway, I will keep in touch with you and the community on the most significant moments. JUnit5 docs say that functionality is not full "especially with regard to reporting". On the

Re: Migration to JUnit 5

2019-02-26 Thread Anton Vinogradov
Folks, Please make sure you keep IEP updated and each issue mentioned. On Tue, Feb 26, 2019 at 4:28 PM Павлухин Иван wrote: > Ivan, > > Thank you for detailed answers! I would put a great care to > @RunWith(JUnitPlatform.class) construction. As stated in junit5 docs > [1] it does not support al

Re: Migration to JUnit 5

2019-02-26 Thread Павлухин Иван
Ivan, Thank you for detailed answers! I would put a great care to @RunWith(JUnitPlatform.class) construction. As stated in junit5 docs [1] it does not support all features and unfortunately it is not clear how limited it is. Also, it is some kind of transitional mechanism which was not designed fo

Re: Migration to JUnit 5

2019-02-25 Thread Ivan Fedotov
Hello Nikolay. The prime benefits are more comfortable work with flaky tests, Java 8 tests compatibility, user-friendly syntaxis in parametrized tests and others. The most significant features list you can find in IEP-30 Motivation section. If you have any specific questions about JUnit5 feel fre

Re: Migration to JUnit 5

2019-02-25 Thread Nikolay Izhikov
Hello, Ivan. May be I miss some mail - if yes, can you repeat it. What is advantages of migration from junit 4 to 5? Why we should do it? пн, 25 февр. 2019 г. в 16:33, Ivan Fedotov : > Ivan, > That is my thoughts according to your questions. > > 1. I tried to implement test suits with JUnit4 co

Re: Migration to JUnit 5

2019-02-25 Thread Ivan Fedotov
Ivan, That is my thoughts according to your questions. 1. I tried to implement test suits with JUnit4 compatibility layer. The basic concept is to use @RunWith(JUnitPlatform.class) @SelectClasses ({...})[1] and on CI Ignite it works fine. 2. According to @Rules, there are several ways to solve it

Re: Migration to JUnit 5

2019-02-23 Thread Павлухин Иван
Ivan, Indeed junit5 has a lot of powerful features which can improve testing process. But first we should go through a migration process. There are several items which looks quite challenging. 1. Test suites support. Correct me if I am missed it, but I have not found a concept of test suites simi

Re: Migration to JUnit 5

2019-02-22 Thread Ivan Fedotov
Hi Ivan! Junit5 differs from JUnit4 not so strong as 4 from 3 version. Of course, we can use AssertJ and other libraries, but it is more comfortable to use functionality from the box. Moreover, the JUnit team provides strong support for its products and it is the core JUnit principle - minimize t

Re: Migration to JUnit 5

2019-02-21 Thread Павлухин Иван
Hi Ivan, Thank you for your efforts! I checked a section "Motivation" in IEP and I think that we should add more details there. You provided mostly examples of more convenient assertions. But there are other options to deal with it. E.g. AssertJ library [1] (I think that we can consider it even a

Re: Migration to JUnit 5

2019-02-21 Thread Ivan Fedotov
Dmitriy, thank you, access is fine. I have created the corresponding IEP [1]. Now I am going to continue work on this. If somebody has any suggestions or additions I am ready to discuss them. [1] https://cwiki.apache.org/confluence/display/IGNITE/IEP-30%3A+Migration+to+JUnit+5 чт, 21 февр. 2019

Re: Migration to JUnit 5

2019-02-20 Thread Dmitriy Pavlov
Done, please check access now. ср, 20 февр. 2019 г. в 21:49, Ivan Fedotov : > Dmitriy, thank you for the response. > > My wiki username is "ivanan", the related mailbox is ivanan...@gmail.com. > > ср, 20 февр. 2019 г. в 18:38, Dmitriy Pavlov : > > > Hi Ivan, > > > > Now admin service is unavailab

Re: Migration to JUnit 5

2019-02-20 Thread Ivan Fedotov
Dmitriy, thank you for the response. My wiki username is "ivanan", the related mailbox is ivanan...@gmail.com. ср, 20 февр. 2019 г. в 18:38, Dmitriy Pavlov : > Hi Ivan, > > Now admin service is unavailable (gives error 503). I'll add rights once it > is up and running. > > Could you share your w

Re: Migration to JUnit 5

2019-02-20 Thread Dmitriy Pavlov
Hi Ivan, Now admin service is unavailable (gives error 503). I'll add rights once it is up and running. Could you share your wiki username? I can't find any users who signed up in the wiki with any similar email/username Sincerely, Dmitriy Pavlov ср, 20 февр. 2019 г. в 18:26, Ivan Fedotov : >