Re: Let's force -Dfile.encoding=UTF-8

2019-01-10 Thread Ilya Kasnacheev
Hello! I'd force UTF-8 where possible. It should not be very hard to write a test to ensure that an old one works (using multijvm). Regards, -- Ilya Kasnacheev чт, 10 янв. 2019 г. в 17:21, Ivan Bessonov : > I believe that all current keys are just basic English strings and it's too > early to

Re: Let's force -Dfile.encoding=UTF-8

2019-01-10 Thread Ivan Bessonov
I believe that all current keys are just basic English strings and it's too early to say that current change breaks something, sorry. We just have to ensure that old cp-1251 MetaStorages work fine and maybe then force UTF-8 for MetaStorage in source code to avoid such problems in the future. What

Re: Let's force -Dfile.encoding=UTF-8

2019-01-10 Thread Ilya Kasnacheev
Hello! I'm afraid not, but it is still possible to force legacy encoding as a workaround. Is there an expectation that MetaStorage contains I18N keys? Regards, -- Ilya Kasnacheev чт, 10 янв. 2019 г. в 17:11, Ivan Bessonov : > Hello! > > I have a concern about MetaStorage - it uses default sy

Re: Let's force -Dfile.encoding=UTF-8

2019-01-10 Thread Ivan Bessonov
Hello! I have a concern about MetaStorage - it uses default system encoding to serialize keys. This means that after this change Windows nodes won't be able to read previous MetaStorage files. Is that OK? Is there a way to migrate old MetaStorages safely? чт, 10 янв. 2019 г. в 16:57, Ilya Kasnac

Re: Let's force -Dfile.encoding=UTF-8

2019-01-10 Thread Ilya Kasnacheev
Hello! I've merged this to master. Now we should to try run nodes in UTF-8 mode unless specified otherwise explicitly. Also added a warning on start-up if other encoding is used as it might lead to data corruption. Regards, -- Ilya Kasnacheev ср, 26 дек. 2018 г. в 19:25, Dmitriy Pavlov : > +

Re: Let's force -Dfile.encoding=UTF-8

2018-12-26 Thread Dmitriy Pavlov
+1 from my side. I think it is reasonable ср, 26 дек. 2018 г. в 19:20, Ilya Kasnacheev : > Hello! > > It was recently discovered that there's some issue in H2 which leads to > differing string encodings when they come into reducer from nodes with > different system encoding. Even if we were able