Re: Introduce separate SQL configuration

2020-03-24 Thread Вячеслав Коптилин
Hello Taras, > My be add javadoc for each changed parameter instead of list? Yep, this makes sense to me. > But we cannot reference internal packages in public API. Hmm, it is weird that out JMX beans reside are placed in internal packages. Perhaps, it is just enough to mention that the property

Re: Introduce separate SQL configuration

2020-03-23 Thread Ilya Kasnacheev
Hello! I think that we should defer changes to IgniteConfiguration to AI 3.0. Maybe it will motivate us to start work on it. Just my opinion, without any reservations. Regards. -- Ilya Kasnacheev пн, 23 мар. 2020 г. в 13:04, Taras Ledkov : > Hi, Igniters. > > I propose to introduce separat

Re: Introduce separate SQL configuration

2020-03-23 Thread Taras Ledkov
Hi, > It would be nice to provide a list of properties that can be changed at runtime Ok, I catch the your and Pavel's opinion. My be add javadoc for each changed parameter instead of list? e.g. for longQueryWarningTimeout See {@link org.apache.ignite.internal.mxbean.SqlQueryMXBean#setLongQu

Re: Introduce separate SQL configuration

2020-03-23 Thread Вячеслав Коптилин
Hello Taras, I think this is the right way. I agree with Pavel's comment. It would be nice to provide a list of properties that can be changed at runtime and remove the word “Initial” from the class name. Thanks, S. пн, 23 мар. 2020 г. в 16:54, Pavel Tupitsyn : > Hi Taras, > > I support the ide

Re: Introduce separate SQL configuration

2020-03-23 Thread Pavel Tupitsyn
Hi Taras, I support the idea, it brings some order to the IgniteConfiguration. However, I have strong objections to `Initial` prefix: > many parameters may be changed in runtime This applies to many other config properties, but we don't name them `Initial` Let's just make it SqlConfiguration. O