Re: Improve logging of Data Region configuration

2020-01-09 Thread Ilya Kasnacheev
Hello again! TC passes, review is ready. Your last chance to act before merge! Regards, -- Ilya Kasnacheev вт, 31 дек. 2019 г. в 16:01, Ilya Kasnacheev : > Hello! > > I have prepared a patch, please review. It will look like this: > > Data Regions Started: 4 > ^-- sysMemPlc region [typ

Re: Improve logging of Data Region configuration

2019-12-31 Thread Ilya Kasnacheev
Hello! I have prepared a patch, please review. It will look like this: Data Regions Started: 4 ^-- sysMemPlc region [type=internal, persistence=true, lazyAlloc=false, ... initCfg=40MB, maxCfg=100MB, usedRam=0MB, freeRam=100%, allocRam=100MB, allocTotal=0MB] ^-- default region [

Re: Improve logging of Data Region configuration

2019-12-27 Thread Ilya Kasnacheev
Hello! I have filed a ticket about this improvement, plan to start on coding. https://issues.apache.org/jira/browse/IGNITE-12505 Regards, -- Ilya Kasnacheev чт, 26 дек. 2019 г. в 12:50, Ilya Kasnacheev : > Hello! > > Okay, I will mark default region. > > We already log information about inte

Re: Improve logging of Data Region configuration

2019-12-26 Thread Ilya Kasnacheev
Hello! Okay, I will mark default region. We already log information about internal memory regions, so removing it will require a lot of consensus. However, I can clearly map them as system regions when printing. Regards, -- Ilya Kasnacheev чт, 26 дек. 2019 г. в 12:10, Ivan Pavlukhin : > Ilya

Re: Improve logging of Data Region configuration

2019-12-26 Thread Ivan Pavlukhin
Ilya, Indeed the matters can be improved. Is not it useful to mark what region is default? Also some doubts about internal memory regions. It is not obvious that we should print an information about them for every user. If we need to have some determinism about offheap memory than I can think abo