Hello,
I would like to check again status on proposed changes as the pull
request went over first (and I think second) cycle of reviews.
Looking forward for your feedback and possibility to include these
changes in Ignite 2.15 release.
Kind regards,
Łukasz
On 17.10.2022 18:56, Łukasz Dywicki
Hello,
I brought first version of PR, for now with limited set of tests:
https://github.com/apache/ignite/pull/10337
If you're ok with approach I've taken I can continue on satisfying
quality criteria and stabilization of it.
I made a sample Spring registry to prove how "injection source" could
Going forward over evaluation - I think for naming consistency reasons
we shall stay with @InjectResource cause other annotations which bring
outside values are @SpringResource, @LoggerResource and
@IgniteInstanceResource.
Making it @IgniteInject is fine for me too, but it might not fit into
I created https://issues.apache.org/jira/browse/IGNITE-17915.
Going to try updating code and see how much impact it will have.
Best,
Łukasz
On 14.10.2022 20:21, Łukasz Dywicki wrote:
Hello Semyon,
I wasn't sure if deprecation of @SpringResource would be acceptable, if
so It gives us more flexi
Hello Semyon,
I wasn't sure if deprecation of @SpringResource would be acceptable, if
so It gives us more flexibility in bringing IoC adapter layer. Linked
code is just fitted into existing boundaries, but I can update it to
deal with @IgniteInject.
I will register feature request/improvement
Hi!
This sounds like a good enhancement. Feel free to create a pull request!
As I see it, for now we should continue using SpringResource annotation (even
if it injects non-spring resources), but at the same time create a new
annotation (maybe something like @IgniteInject, I am bad with naming)
