Re: Ignite-spring-boot-autoconfigurer

2020-01-28 Thread Saikat Maitra
Hi Nikolay, Here is the release process docs for Ignite [1] We do not have docs specific to Ignite Extensions, we will need to create docs for Ignite Extensions. Please find discussion on release process below [2] Regards, Saikat [1] https://cwiki.apache.org/confluence/display/IGNITE/Release+

Re: Ignite-spring-boot-autoconfigurer

2020-01-28 Thread Nikolay Izhikov
Merged to master [1] Igniters, I want to release both modules I added. Do we have documentation, how it should be done for ignite-extensions? [1] https://github.com/apache/ignite-extensions/commit/575ec510e4d48b1e0c2ec7e4cf8d596e7de82f70 пн, 27 янв. 2020 г. в 13:06, Nikolay Izhikov : > Hello, A

Re: Ignite-spring-boot-autoconfigurer

2020-01-27 Thread Nikolay Izhikov
Hello, Alexey Kuznetsov. I have two approvals from Saikat Maitra and Maxim Stepachov. I have plans to merge spring-boot autoconfigure modules to ignite-extensions. [1] Do you want to perform additional review? [1] https://github.com/apache/ignite-extensions/pull/6 пт, 24 янв. 2020 г. в 07:41, Sa

Re: Ignite-spring-boot-autoconfigurer

2020-01-23 Thread Saikat Maitra
Hi Nikolay, Thank you for updating the PR, the changes looks good. Regards, Saikat On Wed, Jan 22, 2020 at 1:33 PM Николай Ижиков wrote: > Hello, Saikat. > > Thank you so much for the review. > > I answered your questions and resolve all the comments. > Please, take a look, one more time. > >

Re: Ignite-spring-boot-autoconfigurer

2020-01-22 Thread Николай Ижиков
Hello, Saikat. Thank you so much for the review. I answered your questions and resolve all the comments. Please, take a look, one more time. > 22 янв. 2020 г., в 07:58, Saikat Maitra написал(а): > > Hi Nikolay, > > I have reviewed the PR and shared comments. > > Please let me know if you hav

Re: Ignite-spring-boot-autoconfigurer

2020-01-21 Thread Saikat Maitra
Hi Nikolay, I have reviewed the PR and shared comments. Please let me know if you have any feedback. Regards, Saikat On Mon, Jan 20, 2020 at 2:42 PM Николай Ижиков wrote: > Hello, Saikat. > > Thanks, for feedback. > > I raised a PR [1] to `ignite-extensions`. > > You can find description of t

Re: Ignite-spring-boot-autoconfigurer

2020-01-20 Thread Николай Ижиков
Hello, Saikat. Thanks, for feedback. I raised a PR [1] to `ignite-extensions`. You can find description of the new module below(examples can be found at [2]): Module provides the ability to integrate `Ignite` into you spring-boot application with zero(or minimal) configuration. After you add

Re: Ignite-spring-boot-autoconfigurer

2020-01-17 Thread Saikat Maitra
Hi Nikolay, Thank you for your email. As part of Ignite Extensions migration we are migrating Ignite Extensions to following repo. https://github.com/apache/ignite-extensions We have added flink and pub-sub modules and few additional modules are open in PR. You can refer to this PR to see how w

Re: Ignite-spring-boot-autoconfigurer

2020-01-17 Thread Николай Ижиков
Tests added. Please, review. Saikat, can you help with this PR [1]? I think it should be added as a separate module as we do with the flink integration. Can you help me with it? Do we have some how-to for it? [1] https://github.com/apache/ignite/pull/7237 > 16 янв. 2020 г., в 16:51, Николай Иж

Re: Ignite-spring-boot-autoconfigurer

2020-01-16 Thread Николай Ижиков
Hello, Denis. Thanks, for the feedback. Alexey, it seems, PR is ready to be reviewed, but I need some time(a day or two) to write tests. You can start with the core code review if you wish. Here are autoconfigurer requirements: 1. Start usage of Ignite with minimal(or zero) configuration. 2. C

Re: Ignite-spring-boot-autoconfigurer

2020-01-14 Thread Denis Magda
Nikolay, Thanks for contributing in this direction! That's one of the gaps on our end and the user community will be certainly thankful once we fill it in. *Alexey Kuznetsov*, as one of the Spring Boot experts, could you spend some time reviewing the changes? As for the extensions/modularization