Re: IGNITE-4487 - NPE on query execution

Alexander, I merged your PR to master, however I had to rewrite the test completely. Please review my changes carefully for further contributions: * The test was missing Apache License header * We do not create Ignite configuration and start nodes manually. startGrids() takes care of the config

Re: IGNITE-4487 - NPE on query execution

Alexander, I left my comments in the ticket. 2017-01-06 20:35 GMT+03:00 Denis Magda : > Thanks Alexander. > > Someone will review and merge your changes in the nearest time. Alex G., > can you do that? > > — > Denis > > > On Jan 6, 2017, at 5:07 AM, Александр Меньшиков > wrote: > > > > http://c

Re: IGNITE-4487 - NPE on query execution

Thanks Alexander. Someone will review and merge your changes in the nearest time. Alex G., can you do that? — Denis > On Jan 6, 2017, at 5:07 AM, Александр Меньшиков wrote: > > http://ci.ignite.apache.org/project.html?projectId=IgniteTests&tab=projectOverview&branch_IgniteTests=pull%2F1388%2F

Re: IGNITE-4487 - NPE on query execution

http://ci.ignite.apache.org/project.html?projectId=IgniteTests&tab=projectOverview&branch_IgniteTests=pull%2F1388%2Fmerge There are overview of tests. It seems okay. A little unclear because there are tests which failed also in master branch. 2016-12-29 19:49 GMT+03:00 Denis Magda : > Alexander

Re: IGNITE-4487 - NPE on query execution

Alexander, thanks. Please move the ticket from “open” into “patch available” state in JIRA and run the tests on TeamCity. Refer to the details covered there https://cwiki.apache.org/confluence/display/IGNITE/How+to+Contribute#HowtoContribute-1.CreateGitHubpull-request

Re: IGNITE-4487 - NPE on query execution

Alexey, I'm already make pull request where throw exception in that place. https://github.com/apache/ignite/pull/1388/commits 2016-12-29 11:16 GMT+03:00 Alexey Goncharuk : > I think that If fallbacks(...) returns an empty nodes collection, then we > should fail with an exception. > > 2016-12-28

Re: IGNITE-4487 - NPE on query execution

I think that If fallbacks(...) returns an empty nodes collection, then we should fail with an exception. 2016-12-28 22:06 GMT+03:00 Denis Magda : > Alexander, added you to the contributors list. Please check that you can > assign the ticket on yourself. > > — > Denis > > > On Dec 28, 2016, at 2:1

Re: IGNITE-4487 - NPE on query execution

Alexander, added you to the contributors list. Please check that you can assign the ticket on yourself. — Denis > On Dec 28, 2016, at 2:15 AM, Александр Меньшиков wrote: > > > Username: sharpler > > Full Name: Alexander Menshikov > > > > 2016-12-27 22:57 GMT+03:00 Denis Magda

Re: IGNITE-4487 - NPE on query execution

Username: sharpler Full Name: Alexander Menshikov 2016-12-27 22:57 GMT+03:00 Denis Magda : > Alexander, > > I need to know your JIRA ID in order to add you to the contributors list. > > As for your questions, this situation might be caused by the race when a > cache is being stopped and there

Re: IGNITE-4487 - NPE on query execution

Alexander, I need to know your JIRA ID in order to add you to the contributors list. As for your questions, this situation might be caused by the race when a cache is being stopped and there are still scan queries running in parallel. So, in general it’s not about data loss. Sam, Alex G., coul