Re: IGNITE-3337

2016-06-29 Thread Saikat Maitra
Thank you Andrey!! Saikat On Wed, Jun 29, 2016 at 4:49 PM, Andrey Novikov wrote: > Hi Saikat! > > I’ve just reviewed and merged your pull request. > > Thank you for your contribution! > > — > Andrey > > On Wed, Jun 29, 2016 at 3:25 AM, Saikat Maitra > wrote: > > > Hello Andrey, > > > > I have

Re: IGNITE-3337

2016-06-29 Thread Andrey Novikov
Hi Saikat! I’ve just reviewed and merged your pull request. Thank you for your contribution! — Andrey On Wed, Jun 29, 2016 at 3:25 AM, Saikat Maitra wrote: > Hello Andrey, > > I have updated the PR. Please review and share feedback. > > https://github.com/apache/ignite/pull/816 > > Regards >

Re: IGNITE-3337

2016-06-28 Thread Saikat Maitra
Hello Andrey, I have updated the PR. Please review and share feedback. https://github.com/apache/ignite/pull/816 Regards Saikat On Thu, Jun 23, 2016 at 8:41 PM, Saikat Maitra wrote: > Thank you Andrey > > I will update the PR accordingly. > > Regards > Saikat > > On Thu, Jun 23, 2016 at 12:33

Re: IGNITE-3337

2016-06-23 Thread Saikat Maitra
Thank you Andrey I will update the PR accordingly. Regards Saikat On Thu, Jun 23, 2016 at 12:33 PM, Andrey Novikov wrote: > Saint, > > I've reviewed your PR and left comments in the ticket. > > > On Tue, Jun 21, 2016 at 1:14 AM, Saikat Maitra > wrote: > > > Hi Alexey , Sergey > > > > Thank yo

Re: IGNITE-3337

2016-06-23 Thread Andrey Novikov
Saint, I've reviewed your PR and left comments in the ticket. On Tue, Jun 21, 2016 at 1:14 AM, Saikat Maitra wrote: > Hi Alexey , Sergey > > Thank you for your time and reviewing the PR. I agree we can deprecate > cacheName for metadata command. I have updated the files and request you to > re

Re: IGNITE-3337

2016-06-20 Thread Saikat Maitra
Hi Alexey , Sergey Thank you for your time and reviewing the PR. I agree we can deprecate cacheName for metadata command. I have updated the files and request you to review the changes. Also can you please share where the docs are hosted and I can then update the rest api doc. Regards Saikat On

Re: IGNITE-3337

2016-06-20 Thread Sergey Kozlov
Hi Saikat and Alexey. I think that the solution suggested by Alexey is simple one. Actually null-named cache is widely used for now and we can't remove it (or at least we should re-think the approach for such caches). On the other hand the size of metadata returned by REST command even for dozen c

Re: IGNITE-3337

2016-06-20 Thread Alexey Kuznetsov
Hi, Saikat I reviewed you PR and I think we should deprecate "cacheName" parameter in metadata command. In current implementation when "cacheName" was not specified that means to get "default" cache (with name=null) And now it will be impossible to take metadata for such cache. But I think for