Re: Google Guava in Ignite 3

2021-08-06 Thread Alexander Polovtcev
Thank you for the reply, Courtney! > We use Ignite entirely as a thick client and already have Guava version conflicts from other projects AFAIK and as Ivan wrote before, there are no plans of providing the thick client functionality in Ignite 3, so this may not be an issue. > Even Calcite itsel

Re: Google Guava in Ignite 3

2021-08-06 Thread Alexander Polovtcev
Zhenya, My intentions are the following: 1. Remove some copy-pasted code (like the "bytecode" module or some utility methods). Please see my original message for the links to the code. 2. Explicitly pin the Guava version to avoid conflicts in the runtime. About allowing to use Guava in the codeb

Re: Google Guava in Ignite 3

2021-08-05 Thread Courtney Robinson
Also, what impact will this have on peer class loading? Something I think shading also resolves On Thu, Aug 5, 2021 at 7:05 PM Courtney Robinson wrote: > Can I suggest shading Guava? > Guava and Netty are two notorious libraries for version conflicts because > of their popularity and usefulness

Re: Google Guava in Ignite 3

2021-08-05 Thread Courtney Robinson
Can I suggest shading Guava? Guava and Netty are two notorious libraries for version conflicts because of their popularity and usefulness. Other projects (ES for example solved it by shading them it https://github.com/elastic/elasticsearch/issues/2091#issuecomment-7156766). We use Ignite entirely

Re: Google Guava in Ignite 3

2021-08-05 Thread Zhenya Stanilovsky
alexpolovtcev please clarify what do you mean under : «possibility of using Guava in Ignite 3», using how  necessary dependency of calcite or using like «using in our code» ? If using in code, i -1 here. thanks.     >Hello, dear Igniters! > >I would like to discuss the possibility of using Guava

Re: Google Guava in Ignite 3

2021-08-05 Thread Ivan Daschinsky
>> A user might want to use one more version. Am I wrong, but user is supposed to use thin client in ignite 3? So why we should care about guava since, frankly, it is not needed in thin client and we can make it not dependent on guava at all? чт, 5 авг. 2021 г. в 18:18, Alexander Polovtcev :

Re: Google Guava in Ignite 3

2021-08-05 Thread Alexander Polovtcev
Thanks for the feedback, Andrey. Let me address your arguments: > Original Bytecode module depends on 26.0-jre Calcite depends on 29.0-jre We maybe will use some other version. A user might want to use one more version. This problem exists regardless of the fact that we allow using Guava in Igni

Re: Google Guava in Ignite 3

2021-08-05 Thread Konstantin Orlov
Hi, Andrey! But what should we do with Calcite then? It already brings Guava to the project. Should we considered exclusion of the main and only query engine from the Ignite-3.0? -- Regards, Konstantin Orlov > On 5 Aug 2021, at 17:23, Andrey Mashenkov wrote: > > -1 > It is sad to say -1

Re: Google Guava in Ignite 3

2021-08-05 Thread Andrey Mashenkov
-1 It is sad to say -1, as Guava has very useful stuff and it looks easier to add it as a dependency rather than copy-paste a code. My concerns are: 1. Original Bytecode module depends on 26.0-jre Calcite depends on 29.0-jre We maybe will use some other version. A user might want to use one more ve

Re: Google Guava in Ignite 3

2021-08-05 Thread Konstantin Orlov
+1, I considered it a necessary evil -- Regards, Konstantin Orlov > On 5 Aug 2021, at 16:37, Alexei Scherbakov > wrote: > > +1 > > чт, 5 авг. 2021 г. в 16:12, Alexander Polovtcev : > >> Hello, dear Igniters! >> >> I would like to discuss the possibility of using Guava >>

Re: Google Guava in Ignite 3

2021-08-05 Thread Alexei Scherbakov
+1 чт, 5 авг. 2021 г. в 16:12, Alexander Polovtcev : > Hello, dear Igniters! > > I would like to discuss the possibility of using Guava > in Ignite 3. I know about the > restrictive > policy of using it in Ignite 2, but I have the following reasons: > > 1. We are