Re: Get rid of @Nullable and @NotNull

2020-04-03 Thread Ilya Kasnacheev
Hello! I think that we should stick with existing coding guidelines, you may use Nullable to specify that something may be null and it's fine. Then, everything else is assumed not null and problem solved, NotNull not needed. Regards, -- Ilya Kasnacheev пт, 27 мар. 2020 г. в 10:58, Anton Vinog

Re: Get rid of @Nullable and @NotNull

2020-03-27 Thread Anton Vinogradov
re more > > objects that not null by nature than nullable. So if you should mark only > > all @NotNull objects, you will need to place much more annotations than > if > > mark only @Nullable objects. > > > > Kind regards, > > Sergey Kosarev > > > > &g

Re: Get rid of @Nullable and @NotNull

2020-03-27 Thread Dmitriy Pavlov
Ivan Pavlukhin [mailto:vololo...@gmail.com] > Sent: 27 March 2020 13:28 > To: dev > Subject: Re: Get rid of @Nullable and @NotNull > > Here is my opinion. As we do not have a common practice to use @Nullable > and @NotNull annotations everywhere I would consider every not annotated &g

RE: Get rid of @Nullable and @NotNull

2020-03-27 Thread Sergey-A Kosarev
Pavlukhin [mailto:vololo...@gmail.com] Sent: 27 March 2020 13:28 To: dev Subject: Re: Get rid of @Nullable and @NotNull Here is my opinion. As we do not have a common practice to use @Nullable and @NotNull annotations everywhere I would consider every not annotated item as effectively @Nullable. @NotNu

Re: Get rid of @Nullable and @NotNull

2020-03-27 Thread Ivan Pavlukhin
Here is my opinion. As we do not have a common practice to use @Nullable and @NotNull annotations everywhere I would consider every not annotated item as effectively @Nullable. @NotNull seems a useful annotation for me, sometimes it is a really good thing to assume that something cannot be null ins

Re: Get rid of @Nullable and @NotNull

2020-03-27 Thread Denis Garus
Hi! I'm not sure that @Nullable can really fix the NPE problem. Currently, we have @Nullable annotation and NPE simultaneously. The best way to avoid NPE is by using a null object pattern. I agree we shouldn't rely on @Nullable. пт, 27 мар. 2020 г. в 12:58, Sergey Antonov : > I disagree. > > Int

Re: Get rid of @Nullable and @NotNull

2020-03-27 Thread Sergey Antonov
I disagree. Intellij idea IDE has a static code analysis, which uses that annotation too. IDE highlights possible problems. It helps to make our code more stable and bugless. пт, 27 мар. 2020 г. в 12:06, Pavel Tupitsyn : > I disagree, it would be a step back. > > > What's the reason for using it

Re: Get rid of @Nullable and @NotNull

2020-03-27 Thread Pavel Tupitsyn
I disagree, it would be a step back. > What's the reason for using it? Null was a billion dollar mistake [1]. NullPointerExceptions happen quite a lot in Ignite, and annotations provide some clues to avoid those. [1] https://en.wikipedia.org/wiki/Tony_Hoare#Apologies_and_retractions On Fri, Mar