Re: Check indexes inline size tool

2020-04-30 Thread Ivan Pavlukhin
This one is among other features "missing without a good reason" [1]. [1] https://issues.apache.org/jira/browse/IGNITE-11402 Best regards, Ivan Pavlukhin чт, 30 апр. 2020 г. в 17:18, Ilya Kasnacheev : > > Hello! > > I don't think it ever worked. CREATE INDEX has INLINE_SIZE clause, CREATE > TABL

Re: Check indexes inline size tool

2020-04-30 Thread Ilya Kasnacheev
Hello! I don't think it ever worked. CREATE INDEX has INLINE_SIZE clause, CREATE TABLE does not. Regards, -- Ilya Kasnacheev ср, 29 апр. 2020 г. в 20:35, Denis Magda : > Folks, > > > > > > > Unfortunately and embarrassingly, we still do not support passing > > INLINE_SIZE to CREATE TABLE, at

Re: Check indexes inline size tool

2020-04-29 Thread Denis Magda
Folks, > > > Unfortunately and embarrassingly, we still do not support passing > INLINE_SIZE to CREATE TABLE, at least in 2.8.0. I'm confused about this statement. Are we talking about an issue/regression that slipped into 2.8.0? I do believe the feature worked before. - Denis On Tue, Apr 28

Re: Check indexes inline size tool

2020-04-28 Thread Sergey Antonov
Hi, the ticket is ready for review. [1] https://github.com/apache/ignite/pull/7728 вт, 28 апр. 2020 г. в 14:39, Sergey Antonov : > Maxim, I'm talking about cluster upgrade through cluster stop -> binary > update -> cluster start. > > вт, 28 апр. 2020 г. в 14:37, Maxim Muzafarov : > >> Sergey, >>

Re: Check indexes inline size tool

2020-04-28 Thread Sergey Antonov
Maxim, I'm talking about cluster upgrade through cluster stop -> binary update -> cluster start. вт, 28 апр. 2020 г. в 14:37, Maxim Muzafarov : > Sergey, > > Are you talking about a cluster rolling upgrade feature? AFAIK, Apache > Ignite doesn't support this feature, so why we should care about i

Re: Check indexes inline size tool

2020-04-28 Thread Maxim Muzafarov
Sergey, Are you talking about a cluster rolling upgrade feature? AFAIK, Apache Ignite doesn't support this feature, so why we should care about it? On Tue, 28 Apr 2020 at 14:32, Sergey Antonov wrote: > > Maxim, > > > should we _reject_ joining nodes which have different > From my point of view,

Re: Check indexes inline size tool

2020-04-28 Thread Sergey Antonov
Maxim, > should we _reject_ joining nodes which have different >From my point of view, it's a breaking change on cluster update. We can get a different inline size in other scenarios too: as I know we did some improvements in calculation effective (actual) index inline size. Let's imagine, we hav

Re: Check indexes inline size tool

2020-04-28 Thread Sergey Antonov
Hello! Unfortunately, that's true. But the user can restart cluster after tables creation and create secondary indexes (CREATE INDEX) after restart. My workaround has a lot of limitations: it doesn't work with in-memory clusters, it's unuseful. вт, 28 апр. 2020 г. в 14:01, Ilya Kasnacheev : > He

Re: Check indexes inline size tool

2020-04-28 Thread Maxim Muzafarov
Sergey, Ilya, Since inline size for the `create table` clause not supported yet and the IGNITE_MAX_INDEX_PAYLOAD_SIZE is the only option, should we _reject_ joining nodes which have different IGNITE_MAX_INDEX_PAYLOAD_SIZE value instead for allowing and printing warning message? Thus we will force

Re: Check indexes inline size tool

2020-04-28 Thread Ilya Kasnacheev
Hello! Unfortunately and embarrassingly, we still do not support passing INLINE_SIZE to CREATE TABLE, at least in 2.8.0. This means IGNITE_MAX_INDEX_PAYLOAD_SIZE is the only option to create an implicit primary key index with specified inline size. Regards, -- Ilya Kasnacheev вт, 28 апр. 2020

Re: Check indexes inline size tool

2020-04-28 Thread Sergey Antonov
Hi Denis, The problem could be shown when you invoke CREATE INDEX without the INLINE_SIZE parameter. You don't face with described problem If index creates by CREATE_INDEX with explicit INLINE SIZE value. вт, 28 апр. 2020 г. в 02:31, Denis Magda : > Hi Sergey, > > Your changes look useful from t

Re: Check indexes inline size tool

2020-04-27 Thread Denis Magda
Hi Sergey, Your changes look useful from the application developer perspective. However, I'm curious why would the one change some low-level IGNITE_MAX_INDEX_PAYLOAD_SIZE parameter when it's advised to pass INLINE_SIZE to CREATE TABLE to change the index size cluster-wide. - Denis On Mon, Apr 2