Re: Azure Cloud IP Finder

2021-04-17 Thread Atri Sharma
Thank you so much! Special thanks to yourself for suggesting this, Ilya for reviewing and helping close it out and Sam for helping me when I was stuck :) On Fri, 16 Apr 2021, 22:38 Denis Magda, wrote: > Congrats, Atri! > > Bragged about it a bit: > https://twitter.com/denismagda/status/13831044

Re: Azure Cloud IP Finder

2021-04-16 Thread Denis Magda
Congrats, Atri! Bragged about it a bit: https://twitter.com/denismagda/status/1383104415087927297?s=20 -- Denis Magda, VP, Developer Relations and Product Marketing On Fri, Apr 16, 2021 at 12:57 PM Ilya Kasnacheev wrote: > Hello! > > Thank you for driving this eff

Re: Azure Cloud IP Finder

2021-04-16 Thread Ilya Kasnacheev
Hello! Thank you for driving this effort, Atri. The Azure IP Finder code has been merged and will surely be a highlight in Apache Ignite 2.11. Regards, -- Ilya Kasnacheev ср, 14 апр. 2021 г. в 11:54, Atri Sharma : > Thanks for your comments. > > I have moved the dependency versions for share

Re: Azure Cloud IP Finder

2021-04-14 Thread Atri Sharma
Thanks for your comments. I have moved the dependency versions for shared versions to parent POM and also for the majorly used versions for module specific dependencies. I have also fixed the Ipv6 issue and have tested with both Ipv4 and Ipv6 and it works fine. Please let me know your thoughts.

Re: Azure Cloud IP Finder

2021-04-13 Thread Ilya Kasnacheev
Hello! I have added more comments to the PR. IPv6 still needs to be supported and dependencies' versions should be moved to parent/pom.xml, at least for shared dependencies such as log4j and jackson, and preferably for all dependencies. Regards, -- Ilya Kasnacheev вт, 13 апр. 2021 г. в 10:33,

Re: Azure Cloud IP Finder

2021-04-13 Thread Atri Sharma
Hello, Sorry for the late reply. Thank you for taking a look. Indeed, there were some issues and they have now been fixed. I am able to start a two node cluster with Azure IPFinder enabled and shut it down successfully (using Ipv4). Please see the latest iteration and let me know your thoughts

Re: Azure Cloud IP Finder

2021-04-09 Thread Ilya Kasnacheev
Hello! I have responded to the ticket after testing on live Azure. Regards, -- Ilya Kasnacheev пт, 9 апр. 2021 г. в 08:37, Atri Sharma : > Hi Ilya, > > Please let me know if I can help with any further iterations on the PR. > > Regards, > > Atri > > On Wed, Apr 7, 2021 at 5:04 PM Atri Sharma

Re: Azure Cloud IP Finder

2021-04-08 Thread Atri Sharma
Hi Ilya, Please let me know if I can help with any further iterations on the PR. Regards, Atri On Wed, Apr 7, 2021 at 5:04 PM Atri Sharma wrote: > > Hi Ilya, > > Thanks for taking a look. I was able to resolve dependencies (Thanks, > Sam!) and have updated the PR. > > Copying the jars from ign

Re: Azure Cloud IP Finder

2021-04-07 Thread Atri Sharma
Hi Ilya, Thanks for taking a look. I was able to resolve dependencies (Thanks, Sam!) and have updated the PR. Copying the jars from ignite-azure to libs works for me. Please see and let me know your thoughts. Regards, Atri On Mon, Apr 5, 2021 at 9:24 PM Ilya Kasnacheev wrote: > > Hello again

Re: Azure Cloud IP Finder

2021-04-05 Thread Ilya Kasnacheev
Hello again! I re-checked our cloud discovery options by moving ignite-aws, ignite-gce, ignite-cloud directories from lib/optional to lib/ and trying to run Ignite with simple config taken from examples. The results are the following: ignite-aws seems to work (complains about unknown key) ignite-

Re: Azure Cloud IP Finder

2021-04-05 Thread Ilya Kasnacheev
Hello! I'm not sure that I can see any attachment to your e-mail. Can you please re-send? We could have broken some of those, I guess, since we seem to not run integration tests for them. Regards, -- Ilya Kasnacheev пт, 2 апр. 2021 г. в 12:59, Atri Sharma : > Hello, > > Thank you for sharing

Re: Azure Cloud IP Finder

2021-04-02 Thread Atri Sharma
Hello, Thank you for sharing. I was finally able to replicate the issue. However, I tried with other IPFinders and ran into the same problem (attached are the logs). Not sure what is causing this? Atri On Fri, Apr 2, 2021 at 2:29 PM Ilya Kasnacheev wrote: > > Hello! > > Please find attached t

Re: Azure Cloud IP Finder

2021-04-02 Thread Ilya Kasnacheev
Hello! Please find attached the log file of errors. This is yesterday's (Apr 1) build. Regards, -- Ilya Kasnacheev пт, 2 апр. 2021 г. в 11:52, Atri Sharma : > I was able to, but then, it might be that something is cached locally. > > What errors did you run into? (I am assuming you are trying

Re: Azure Cloud IP Finder

2021-04-02 Thread Atri Sharma
I was able to, but then, it might be that something is cached locally. What errors did you run into? (I am assuming you are trying with a build from the latest iteration of the PR). Atri On Fri, Apr 2, 2021 at 2:19 PM Ilya Kasnacheev wrote: > > Hello! > > But are you successful in running a nod

Re: Azure Cloud IP Finder

2021-04-02 Thread Ilya Kasnacheev
Hello! But are you successful in running a node with Azure IP finder enabled in configuration, starting from that release directory? I amn't. Regards, -- Ilya Kasnacheev пт, 2 апр. 2021 г. в 07:42, Atri Sharma : > Hello, > > Thank you for taking a look. > > I am not sure what the confusion i

Re: Azure Cloud IP Finder

2021-04-01 Thread Atri Sharma
Hello, Thank you for taking a look. I am not sure what the confusion is. On the current iteration of PR, I am able to build and release and looking in the location you mentioned, I see: Atris-MacBook-Pro-15:libs atrisharma$ cd optional/ Atris-MacBook-Pro-15:optional atrisharma$ cd ignite-azure/

Re: Azure Cloud IP Finder

2021-04-01 Thread Ilya Kasnacheev
Hello! Were you successful with using it from the deliverable of mvn initialize -Prelease? Please refer for example to aws module dependencies section: com.amazonaws aws-java-sdk-core ${aws.sdk.version} com.amazonaws aws-java-sdk-s3 ${aws.sdk.version} com.amazo

Re: Azure Cloud IP Finder

2021-03-30 Thread Atri Sharma
Thank you for the review. I have updated the PR. Please see. On Mon, Mar 29, 2021 at 8:27 PM Ilya Kasnacheev wrote: > > Hello! > > I have left some more comments after trying this change on a real Azure > cluster. > > Regards, > -- > Ilya Kasnacheev > > > вт, 23 мар. 2021 г. в 18:32, Atri Sharma

Re: Azure Cloud IP Finder

2021-03-29 Thread Ilya Kasnacheev
Hello! I have left some more comments after trying this change on a real Azure cluster. Regards, -- Ilya Kasnacheev вт, 23 мар. 2021 г. в 18:32, Atri Sharma : > Thank you! > > I have updated the PR. Please see and let me know. > > On Tue, Mar 23, 2021 at 4:27 PM Ilya Kasnacheev > wrote: > >

Re: Azure Cloud IP Finder

2021-03-23 Thread Atri Sharma
Thank you! I have updated the PR. Please see and let me know. On Tue, Mar 23, 2021 at 4:27 PM Ilya Kasnacheev wrote: > > Hello! > > I am going to check this change out when I have time, using my Azure > account. > > Regards, > -- > Ilya Kasnacheev > > > вт, 23 мар. 2021 г. в 07:20, Atri Sharma :

Re: Azure Cloud IP Finder

2021-03-23 Thread Ilya Kasnacheev
Hello! I am going to check this change out when I have time, using my Azure account. Regards, -- Ilya Kasnacheev вт, 23 мар. 2021 г. в 07:20, Atri Sharma : > Gentle reminder on this -- please help in reviewing this. > > On Fri, Mar 19, 2021 at 10:23 AM Atri Sharma wrote: > > > > Thanks Denis

Re: Azure Cloud IP Finder

2021-03-22 Thread Atri Sharma
Gentle reminder on this -- please help in reviewing this. On Fri, Mar 19, 2021 at 10:23 AM Atri Sharma wrote: > > Thanks Denis. > > I have raised a PR for the same: > > https://github.com/apache/ignite/pull/8897 > > Regards, > > Atri > > On Wed, Mar 10, 2021 at 1:21 AM Denis Magda wrote: > > > >

Re: Azure Cloud IP Finder

2021-03-19 Thread Atri Sharma
Explanation of the design: The design follows a similar model to existing IP finders -- it either takes a pre-created container or creates a new container and creates entries in it for each IP address. I have tested it with a test account and the operation is fine. On Fri, Mar 19, 2021 at 10:23 A

Re: Azure Cloud IP Finder

2021-03-18 Thread Atri Sharma
Thanks Denis. I have raised a PR for the same: https://github.com/apache/ignite/pull/8897 Regards, Atri On Wed, Mar 10, 2021 at 1:21 AM Denis Magda wrote: > > Atri, > > Let's discuss the subj together with the community. Ignite already supports > AWS [1] and GCE [2] IP Finders out of the box,